From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C794E732F4 for ; Thu, 28 Sep 2023 17:05:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BBDC6B020F; Thu, 28 Sep 2023 13:05:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 069DA6B0213; Thu, 28 Sep 2023 13:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C896B0246; Thu, 28 Sep 2023 13:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D2C8A6B020F for ; Thu, 28 Sep 2023 13:05:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9C542A0F97 for ; Thu, 28 Sep 2023 17:05:48 +0000 (UTC) X-FDA: 81286633176.23.E1CB570 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 199D51C0034 for ; Thu, 28 Sep 2023 17:05:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f2iPwHqK; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695920746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o5/wGCofixZwvi3PH41gwKcB6yNjtyo8RsF8JyFJAyM=; b=6S70GcGWhurFKznGt2PQGg56lJvWYhm57bBtJAfI9hAbVmby1kvKLrn/g0HYvon50mqNva e+e+DRs2hAS1xkUoQMK/OFjf15IFO5wNj/pUz9d7zMyWY7pBifUO2Py7ZicvV69fDTYMXY OqVzEBYYlfTFq0xYDmkTlCHVSBfbbvM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695920746; a=rsa-sha256; cv=none; b=budh0gYwjJKLYilloD7jWt4CzzkpPhq0Dr9YPD6TFciRoe8rQQ3EVfBLuoB0ruRdPdy3J3 mNHOBRBQCfdXHfGg5bFs1CSgs+nRo57ZW0zXQzg/c+K0QJEn/d9AQsjX7HnODAQmKDl+Bl Mr7USKAvlkVPAZfdMyKragcb8LrTOPo= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f2iPwHqK; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695920745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o5/wGCofixZwvi3PH41gwKcB6yNjtyo8RsF8JyFJAyM=; b=f2iPwHqKOjfVnxAWRzTVsCPKgy2RjDTt1AD+AK1nrIXnlq5oPFlEScMHAjeu0cuQnjQbjv JhayzNQYdj9qjZS0Hz7WHAIOOG5lg/Y4n0GwHJaAJt2TKfVq0NxYS+9MxO0czCWOmDfETo hWaujJj4QTXxWOw6eH0D4thYveOD+to= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-yCSB65rVOdaFs4GAEgPSZA-1; Thu, 28 Sep 2023 13:05:44 -0400 X-MC-Unique: yCSB65rVOdaFs4GAEgPSZA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-31fed999e27so10597140f8f.2 for ; Thu, 28 Sep 2023 10:05:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695920743; x=1696525543; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o5/wGCofixZwvi3PH41gwKcB6yNjtyo8RsF8JyFJAyM=; b=WnBgm1miAmyScRKLY4V5C+8fdWvQluCRcdopotxBBDftqQM/2TjFwNLIR10GxYbYii n2Xre7ssYZoxQBUzW4EyVr/+0BXbr8BiLRJN0SwcZQ7PCm0jYAC09HOu3YRok/osYapw LKl3tAdKkW0Ez1bXSk44yZBvsqoHPcr6OEArF6GZ+V+35sw8nXR2KFfJmeCzNNU5Bj7X Qf03inW9d1dPIdXM1pFOex1CpqS/0GfzPV5dJ1lHZ29TIxPmjzqzHRaWBiEkyG0CC+gY fFAAouP4le2rJwmJQQdsvJrVVlOybmq8eHiLmLnUAZL8guypcAIPIOxQz3b0Q0BaPA3s zqOA== X-Gm-Message-State: AOJu0YyMy7uXlnahantHOO5Hec2u07VoDGb65mCAsHD2bJIPjSM3Z4O1 Szih+eI8ry1axe/CA5TdzKnhCUAy1lRNiL/+bZTae+2/4J0KeGAjQ5c8Nzv3tL6oE3k5asqQ902 OyFrx07T4LV4= X-Received: by 2002:adf:ce8b:0:b0:321:66a5:4da4 with SMTP id r11-20020adfce8b000000b0032166a54da4mr1829445wrn.2.1695920742805; Thu, 28 Sep 2023 10:05:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERTxVsRw8PBt/UNjmDxfFO2N+rZGMaLmfr39sZgf/NmLF39wf/w/uu7CxYnbR6wcmEiiC1UA== X-Received: by 2002:adf:ce8b:0:b0:321:66a5:4da4 with SMTP id r11-20020adfce8b000000b0032166a54da4mr1829421wrn.2.1695920742351; Thu, 28 Sep 2023 10:05:42 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6ff2.dip0.t-ipconnect.de. [91.12.111.242]) by smtp.gmail.com with ESMTPSA id y5-20020adfd085000000b003217c096c1esm907619wrh.73.2023.09.28.10.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 10:05:41 -0700 (PDT) Message-ID: <98b21e78-a90d-8b54-3659-e9b890be094f@redhat.com> Date: Thu, 28 Sep 2023 19:05:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 2/3] userfaultfd: UFFDIO_REMAP uABI To: Peter Xu Cc: Jann Horn , Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230923013148.1390521-1-surenb@google.com> <20230923013148.1390521-3-surenb@google.com> <03f95e90-82bd-6ee2-7c0d-d4dc5d3e15ee@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 199D51C0034 X-Rspam-User: X-Stat-Signature: 8z4tgc9ofph4fndjy9439x6cyk4xtixx X-Rspamd-Server: rspam03 X-HE-Tag: 1695920745-71962 X-HE-Meta: U2FsdGVkX1/SmAel7M717kuCDPob5DL1hBtRwyVyCHrGMbleJoyeL9PCEXHr7JsQ5Cx3dAPxntfV4KjjkYZ62MH5+ZJ8pr6ux03mSd+guD7ITOhe2pdG7G4+mZlfqAK1P7k0rnNk3wivzC4rUEOQXtUaL83ZM8JVkvXpyil134kBKyLco4eI94pEDmdgtSO5FazRckeW7f8YOJpIHcVOfPS96NOSWOPEfHQSssEwLORKv5PTTH09+qBoCRX0dKcjzcdkoUZGi2V5hntWW7aNa23KV3hCTXx03o7/9hhFVN02Zb9vBIuqlfFrRD1R8mKab7sgvZAMg5jwuPTwAVYjH5wJLdzVqvdJ+yL7vL+qDpAwhWaljPn1unqEz0xxwaZcOE8Op7SXcFRkD2/Z26XBmhL++WMsBgMMSdkrCUhO3VfHnAJ26LbgMnQG4cgr7qjvPsKz4vcRHvdtUqa+x5izgwes+dgBtmRfC+PXWxQ5B+nY2jnzH0YnLvso9Y+mHGogcvOpkNAwOGNwiSOnK9elDK+F219G/3CtOcogzVBGDcjmCVNmoEsB1ThFCx9g68rcZcpLIgcfr9RGNGX+0RivtO5wWPVp25j6KhCyThBXS5f+21V6CPaEvb93AZtqxHP1GcZu4r/iJZ7cz6b/I6IB0OzPgXzj8tP2aoOELjx4dIQerEBb0txYfXpG660m/+0vOBQroNaPZMBA+BfLTaWjJ2UskoCgjSl2qeMi0h8yZAoKpckhMTU+jqzg2sNptF8yiW71eAjpFe7oWq9I15yd/MKZlxMYnAwG3yZIBB3vxS5l1UIizCwLbM7zsVyWa04CIG4+17K4CULF61TgEpWxMHBTQo/dvQq7J0D8qOZUU/B/yZ31RlouO2CAcPVO+j4yunBZk8sSukwrp9JxTIshLQOvfG+43YVPgWR5q4moKYeUamgp4WtkaFqqHDRpVdUnKjtXD2Vn0Cot5soReJ4 MCo4z/wF l8eRUkqc7qXrih8tA22tCsaYSZKUfvfR77Vq5YxpptBPcBXwKEV4MibjKq25TY/6Rub1G6exVN5EuH1fQH9Tr84RtHWNTYsl5LrLgbpr0NiQQPGcIsWIT1bKWnQ/HmtgzfzVXUzdKVIPm5marYiDYpG5bE8Ra0UZ0JIkP8zl3DbPS+p4t5O8URacbOZdaYcCDyXjtZdwuCEzmy9ghhiJusK2cUrJQAJy5etiPwnqMarFVGt8TzA9FyBb5uZCxQWDiLYKGzaym/ARTvHDCzxW4MEn5IYN8LscmzUD2beL7x1Gq2GZ2MnJZvJAmxBKHL+cgIOsxvpaVpQQFAFtvEe5prxDfMs23wYLXlgaMq7tqXV05BDZsFPRwfj/XdtceuTSt3iszuFEP2DJWQaVTTiucTl5ZO2miAo3tBXO2yvXz9WCtIvaIGj1koxxcTT9YFTKNh8Qj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.09.23 18:24, Peter Xu wrote: > On Wed, Sep 27, 2023 at 03:29:35PM +0200, David Hildenbrand wrote: >>>> + if (!pte_same(*src_pte, orig_src_pte) || >>>> + !pte_same(*dst_pte, orig_dst_pte) || >>>> + folio_test_large(src_folio) || >>>> + folio_estimated_sharers(src_folio) != 1) { >> >> ^ here you should check PageAnonExclusive. Please get rid of any implicit >> explicit/implcit mapcount checks. > > David, is PageAnon 100% accurate now in the current tree? > > IOW, can it be possible that the page has total_mapcount==1 but missing > AnonExclusive bit in any possible way? As described as reply to v1, without fork() and KSM, the PAE bit should stick around. If that's not the case, we should investigate why. If we ever support the post-fork case (which the comment above remap_pages() excludes) we'll need good motivation why we'd want to make this overly-complicated feature even more complicated. -- Cheers, David / dhildenb