From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08799E7718B for ; Fri, 20 Dec 2024 19:31:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D546B0082; Fri, 20 Dec 2024 14:31:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FD926B0083; Fri, 20 Dec 2024 14:31:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 377716B0088; Fri, 20 Dec 2024 14:31:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1976A6B0082 for ; Fri, 20 Dec 2024 14:31:59 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8250B120C6A for ; Fri, 20 Dec 2024 19:31:58 +0000 (UTC) X-FDA: 82916330658.09.503CE77 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf18.hostedemail.com (Postfix) with ESMTP id 429421C0013 for ; Fri, 20 Dec 2024 19:31:40 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=P5IO8BVQ; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734723100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cWsdyve87/ahvL1Kdn+WU4yfF9lwFtfjevTBD3q3a5I=; b=rXrvGfwK2dFqMs7VgDsfQy5ApGoBWQe2hxyXUMcpns/ODUzClOEP/Gsr+hQ+3u1m0qUEzB mIt4ASWj2LG1tsGipHd21D77GJ5D/uhTEKtmLmyHtzaw8B2EWBDQAhpGK/LljXsAO3KPDh ZVOA5aEaLIfZGM20aHq6/K18yMLdhHo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734723100; a=rsa-sha256; cv=none; b=V6ONFImwUE7AJ8380ffn0GPvqZ9qxWTlxdUZdi9tQK6MmL5yVKoTGMQ9qZtQTgikdkyXqS kBFhzm2/bloNYI2DBms715ux/wf4uzLgu/lGbShNOYSg6tl8tV1Wu863PiUFCtzQgxHeO3 Fn2L97PTNOkuTkFgzBWsuKvi6E0i0KM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=P5IO8BVQ; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734723116; x=1766259116; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cWsdyve87/ahvL1Kdn+WU4yfF9lwFtfjevTBD3q3a5I=; b=P5IO8BVQbrOR+73+Zq3H7TD+6qYkm0mp/SrU4k28nDINOPwHjlSuCxHd qbbjSJnkdizOsMMMDlZK78QA7XUSOzI1Frk2LfY/aiafqWBh2Ql7RfmJd MZeRnlMsuJKx8maKcyxpjVgBy6HgOWPh4pbxGfX9ntOoVZBsXQwZpMQtO G3ZMa+naNNqKQDaxhG1ua/O8Znh1In/k2gOYHCvP7FN2+V1JO9Nd/w0UV QsR493QzShBEEEjQn8P/RKvm5WU60egwkKq0V48pkxLVLPa1i67CdPWQf Lp7tQCwIKiFIkr05h8oQsVQRegzVHSgXNCoPHkheT4TpvczhsTDVzE5Dh w==; X-CSE-ConnectionGUID: jp5HpPPSSPiAvKli1726Mg== X-CSE-MsgGUID: W7feDEVYQqG3CUHQEC+QlQ== X-IronPort-AV: E=McAfee;i="6700,10204,11292"; a="35498890" X-IronPort-AV: E=Sophos;i="6.12,251,1728975600"; d="scan'208";a="35498890" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 11:31:53 -0800 X-CSE-ConnectionGUID: puhYWLhrTxCkddI44a7G2Q== X-CSE-MsgGUID: ZOvVbemkRy6XjG3xptTdtg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,251,1728975600"; d="scan'208";a="98986706" Received: from jairdeje-mobl1.amr.corp.intel.com (HELO [10.124.221.219]) ([10.124.221.219]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2024 11:31:52 -0800 Message-ID: <989b55cf-1f9e-4b73-b3dd-d8b6a62be3f2@intel.com> Date: Fri, 20 Dec 2024 11:31:51 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] Account page tables at all levels To: Kevin Brodsky , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org, Joerg Roedel References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <765aec36-55a4-4161-bb30-4ff838bc2d98@arm.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <765aec36-55a4-4161-bb30-4ff838bc2d98@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 429421C0013 X-Stat-Signature: ng9qzagte8m86yjppfosr97ht7k1cjjm X-Rspam-User: X-HE-Tag: 1734723100-988561 X-HE-Meta: U2FsdGVkX1+hg9wSfI2aT/3JoxqM2zoXUqAE63LFY0K8j9AxW6JC7r8ejy6iWdPBe0IEo9cy4iBQNM2d9EUA8UJ22f2AXGPd2Ip7P3xQbG3tbx6zl33GfzoK7msZbdVnQOzsEYiNMDR8t5Oqaf3OS5WSO2CchV1kllSKcP8kbAljpJRClfMqfPqyqozEzL/ipFabhFCd7bCmRRfdHeAhuoF09nXqKVwC8EfdVFhptIEaRk/B5TDufUT5yjy8nyqp2FiMgL/z81Es3+SFHQx7z3A0LG4Fm1iSq4j1jtKuaaAtlcw4lCyqWoCdvGhcFYX3K0VwxyYcMYpbEIiYdQPEqISwquBRbZOuiNbX5S6SQnIcejz+DKy8N0tBF6pOBJgfqBF3mIUIDM3JmWAwKduOTUKw1njGBJPk6yeC6DTNBeK/9TlMdHBaz9UsTXm/6ihNp8xCnUvUXqmdVUw4JHgM6SXUqSBMnCoVaUOOlGm18q1UcimOFKBo8OinS39kI5FdQz/QATy9AQ/4U2b6ut0pFPY2O1s3/+yEHf0W7CKKc5XmvSqRNLBihOmAsYdibJfNOM2yfNYbQAxz4U7uH4EJSC8rvaxP+jbPKPT7atQ2IkDOPa6ucYWus+W0gDyJwuBBDgR5C5ZDXOVCotXUnVebSi8h1IXbhiq1fIXRGD33smA1dYileHrP0WTOzB4gQk2D5fx6AHsnO40DB06baXxntgzN6sqIsli+/KXylRO3qYdRHIBKEoNUjJp0BbbZ9Hd2LQKqVosKyCBd+Xq49EfJ2x684ucSkXN2iLetIr8UFOSC2GeeNxMIM6Q+AIFM5081ry5w2iW9mOKJPnXjtNN2kUavK/eW/Vgh8oH8gGh2/Wsm9hHdZICKN5pU/NwEYvwCeHKekEtrwDBRAz8YMa8G738ytJOFUm5E9AkYsaXHEdkv7mcB/gZfYnQaXGmys5S4WrqveivjZ8M26vvBUGC SLCY7Bow ObYXHYz3GhIqOFg/gOoOfPsagBmKNEMGEkewosNdxNkfNxVC4eOtKw93d6bpsp0LtFItrqb/WIIp/Uig/t2zq+DlIRY5LnoLKZ3mr5r5W5MeC7Iqmo4EdcGOSrubnAWvDS0HoocEWc7+c8p2kldLZqYDVrOE+BhZ43/DbNE7vSM7kDIoUUnfKpPQaM8xwY8H2OWRcMJYHr6UTP/CYMDjEGWHfDAPq7oZaJ27A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/20/24 02:58, Kevin Brodsky wrote: >> One super tiny nit is that the PAE pgd _can_ be allocated using >> __get_free_pages(). It was originally there for Xen, but I think it's >> being used for PTI only at this point and the comments are wrong-ish. >> >> I kinda think we should just get rid of the 32-bit kmem_cache entirely. > That would certainly simplify things on the x86 side! I'm not at all > familiar with that code though, would you be happy with providing a > patch? I could add it to this series if that's convenient. I hacked this together yesterday: > https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=simplify-pae-20241220 It definitely needs some more work. I'm particularly still puzzling about why SHARED_KERNEL_PMD is used both as a trigger for 32b vs. PAGE_SIZE PAE pgd allocations _and_ for the actual PMD sharing. Xen definitely needed the whole page behavior but I'm not sure why PTI did. Either way, that series should make the PAE PGDs a _bit_ less weird at the cost of an extra ~2 pages per process for folks who are running 32-bit PAE kernels with PTI disabled. But I think the diffstat is worth it: 5 files changed, 16 insertions(+), 96 deletions(-)