From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E79BC4BA0B for ; Wed, 26 Feb 2020 11:34:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E05A22467B for ; Wed, 26 Feb 2020 11:34:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E05A22467B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87D516B0003; Wed, 26 Feb 2020 06:34:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82BB86B0005; Wed, 26 Feb 2020 06:34:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7419A6B0006; Wed, 26 Feb 2020 06:34:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 5966B6B0003 for ; Wed, 26 Feb 2020 06:34:42 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 055C1181AC9CC for ; Wed, 26 Feb 2020 11:34:42 +0000 (UTC) X-FDA: 76532070804.12.kick37_804b14d177e61 X-HE-Tag: kick37_804b14d177e61 X-Filterd-Recvd-Size: 2378 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 11:34:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E02ADAF3F; Wed, 26 Feb 2020 11:34:39 +0000 (UTC) Subject: Re: [PATCH 1/3] mm/vma: Move VM_NO_KHUGEPAGED into generic header To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel@vger.kernel.org References: <1582692658-3294-1-git-send-email-anshuman.khandual@arm.com> <1582692658-3294-2-git-send-email-anshuman.khandual@arm.com> From: Vlastimil Babka Message-ID: <9899b82b-1295-97de-27da-a0a20dbe1a60@suse.cz> Date: Wed, 26 Feb 2020 12:34:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1582692658-3294-2-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/26/20 5:50 AM, Anshuman Khandual wrote: > Move VM_NO_KHUGEPAGED into generic header (include/linux/mm.h). This just > makes sure that no VMA flag is scattered in individual function files any > longer. While at this, fix an old comment which is no longer valid. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > include/linux/mm.h | 3 ++- > mm/khugepaged.c | 2 -- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 52269e56c514..6f7e400e6ea3 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -287,6 +287,8 @@ extern unsigned int kobjsize(const void *objp); > #define VM_NOHUGEPAGE 0x40000000 /* MADV_NOHUGEPAGE marked this vma */ > #define VM_MERGEABLE 0x80000000 /* KSM may merge identical pages */ > > +#define VM_NO_KHUGEPAGED (VM_SPECIAL | VM_HUGETLB) While the preprocessor doesn't mind that VM_SPECIAL is only defined later, I would have moved this below VM_SPECIAL definition anyway, where it fits better, and add a comment like other defines there do?