From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9379CEB64D9 for ; Wed, 12 Jul 2023 06:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA5FC6B0072; Wed, 12 Jul 2023 02:45:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2DC16B0075; Wed, 12 Jul 2023 02:45:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA86D6B0078; Wed, 12 Jul 2023 02:45:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1FEF6B0072 for ; Wed, 12 Jul 2023 02:45:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 91BEFAFA0F for ; Wed, 12 Jul 2023 06:45:42 +0000 (UTC) X-FDA: 81002024124.02.6C1E705 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf20.hostedemail.com (Postfix) with ESMTP id A9BE51C0025 for ; Wed, 12 Jul 2023 06:45:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="W/GvKFgl"; spf=pass (imf20.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689144340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y8WhpdF8/RW8zGFH/BZgsqEuwmUxTSnkz6bmGMUpKLg=; b=kBHqtBJF18wAGLRptfQpoGUcVrqO4R/MVcBaoZQvKla6h+v94LJPpTA+/BH0Eebr0FpXP8 asliRg02Dhy3GhIXy9jqCrqRf/gGwHdcAkBmFuVN7PsfbvIJlVa9NN2Q56ADbdsBK2/1Am oTyHrPG6QRzsfmBiTfRwkZ8XjFqfE3o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689144340; a=rsa-sha256; cv=none; b=e8fO3/x+IO4l/suD0B6cbvqfR8G7w+oZXYdGZqd9ytjExXpkWwcNHzeUeKIN0tAUfMW2yx S0Gz4tfCA8ZMIjjfa29zp6joL+L7Y1M9+X3USvH3JTTg+ZSdoAyBvuvXpz7CbEmGZXKxbo 6ZLgvouWXvxsbUgBaWIjFqEGw5eLnjA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="W/GvKFgl"; spf=pass (imf20.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-666e5f0d60bso3866488b3a.3 for ; Tue, 11 Jul 2023 23:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1689144338; x=1691736338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y8WhpdF8/RW8zGFH/BZgsqEuwmUxTSnkz6bmGMUpKLg=; b=W/GvKFglSlPxZ7GDe3SBJk00S68EMh1nVTwsJAwhPkQ3MT365bsUjoqdqE+/sA7CSN NRbg4zl/wx1Ls0jXTms3+eFHtQJyUHaiDmc3++U9grS799Xvv+6VfZ7rUTRs7OMQTQAB FWp2o073tH2I2V2BGGYkcvq9X9akSwkleCwtv4Cgn9Gl0v/0cXvmNCmhRYQdPENheFEs xGjTHkxJaBaShbI/QBVm5k2nSoBimFca0JrTPTEOBCnwYyet961sXcDsDzRAZpzsM6Db MLVmvFZEDnKOJT+7M+5szD2mCWMufCAeW02SnLCg9kpv0jB3gHFFeTNQKSCl0J7aqjAE 5n8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689144338; x=1691736338; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y8WhpdF8/RW8zGFH/BZgsqEuwmUxTSnkz6bmGMUpKLg=; b=TDiPmyNAzwArHiXcsWqzSUjqUoCEeHKp9c0HmwEPoXJJcfvYwsQV39Arx7HyOz5BXD GEfHahJyUB9LbKwNmx9SmXbgk95y8QQrKhdsQGifQ8lejU3Xyuky2a5Mu3YtW8SHiCyE /YunFDNHf9a5NC+M5dHlqAnxnm71yWNwTlXrrLJpdEIX9beM+xzBE1ZW7Ghh8Pz2lnKl r8K46PyEXMxwD0QjotM04TPUTLuizvtyPqEr5WhNziGcelosRMVIceSeenIO5f54RJAE l7CT9zSJr8Xg2pf8ZTFtcfEaYPUpHHMjRfxKEZcNJ1Fyv4fa8/jaJSkQ/Bms94/aNGpD 0Uyw== X-Gm-Message-State: ABy/qLbh9tu39GXMqjLRMXI6woOatlmHszbuvSSIs97SAbUPaQeEQCpB YtDdbpoYlyTjyYbBQ2z1JPKzxQ== X-Google-Smtp-Source: APBJJlF4k1pkoB3GqDRrCOhh7latAjS6/d0b535BaPunB3YtROa/Y2UxTSwoSRKXrxX78yz7cfx0Xg== X-Received: by 2002:a05:6a20:7f94:b0:12f:dc60:2b9e with SMTP id d20-20020a056a207f9400b0012fdc602b9emr17247332pzj.48.1689144338323; Tue, 11 Jul 2023 23:45:38 -0700 (PDT) Received: from [10.94.58.170] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id c11-20020a170902cb0b00b001aaf2e8b1eesm3085131ply.248.2023.07.11.23.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jul 2023 23:45:36 -0700 (PDT) Message-ID: <987f7855-8b1e-ad1a-29d3-8511ccaa00b2@bytedance.com> Date: Wed, 12 Jul 2023 14:45:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Re: [PATCH RESEND net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , Alexei Starovoitov , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" References: <20230711124157.97169-1-wuyun.abel@bytedance.com> <20230711204537.04cb1124@kernel.org> Content-Language: en-US From: Abel Wu In-Reply-To: <20230711204537.04cb1124@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A9BE51C0025 X-Rspam-User: X-Stat-Signature: fmmaauzyo3dqxh46kqabgnmow6xkbjoe X-Rspamd-Server: rspam03 X-HE-Tag: 1689144339-45366 X-HE-Meta: U2FsdGVkX1/66nJqMfD4d42duubWSVKyNrZkWh6phdMOo0HyF+YFDPFjUW5Kd24jR56aIYB9AAdNgU2RjictbS3FGrrrSZROEYjTXRPxNRT9sTKifCc/e23sRJynwFD9KSwADhQa/DLDh8GG6t8QX4YF5r0EO8Lsd6B3vgjzAEsb+DwCaDP8Ko+K9JvRuLQgzUTcRmdFMQlZ4ATtUeEdjGGwPZ42Tx1tC/hcRseD7xlA6sk+aaoVBnSJ+hw92FTi8xIEwXHSgsRmpmiqvPIfDdlfJi91bt4DLd9XBwCgR3XvDABixA5azdezCnW3na7bWu8A2Lzxk6YoktabIBT1ZPpYewINANn5oBEd1DeDQdtSt8K4KNyFHAXyO25eRV2Xt2UaF6VVAUejD/jVuHXQMLDblMoN0lSAuD+tohraU+z0E2n4TX/wpGZitqnYRAuti8piITQOXLxVXfNndtVtmEHoQ6x5pXCQ7SM6e0j952VrwoTGso5uFWHl1gYeHAmbseGGgcAcMbZvBFcc/zoQBvwQm1ENpiRmzUu96ppPVsWMA0m/ztjOteWYSAy1yCohdg+oMqBONVICOQKuVbCsID/9QqzsCzOQTgEMElVLXo/ssxZCIzUYrPmojk0nXrDUmGVsCWOTnhrc70YrsPTEJPjxi0q9ZZokIJDIfHD3Tr+K7Mi4FfkWKdoJMP2irYdLVjhqalxMlPlhnsG2qculWycRf2YvfqEqRs4sOyBZC0+2G/QUH+vG2EEYLfybl5v3oUbqr9skdszAvoXlu8Fl/GqOhbdXNq6xSg5q5MKPtW8Kz0TI2DXgI9rDWCUO6Sg22JP4awhNWXrZLdDEBfIS1bgcld0Kge9Zmnsj+f1e7998MuXiNPpSfqrhxAX9qCKgYZFW1D0YMwo+FBYMKZE4xauKykXRKJHWBm4Zq02DLXUR5RFnsKG1q3xOrUnOajaHaPXeavjD0feBS02mt0v 37rYuVxH BFdhxqRD0lsB8v+dF3SNfkayEN4UColoqV+VGPmVVEs5k3b/BLjFKJDfu3SOL/2Zg6Qr3szWCoBwP9Fi17iT5e6IuAA4jfpD0wBHawZASqQZQCTSFtq8X660hy7Tk9oKMad5bljC3nke2+ypUHvQmx6mJ/5kP8yxDpuLrAuXc0tl5Sx8GYbwvhzxt2iUAT7xXXE7ABQUo8z0v7QojQ5JE+MXP6QRnKfk54hKQ9obS7RGnvvbGK0l9J5YEN7yi8eqz5oACCNJcQyRnNWCkz2UXliMrDR/E87xUV+SDj67X8fBAoY8zkryUQD0noi3mN3r2Y+swZzvfN5A/yb/qUjYpwK9g+1rUBlHi9wtFf6wCGCv5juyZ0ylty/1Y4yEGKpq3yMdmh7JQF5WHnYRGBZxO831hvPk9cvWiG5BUx1V33FHet6BVBbGDPBuuAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jakub, On 7/12/23 11:45 AM, Jakub Kicinski wrote: > On Tue, 11 Jul 2023 20:41:43 +0800 Abel Wu wrote: >> Now there are two indicators of socket memory pressure sit inside >> struct mem_cgroup, socket_pressure and tcpmem_pressure. >> >> When in legacy mode aka. cgroupv1, the socket memory is charged >> into a separate counter memcg->tcpmem rather than ->memory, so >> the reclaim pressure of the memcg has nothing to do with socket's >> pressure at all. While for default mode, the ->tcpmem is simply >> not used. >> >> So {socket,tcpmem}_pressure are only used in default/legacy mode >> respectively. This patch fixes the pieces of code that make mixed >> use of both. > > Eric Dumazet is currently AFK, can we wait for him to return > (in about a week) before merging? Sure, thanks for providing this information! Best Regards, Abel