From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB27C433F5 for ; Mon, 15 Nov 2021 08:02:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AF0663218 for ; Mon, 15 Nov 2021 08:02:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AF0663218 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 32B526B0095; Mon, 15 Nov 2021 03:02:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3EB6B0096; Mon, 15 Nov 2021 03:02:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A4D46B0098; Mon, 15 Nov 2021 03:02:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 0A75F6B0095 for ; Mon, 15 Nov 2021 03:02:51 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CAD0D75820 for ; Mon, 15 Nov 2021 08:02:50 +0000 (UTC) X-FDA: 78810423300.12.9513677 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf17.hostedemail.com (Postfix) with ESMTP id 06B8CF0003A3 for ; Mon, 15 Nov 2021 08:02:49 +0000 (UTC) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Ht1mV4FtGz67mLl; Mon, 15 Nov 2021 15:59:06 +0800 (CST) Received: from fraeml714-chm.china.huawei.com (10.206.15.33) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 15 Nov 2021 09:02:47 +0100 Received: from fraeml714-chm.china.huawei.com ([10.206.15.33]) by fraeml714-chm.china.huawei.com ([10.206.15.33]) with mapi id 15.01.2308.020; Mon, 15 Nov 2021 09:02:47 +0100 From: Roberto Sassu To: Eric Biggers CC: "tytso@mit.edu" , "corbet@lwn.net" , "viro@zeniv.linux.org.uk" , "hughd@google.com" , "akpm@linux-foundation.org" , "linux-fscrypt@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC][PATCH 4/5] shmem: Avoid segfault in shmem_read_mapping_page_gfp() Thread-Topic: [RFC][PATCH 4/5] shmem: Avoid segfault in shmem_read_mapping_page_gfp() Thread-Index: AQHX18MROltj/rJe+kKE1cDtluXUoawALbMAgAQP9RA= Date: Mon, 15 Nov 2021 08:02:46 +0000 Message-ID: <987ab9f6dc844f8584a0224924e13bea@huawei.com> References: <20211112124411.1948809-1-roberto.sassu@huawei.com> <20211112124411.1948809-5-roberto.sassu@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.204.63.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of roberto.sassu@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=roberto.sassu@huawei.com; dmarc=pass (policy=none) header.from=huawei.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 06B8CF0003A3 X-Stat-Signature: oxbr3e1zk8s1ubbfnmtzpo8kcodxgcmw X-HE-Tag: 1636963369-441915 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: Eric Biggers [mailto:ebiggers@kernel.org] > Sent: Friday, November 12, 2021 7:56 PM > On Fri, Nov 12, 2021 at 01:44:10PM +0100, Roberto Sassu wrote: > > Check the hwpoison page flag only if the page is valid in > > shmem_read_mapping_page_gfp(). The PageHWPoison() macro tries to > access > > the page flags and cannot work on an error pointer. > > > > Signed-off-by: Roberto Sassu >=20 > This looks like a recent regression from the commit: >=20 > commit b9d02f1bdd98f38e6e5ecacc9786a8f58f3f8b2c > Author: Yang Shi > Date: Fri Nov 5 13:41:10 2021 -0700 >=20 > mm: shmem: don't truncate page if memory failure happens >=20 > Can you please send this fix out as a standalone patch, to the right peop= le and > including the appropriate "Fixes" tag? Hi Eric it looks there is another patch. Given that it was proposed before, I will drop mine. Thanks anyway. Roberto HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Zhong Ronghua