From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE36C54EE9 for ; Tue, 27 Sep 2022 11:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6A938E00CB; Tue, 27 Sep 2022 07:13:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B2A8E00C1; Tue, 27 Sep 2022 07:13:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE1848E00CB; Tue, 27 Sep 2022 07:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AC9FF8E00C1 for ; Tue, 27 Sep 2022 07:13:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7ACD51C64C1 for ; Tue, 27 Sep 2022 11:13:04 +0000 (UTC) X-FDA: 79957603488.28.B96CDF1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf01.hostedemail.com (Postfix) with ESMTP id 341EE40013 for ; Tue, 27 Sep 2022 11:13:01 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4McH1R6hHbzlX4k; Tue, 27 Sep 2022 19:08:43 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 19:12:59 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 19:12:58 +0800 Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" To: Christoph Hellwig References: <20220915035003.3347466-1-liushixin2@huawei.com> <20220915035003.3347466-3-liushixin2@huawei.com> <20220920121305.GA4237@lst.de> <2b469a5c-7960-ca6a-9360-c7d3aa26e8ae@huawei.com> <20220927072754.GB16710@lst.de> CC: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , , , Kefeng Wang From: Liu Shixin Message-ID: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> Date: Tue, 27 Sep 2022 19:12:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20220927072754.GB16710@lst.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664277184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ookq+7E67o9GPMFhWg2KgngLY5+U9GNcxpPTPwcVOa4=; b=zAixhTUF9SXDZmBSuczoh0IanHAmVIhpQRRURpE2gLYb1okHmMJxGqo+frpTegq06Ftice 558gV5Esnqa8rim3sr0GQmVB0MKUap9uiCDAAXps1V8pw/9LKu4Qh44lkK+xVRI/eyIOt6 AWaZdEFuggqg/k6bG+/THGuZTtLySPY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664277184; a=rsa-sha256; cv=none; b=ycZzg4RPowjyq8i0yCkmTLu8iKIvR5HX/JOuolZKEO0h2qBsIL0ofGpL7fzdsphLTerzso 36V/Nf9hnrYKSuFLFfGb7CgC/xFXWq/hUZYAXj0l4F20rYaSjZHZ2yXy7aXnnhzjCuFB1m FeRzCsBYARkCTNJfnjKIaRAv2OjL7eY= X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=liushixin2@huawei.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 341EE40013 X-Stat-Signature: 77qw5ko8y9rik6ce48mgusjm6ypmpthw X-HE-Tag: 1664277181-96774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/27 15:27, Christoph Hellwig wrote: > On Wed, Sep 21, 2022 at 09:42:41AM +0800, Liu Shixin wrote: >> This revert makes code complicated, but I think it's necessary. When >> enable zswap, I expect it to work for all swap devices as much as >> possible. > But why would expect something to work on a device that has been > swapped on before? That's not usually how things work. > > . If not do this, while some user enable swap device first and then enable zswap, zswap will not take effect. The user need to re-enable the swap device which is inconvenient. >