From: Liu Shixin <liushixin2@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Seth Jennings <sjenning@redhat.com>,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops"
Date: Tue, 27 Sep 2022 19:12:58 +0800 [thread overview]
Message-ID: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com> (raw)
In-Reply-To: <20220927072754.GB16710@lst.de>
On 2022/9/27 15:27, Christoph Hellwig wrote:
> On Wed, Sep 21, 2022 at 09:42:41AM +0800, Liu Shixin wrote:
>> This revert makes code complicated, but I think it's necessary. When
>> enable zswap, I expect it to work for all swap devices as much as
>> possible.
> But why would expect something to work on a device that has been
> swapped on before? That's not usually how things work.
>
> .
If not do this, while some user enable swap device first and then enable zswap,
zswap will not take effect. The user need to re-enable the swap device which is
inconvenient.
>
next prev parent reply other threads:[~2022-09-27 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 3:49 [PATCH v5 0/5] Delay the initializaton of zswap Liu Shixin
2022-09-15 3:49 ` [PATCH v5 1/5] Revert "mm: mark swap_lock and swap_active_head static" Liu Shixin
2022-09-15 3:50 ` [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register_ops" Liu Shixin
2022-09-20 12:13 ` Christoph Hellwig
2022-09-21 1:42 ` Liu Shixin
2022-09-27 7:27 ` Christoph Hellwig
2022-09-27 11:12 ` Liu Shixin [this message]
2022-09-27 12:31 ` Christoph Hellwig
2022-09-15 3:50 ` [PATCH v5 3/5] mm/zswap: replace zswap_init_{started/failed} with zswap_init_state Liu Shixin
2022-09-15 3:50 ` [PATCH v5 4/5] mm/zswap: delay the initializaton of zswap until the first enablement Liu Shixin
2022-09-15 3:50 ` [PATCH v5 5/5] mm/zswap: skip confusing print info Liu Shixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com \
--to=liushixin2@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathan@kernel.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox