From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05211C432BE for ; Thu, 2 Sep 2021 14:52:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE34A610A4 for ; Thu, 2 Sep 2021 14:52:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE34A610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 041546B006C; Thu, 2 Sep 2021 10:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0CB68D0002; Thu, 2 Sep 2021 10:52:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD39F8D0001; Thu, 2 Sep 2021 10:52:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CADD96B006C for ; Thu, 2 Sep 2021 10:52:18 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7734282E1AF5 for ; Thu, 2 Sep 2021 14:52:18 +0000 (UTC) X-FDA: 78542923956.39.F0C01D3 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf02.hostedemail.com (Postfix) with ESMTP id D068A7001A05 for ; Thu, 2 Sep 2021 14:52:17 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-35-e_78ceilNiO6G38l3rSPfg-1; Thu, 02 Sep 2021 15:52:13 +0100 X-MC-Unique: e_78ceilNiO6G38l3rSPfg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 2 Sep 2021 15:52:12 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.023; Thu, 2 Sep 2021 15:52:12 +0100 From: David Laight To: 'Michal Hocko' , Oleksandr Natalenko CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Vlastimil Babka , Matthew Wilcox , Greg Kroah-Hartman , Miaohe Lin , Mel Gorman , Stephen Rothwell Subject: RE: [RFC PATCH 1/1] mm: provide one common K(x) macro Thread-Topic: [RFC PATCH 1/1] mm: provide one common K(x) macro Thread-Index: AQHXnyIP1W4iwzBh3EWPGmS1HjslO6uQ1R3w Date: Thu, 2 Sep 2021 14:52:12 +0000 Message-ID: <986271f68d114a7daeacae620e3a6fdf@AcuMS.aculab.com> References: <20210901092149.994791-1-oleksandr@natalenko.name> <20210901092149.994791-2-oleksandr@natalenko.name> <5529272.KFOknHQvy8@natalenko.name> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=ACULAB.COM X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D068A7001A05 X-Stat-Signature: 168fb9rx1big8eajj1mppu4p8w35hea9 X-HE-Tag: 1630594337-752822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Michal Hocko > Sent: 01 September 2021 12:11 >=20 > On Wed 01-09-21 12:50:40, Oleksandr Natalenko wrote: > [...] > > ``` > > 31 files changed, 104 insertions(+), 90 deletions(-) > > ``` > > > > which is not that horrible. >=20 > Still a lot of churn to my taste for something that is likely a matter > of personal preferences and taste. Consider additional costs as well. > E.g. go over additional git blame steps to learn why the code has been > introduced, review bandwith etc... Not to mention the time taken by someone scan-reading the code who has to go and find the definition of K() just to see what it does. A more descriptive name (eg PAGES_TO_KB) might save that. but is it worth it? =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)