From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCE8C433F5
	for <linux-mm@archiver.kernel.org>; Thu, 21 Apr 2022 03:47:16 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id EA5586B0071; Wed, 20 Apr 2022 23:47:15 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id E53D76B0073; Wed, 20 Apr 2022 23:47:15 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id D43206B0074; Wed, 20 Apr 2022 23:47:15 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24])
	by kanga.kvack.org (Postfix) with ESMTP id C49A66B0071
	for <linux-mm@kvack.org>; Wed, 20 Apr 2022 23:47:15 -0400 (EDT)
Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay07.hostedemail.com (Postfix) with ESMTP id 9778920CEC
	for <linux-mm@kvack.org>; Thu, 21 Apr 2022 03:47:15 +0000 (UTC)
X-FDA: 79379500830.18.5B69F0F
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by imf03.hostedemail.com (Postfix) with ESMTP id 74F712000C
	for <linux-mm@kvack.org>; Thu, 21 Apr 2022 03:47:13 +0000 (UTC)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88C2B1477;
	Wed, 20 Apr 2022 20:47:14 -0700 (PDT)
Received: from [192.168.225.231] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CCDB3F73B;
	Wed, 20 Apr 2022 20:47:12 -0700 (PDT)
Message-ID: <9859ad1d-9520-f026-328a-e0c29fd3b960@arm.com>
Date: Thu, 21 Apr 2022 09:17:50 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] mm/page_table_check: Drop all redundant EXPORT_SYMBOL()
Content-Language: en-US
To: Pasha Tatashin <pasha.tatashin@soleen.com>,
 Matthew Wilcox <willy@infradead.org>
Cc: linux-mm <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
 LKML <linux-kernel@vger.kernel.org>
References: <20220420060221.1107736-1-anshuman.khandual@arm.com>
 <CA+CK2bARgsgBAgawfAD8-xzDN6+_sg4zrPQnoTFy4b=ZMx_u1g@mail.gmail.com>
 <YmDOKJCZteqrKr61@casper.infradead.org>
 <CA+CK2bCYp3+VLLFwrQpC8su1C-NvjdiKs39TFcFh=BTDgB92fQ@mail.gmail.com>
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <CA+CK2bCYp3+VLLFwrQpC8su1C-NvjdiKs39TFcFh=BTDgB92fQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Authentication-Results: imf03.hostedemail.com;
	dkim=none;
	spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com;
	dmarc=pass (policy=none) header.from=arm.com
X-Stat-Signature: eewiq99c3x8njwmyq9xj4i6k4bs9tspk
X-Rspamd-Queue-Id: 74F712000C
X-Rspamd-Server: rspam04
X-Rspam-User: 
X-HE-Tag: 1650512833-428994
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>



On 4/21/22 09:02, Pasha Tatashin wrote:
> On Wed, Apr 20, 2022 at 11:23 PM Matthew Wilcox <willy@infradead.org> wrote:
>>
>> On Wed, Apr 20, 2022 at 12:54:08PM -0400, Pasha Tatashin wrote:
>>> The rest of EXPORTs were added to be symmetric, and allow other
>>> drivers to use set_*p**()/clear_p** calls.
>>
>> EXPORT_SYMBOLs actually have a real cost.  We don't add them "for
>> symmetry".
> 
> Sure, the rest of exports can be removed, but:
> 
>> -EXPORT_SYMBOL(__page_table_check_pte_set);
> 
> must stay because of
> 
> ERROR: modpost: "__page_table_check_pte_set"
> [drivers/gpu/drm/i915/i915.ko] undefined!

Sure, will resend.