From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72E2C27C79 for ; Mon, 17 Jun 2024 18:12:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24B9E6B026B; Mon, 17 Jun 2024 14:12:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FB696B026C; Mon, 17 Jun 2024 14:12:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076326B026D; Mon, 17 Jun 2024 14:12:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB0116B026B for ; Mon, 17 Jun 2024 14:12:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 88516A1A0D for ; Mon, 17 Jun 2024 18:12:03 +0000 (UTC) X-FDA: 82241174526.11.6946D2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3EA4B16001D for ; Mon, 17 Jun 2024 18:12:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OhHDGpMI; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718647917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+rLi8MKV+U8G4ot33rd+CqDcsYiPGOTwuUMtg0xt/s=; b=7HI9vNh3xvWT4TKJPA5+EQUPv/+OFAwGuNLQm91Bb88XxoxddvC65BisARsHNnvhF4Hv2l sZ1rqL9pYQC5Xum+FFu1UEhoNZXEsEG8B80io28JlZpsM6p1jYAcWyX0NKY6woWodg+lQD hzNMxcWgDfZymbaRRz7OWKqDJzhgqhk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OhHDGpMI; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718647917; a=rsa-sha256; cv=none; b=L8E1Td8Vlhhi1TIbf4uBoKuaFOrKSwFTJ0Jq9tkh2EcVSVucIh3H1GlpiDyn3J6P5KMmIf g4V5IsiaFXE/NQwfIOik0xOmjiPcHCYI7jZu52hNArP2aY8yKnAmL9MekOBGALbzPzMNDj gcT6lb3td02UVqs7m3DvNF755IDs43s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718647919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=D+rLi8MKV+U8G4ot33rd+CqDcsYiPGOTwuUMtg0xt/s=; b=OhHDGpMIYD0LaFBEfnKrb1a3fEU0avHcUpIlS+UnA1XhpYTUV0MgI19EWJVuhQss+ioAvR DLWT3RgKDsBSF9ZgXOeaFbu3KHbcUD17Y6mlMRixcnFcYJ38d+seDmWIm/7Sep1QlRfI3R iVdLr4QLcb6VXxSm0Un5gLBay8U8dsM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-CNm3fNJbMruR_L591K4dSg-1; Mon, 17 Jun 2024 14:11:57 -0400 X-MC-Unique: CNm3fNJbMruR_L591K4dSg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42120e123beso40725585e9.0 for ; Mon, 17 Jun 2024 11:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718647917; x=1719252717; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=D+rLi8MKV+U8G4ot33rd+CqDcsYiPGOTwuUMtg0xt/s=; b=oYcdeWtY2253BOvOcf4gynHe4+Qd2gLUe3YACZj4QXQI5UPP1IYFrtgwRTn054O2AD EZHLuALoBnnlf+rlPxexsXzVOJRLuzrFNJKt9JPut9hdD+oMV8a9kvs8R3Em1zbuouUI Kzp4UE+ms1WLsMNn9cG9frdpJYuHeT3uB25dSLkhw5XlgrEA6P4/DFA+SphOcagPpFtL uPyzhVkzDNPVsQNVHGKcbm5wk0NyDDxotXMaUqpv4SrxdZr6/FsnBCuowVqAVdbC88Rv IUP4g05UtwGrYlsNWlm7zXS6Pxu3aM72T2hQGYDL0AtueRoCPa+pZQbTNkueaiicxly5 M48A== X-Forwarded-Encrypted: i=1; AJvYcCWy9FzjKA/mFotGqx6yHPN82YtI8+PsomNwPHm8q6xzS7WqCK5IgJY9oCM+StmQYPGjy8JOVUOzZZ3tuzRsx/+CpzA= X-Gm-Message-State: AOJu0YwPj3WOkLl+qqO8t4YCrg9YvLp5urXXF2xqr3dW9vU9Y9JTr1oc 1Ez29OLlQaNChXjXaCzet1x/1LCyPUr4LIqmzl3A2z7a68Xv4yZzjWkwRn0/ZC/YGPdmWzvcwvH TmN9GzGDaCUtEGqNjiZ2DBCKZcboZDM+tPUMkDLe7mV4mcwDk X-Received: by 2002:a05:600c:1895:b0:422:44f4:9800 with SMTP id 5b1f17b1804b1-423048211aemr104848735e9.15.1718647916879; Mon, 17 Jun 2024 11:11:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFT4usN/O/Tu2TN8Yu3N5hZIqYaQ+HzLQylreBS52iFrIRpNcpIhOCpd8HRXNNft0vVk4X8iw== X-Received: by 2002:a05:600c:1895:b0:422:44f4:9800 with SMTP id 5b1f17b1804b1-423048211aemr104848465e9.15.1718647916486; Mon, 17 Jun 2024 11:11:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:2200:95d8:cbf4:fffd:7f81? (p200300cbc740220095d8cbf4fffd7f81.dip0.t-ipconnect.de. [2003:cb:c740:2200:95d8:cbf4:fffd:7f81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6320c70sm165273455e9.30.2024.06.17.11.11.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 11:11:56 -0700 (PDT) Message-ID: <984d4e18-5e85-4751-b101-8bc7c559f440@redhat.com> Date: Mon, 17 Jun 2024 20:11:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal To: John Hubbard , Andrew Morton , Jeff Xu , Shuah Khan Cc: Andrei Vagin , Axel Rasmussen , Christian Brauner , Kees Cook , Kent Overstreet , "Liam R . Howlett" , Muhammad Usama Anjum , Peter Xu , Rich Felker , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML References: <20240614023009.221547-1-jhubbard@nvidia.com> <20240614023009.221547-2-jhubbard@nvidia.com> <1ea35568-bfe5-430e-9f4b-edef17f0b22b@redhat.com> <9f3d50b9-6acf-4bab-b6ff-cd524ad0a2c8@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9f3d50b9-6acf-4bab-b6ff-cd524ad0a2c8@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3EA4B16001D X-Stat-Signature: zgw9wnfugbmnqy3eqi4itogducgpk193 X-HE-Tag: 1718647920-826257 X-HE-Meta: U2FsdGVkX1/tk4gOdC4XAZuLIJvCVW7x0ADpjNDlpwijTRYcEyQEwNFYIvPQ1mPUlQPRhdd1hIDJgRhPErzjf4cGLOJ9sVSOobu4MTCxpRsDRWabkGfXkEOTEmNu00dVlll2TYyGLN1GkB4pG/Cq2HJLPo3Wz9v1Zk1jwHrgzXipAL3qHKVDrxjScxMEVSrKxqyJurgeqSnKjvOWY4v5OJ/aQoP8iNBblHqSGrZb7G6IhvebGXJJctYMpwLzdp6HeqQeS0gY0sEFqmkf7aSrl0nVSLwLjr+NpO+MqvF24EBeKnjgZ3sMzFvMlZeCCOhemsMZ80nBJVVWVtkQM+9dMpzRNo66/8/tznX8Jea7U+SL09WoVbY3jif/PPPItwUSp/f5DTXU3k+u3wEDgrRLhz35/fmPBF3t+b2k/9DS4qi+sRr8lA+sEK7QOibnmuuu7MTZFLeb66f2bgL59Ws0T1U33+kTTonh05/VV4YvE6zAa0mK1SmdqfMIuuXJYU0zEVceO8aWVqIkd2WEUz/k19Kq33NhXEfxy3Y8WEb3fH7E6TIPvKveKB/98AcNXkf1+/Ui43fhAJr7Kp2c4yD0fyjqnNVVd78v10fjVptlI5hFs91NkQ2lIlsgZmhTV+I0JSkGP7J2JxrwXP5wwK/kih13rQ6aR7gVW6rqcUT4NuTS07Lq7r6AlIIXjaxJwk3PBa4e+UHL3gq3gRz037fjzp9vJaW4gmz1Ou76Z8vMOpLmit6+DzhTo/vjpeNKSjePJtFp1Hz7zuD4ACI4rruZrqfsS1t3qYiJWB2QpeXpw7gnRBh8akOOvBYgfLiib/SVsPURx7VaPPaNvHkKhGHM3RopiI8eATqCBrvfoA54r02j0dENQ+v0K5KY0XXenUnrafx0m6TdlzZPxIMP0VghbP/CXyszLPysZGazs+uADHrbidG36YXjB8vWt7XiWGUaVSOYS/+DdqGtf8eXbkZ NXnwN38V xUWIiO7bYIHbG/b3vxkCIYjcOLIBVoK1AvakRHXsNk3rgklrc8Pr3yUkKlNu28Pnc1zMepUQwcON++3PTbXqo2VOAIKMwBaiQRfZeGIGyvp1hwF++njQQSQfIWdzbeQDkIa8cLuylZemaKXHwhwim5sRRk+oG7qtPN9ZLYxFc0w+1Y3ya5YSddWFKlDLICYnbsdycydAEBnxQtKVZzWgjzSDUNT2FL/BfE5NPJHT36uf6NbEffYemtGVxbJhDpRuZeP7mf6q+JLoYYFNVlrS1lNQM0t+wBMyYSXX/NBw/Nqo66EhCrREfT0B6vewkaxLDCDC55Wc2Lwu0V0m0Y01YLNwe0q1kTCIcjdrJUsj0Yp7zD45Kwb5Z0RIIZJLljzysvim8jt0NLxdcvtM5bQss/DYaPmUpkHI9kZ+tPkGwtkLWlMraON2idGUYtr9ten7Y0GK67xQRfDUUFuOQhBwI7Q0/CFuIuhK6fDun90UPa2/L6n+ActK6tfZZpBKTrRo+0BaZkW5N2SgGsXZDicP7jqyZGPMweHyD0lYGzjiZk4fSnOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.06.24 20:02, John Hubbard wrote: > On 6/14/24 5:41 AM, David Hildenbrand wrote: >> On 14.06.24 14:28, David Hildenbrand wrote: >>> On 14.06.24 04:30, John Hubbard wrote: >>>> The selftests/mm build isn't exactly "broken", according to the current >>>> documentation, which still claims that one must run "make headers", >>>> before building the kselftests. However, according to the new plan to >>>> get rid of that requirement [1], they are future-broken: attempting to >>>> build selftests/mm *without* first running "make headers" will fail due >>>> to not finding __NR_mseal. >>>> >>>> Therefore,  add ./usr/include/asm/unistd_[32|x32|64].h (created via >>>> "make headers") to tools/uapi/, and change the selftests/mm files that >>>> require __NR_mseal to include from the correct location. The way to do >>>> so is to include instead of just . >>>> >>>> [1] commit e076eaca5906 ("selftests: break the dependency upon local >>>> header files") >>>> >>>> Fixes: 4926c7a52de7 ("selftest mm/mseal memory sealing") >>>> Cc: Jeff Xu >>>> Cc: David Hildenbrand >>>> Signed-off-by: John Hubbard >>>> --- >>> >>> If it works, great >> >> ... thinking again, are some of these headers arch-specific (IOW, >> generating them per-arch would result in something slightly different)? > > Oh wow, yes they are. I'm guilty of x86-centric thinking (again). > > hmm, this is going to make it really a lot of trouble to do this > approach. But there's no point in turning back now, so I guess I'd > better fire up the cross-compilers and generate for all the arches. > Cross compilers might not be required. At least for me, at simple rm -rf usr/include export ARCH=s390 make headers make headers_install Installed the proper s390 headers, and "usr/include/asm" would contain the s390 specifics. Some scripting would be required to make this much easier to generate+wire up for all archs semi-automatically. >> >> In tools/include/uapi/asm-generic/unistd.h, we already do have >> __NR_mseal ... > > Yes, but it doesn't get used in selftests/mm, with the way headers are > set up right now. Right -- Cheers, David / dhildenb