linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Nico Pache <npache@redhat.com>,
	linux-mm@kvack.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org,
	mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
	david@redhat.com, baohua@kernel.org,
	baolin.wang@linux.alibaba.com, ryan.roberts@arm.com,
	willy@infradead.org, peterx@redhat.com, ziy@nvidia.com,
	wangkefeng.wang@huawei.com, usamaarif642@gmail.com,
	sunnanyong@huawei.com, vishal.moola@gmail.com,
	thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com,
	kirill.shutemov@linux.intel.com, aarcange@redhat.com,
	raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com,
	catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org,
	dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org,
	jglisse@google.com, surenb@google.com, zokeefe@google.com,
	hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com
Subject: Re: [PATCH v3 12/12] Documentation: mm: update the admin guide for mTHP collapse
Date: Mon, 14 Apr 2025 18:09:22 -0700	[thread overview]
Message-ID: <984797ec-9073-4a83-b3ee-7c5041f2d423@infradead.org> (raw)
In-Reply-To: <20250414220557.35388-13-npache@redhat.com>



On 4/14/25 3:05 PM, Nico Pache wrote:
> Now that we can collapse to mTHPs lets update the admin guide to
> reflect these changes and provide proper guidence on how to utilize it.
> 
> Signed-off-by: Nico Pache <npache@redhat.com>
> ---
>  Documentation/admin-guide/mm/transhuge.rst | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> index dff8d5985f0f..f0d4e78cedaa 100644
> --- a/Documentation/admin-guide/mm/transhuge.rst
> +++ b/Documentation/admin-guide/mm/transhuge.rst
> @@ -63,7 +63,7 @@ often.
>  THP can be enabled system wide or restricted to certain tasks or even
>  memory ranges inside task's address space. Unless THP is completely
>  disabled, there is ``khugepaged`` daemon that scans memory and
> -collapses sequences of basic pages into PMD-sized huge pages.
> +collapses sequences of basic pages into huge pages.
>  
>  The THP behaviour is controlled via :ref:`sysfs <thp_sysfs>`
>  interface and using madvise(2) and prctl(2) system calls.
> @@ -144,6 +144,13 @@ hugepage sizes have enabled="never". If enabling multiple hugepage
>  sizes, the kernel will select the most appropriate enabled size for a
>  given allocation.
>  
> +khugepaged uses max_ptes_none scaled to the order of the enabled mTHP size to
> +determine collapses. When using mTHPs its recommended to set max_ptes_none low.

                                         it's

> +Ideally less than HPAGE_PMD_NR / 2 (255 on 4k page size). This will prevent

   ^^^ not a sentence

> +undesired "creep" behavior that leads to continuously collapsing to a larger
> +mTHP size. max_ptes_shared and max_ptes_swap have no effect when collapsing to a
> +mTHP, and mTHP collapse will fail on shared or swapped out pages.
> +
>  It's also possible to limit defrag efforts in the VM to generate
>  anonymous hugepages in case they're not immediately free to madvise
>  regions or to never try to defrag memory and simply fallback to regular

-- 
~Randy



      reply	other threads:[~2025-04-15  1:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14 22:05 [PATCH v3 00/12] khugepaged: mTHP support Nico Pache
2025-04-14 22:05 ` [PATCH v3 01/12] introduce khugepaged_collapse_single_pmd to unify khugepaged and madvise_collapse Nico Pache
2025-04-14 22:05 ` [PATCH v3 02/12] khugepaged: rename hpage_collapse_* to khugepaged_* Nico Pache
2025-04-14 22:05 ` [PATCH v3 03/12] khugepaged: generalize hugepage_vma_revalidate for mTHP support Nico Pache
2025-04-14 22:05 ` [PATCH v3 04/12] khugepaged: generalize alloc_charge_folio() Nico Pache
2025-04-14 22:05 ` [PATCH v3 05/12] khugepaged: generalize __collapse_huge_page_* for mTHP support Nico Pache
2025-04-14 22:05 ` [PATCH v3 06/12] khugepaged: introduce khugepaged_scan_bitmap " Nico Pache
2025-04-14 23:06   ` Nico Pache
2025-04-14 23:40     ` Nico Pache
2025-04-14 23:18   ` [PATCH v4 " Nico Pache
2025-04-14 22:05 ` [PATCH v3 07/12] khugepaged: add " Nico Pache
2025-04-14 22:05 ` [PATCH v3 08/12] khugepaged: skip collapsing mTHP to smaller orders Nico Pache
2025-04-14 22:05 ` [PATCH v3 09/12] khugepaged: avoid unnecessary mTHP collapse attempts Nico Pache
2025-04-14 22:05 ` [PATCH v3 10/12] khugepaged: improve tracepoints for mTHP orders Nico Pache
2025-04-14 22:05 ` [PATCH v3 11/12] khugepaged: add per-order mTHP khugepaged stats Nico Pache
2025-04-14 22:05 ` [PATCH v3 12/12] Documentation: mm: update the admin guide for mTHP collapse Nico Pache
2025-04-15  1:09   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=984797ec-9073-4a83-b3ee-7c5041f2d423@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@gentwo.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=jglisse@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=peterx@redhat.com \
    --cc=raquini@redhat.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=ryan.roberts@arm.com \
    --cc=sunnanyong@huawei.com \
    --cc=surenb@google.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=usamaarif642@gmail.com \
    --cc=vishal.moola@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    --cc=yang@os.amperecomputing.com \
    --cc=ziy@nvidia.com \
    --cc=zokeefe@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox