From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF27CC54E67 for ; Wed, 20 Mar 2024 03:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E92B6B009E; Tue, 19 Mar 2024 23:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 499AA6B009F; Tue, 19 Mar 2024 23:46:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 361656B00A2; Tue, 19 Mar 2024 23:46:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 25FAF6B009E for ; Tue, 19 Mar 2024 23:46:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 83931A025D for ; Wed, 20 Mar 2024 03:46:38 +0000 (UTC) X-FDA: 81916030476.15.788A628 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf08.hostedemail.com (Postfix) with ESMTP id 1AF9A160009 for ; Wed, 20 Mar 2024 03:46:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of xiaojiangfeng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=xiaojiangfeng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710906396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vNlur6+7YtuDRTkFr4YKSfhCUhtmEAPdMdpe9kguans=; b=Djk20q3baFG2BDNatkYMLDVNwr5mmty/qHh7FgIrcWMUtrbvRDM8m8ARCK0dUq5Ta7G/69 LNjwGpnIHTMa3LYgAXAu2qaMn2xHwQfEW4n+1ACgEfC4ZFCYN7jWt71VyUwkn4BSnxKgQ+ 8ObVffm7A4MuLkxq5lxkJpyL1eid4Do= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf08.hostedemail.com: domain of xiaojiangfeng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=xiaojiangfeng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710906396; a=rsa-sha256; cv=none; b=UG9eHFuvrRxQGKmW7mYuC6JfsT6C/3Aily19TfjazjcrDh8rT+6T1Jy8nu23CxBPBlKjcD 05aBis4miO+7WMD5MfuGZdgbxRyvlNIXflnkGgi5KcC9AHR0/FWN9QwnM/cuEtReJpcsOl Bv1RJOSCdfVWgriHs4/betTz45CgwqY= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4TzvdY0Kfqz1HBvb; Wed, 20 Mar 2024 11:46:09 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 0341F1A0172; Wed, 20 Mar 2024 11:46:32 +0800 (CST) Received: from [10.67.111.82] (10.67.111.82) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 11:46:31 +0800 Subject: Re: [PATCH] ARM: unwind: improve unwinders for noreturn case To: Matthew Wilcox References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> <1710901169-22763-1-git-send-email-xiaojiangfeng@huawei.com> <202403191945.661DBCE8@keescook> CC: Kees Cook , , , , , , , , , , , , , , , , , , , , , , , From: Jiangfeng Xiao Message-ID: <98468785-ed75-f812-7263-1adf677f00d2@huawei.com> Date: Wed, 20 Mar 2024 11:46:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.82] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500010.china.huawei.com (7.192.105.118) X-Rspamd-Queue-Id: 1AF9A160009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: i8ukop1yofsfy4o1zikjwsa1t8m8fnxh X-HE-Tag: 1710906395-577296 X-HE-Meta: U2FsdGVkX18GApSMev/ldPaOJvK5MopZ5Fqp62IQSQdi6lDnCWvEf8OVhI0Q7DD9VCdLcNMY3ibA7YqDXHPqMAf7YPbe/jmtraZraFg+9iM5fJ0ka6vJMwOBoLoE255rt//qazURwaBULye2Vl51oFI/ct4URt2i0yf2LRshV++FQu/9wBS+TIyAPL1Tz23P5xGSWnDSyzrlMCZc0a3PKhFEmM3DP+VJvh8vUkW3KLF777v6aD59AhqHheIiTQHUZ1MnjGbTfrdPo64lJHC/Nr5m8KwK25F9bF1JYFMEZVpB4IPMfxlnxEjgZFtVsKzyX2g4+oi6ajvTZKP1A8wEzpc1AMENtc4pBFkBbZf+vEuV/ngIoRwkz9KoInABpB1g8faB2yFLXYNujv35k/vjyipmXrCgb9ThzqDTW0YlxZPVcIQWFp1MiC2WA25zdDTsLhcGx9R2I59iAWE8Qax5jpHTEV6ae4kJrP+VbeE6Tjbv9eVgj6piVIDJaGIiCziOA7sUvl9TZ+r4e+C1vmVtSo0x5m4Zj5MO+TZZ4AaetQkOoSvf46/pS9hnc2WMw/QUuM2uhHFEOHtieXVuKfxBZOsmaaygWQcuTipLQznhm5Th4vNQ2sie4DdRj6DaAuwPoIH/F59iBTBRP4DmgFtEdmBrGe6I5YVyVDAYShJNmP3FXzBujhzZLCTeQu2fytlYqUepns00Z9U0chxWT+IlhBx/zW1UXRvEszJTvlsOGwhvkDeor7tbxtL+Z7V/iWPw25wS0dsZD1uce/nO589QRP1e0LnG82MRRxz2Xw1XfWz04wvc7Puho4ge9SUqBAFa4Jkn7NuXmBmHP2l17Fc5M2t53Wl5SJx6oBMkf9cDP0dxF8Bm5i12Idup57Icg7xILhnWtbPvfUFAyQpf2lJKXBxut2VjTYLaVYluZFrURpTT4IgkQOR7Dw49IFYeALEFpDIzZYMN119AfgBlfOW OtNOcR40 ozdHC8pHX8js4/2AByzT/d4pcRTe62w7bLGpIMAngUaslgVQoszrvc8qUWPGmgZaHC6vFYPrzYAuv+nCCb7bE/1l15Q1PJVF6yvTBEN/RSdoIkyrd0G0pDUpUFjB9x1luhaikxc146exdooczdHhVAKJAiuoL3ia62dwoGrOjkdpIb8HCyOedVVgP+u45japrX68b6MwacIJAHeaw9tEahvWmBg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/20 11:34, Matthew Wilcox wrote: > On Wed, Mar 20, 2024 at 11:30:13AM +0800, Jiangfeng Xiao wrote: >> The checkpatch.pl script reports the "WARNING: printk() should >> include KERN_ facility level" warning. >> >> That's why I changed printk to pr_warn. >> I should change printk to printk(KERN_DEFAULT). > > No, you should ignore checkpatch. For bonus points, figure out why you > should ignore it specifically in this case. > . > Thank you. I think I understand. The checkpatch.pl file is a false report because the 'loglvl' already exists. I'd better keep printk(" %s...", loglvl, ...) still.