From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8653C3ABA9 for ; Fri, 2 May 2025 06:46:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3EC6B008A; Fri, 2 May 2025 02:46:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 906076B008C; Fri, 2 May 2025 02:46:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F8C56B0092; Fri, 2 May 2025 02:46:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5C5AA6B008A for ; Fri, 2 May 2025 02:46:28 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8C182C0747 for ; Fri, 2 May 2025 06:46:28 +0000 (UTC) X-FDA: 83397034056.21.B2D6E68 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id 18DD7100007 for ; Fri, 2 May 2025 06:46:25 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746168386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWVcjfgtS5bOGQFCw0MEzqxJ5ILP+XGELbf6I+z4ZAA=; b=4yUNy0OYPWiw3OTLgeZw/2zaMKRrWv0EoltcyV31rvWDW4xfvuyra/sM8eVTPQr9Zqch6T 45QqoIhNJKsm2RQGnJ7F/0GKF1BFJmjPJzRlziV/qgwkZ1UI6ntgs2QKdVuC8pQNExcxIv wFAHbGYSS2+Fw3fw+NTDYAZRH+OIJ88= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746168386; a=rsa-sha256; cv=none; b=K9tK69xm1khZB/gceacAQXE5YBiglpmU9TSvAcY1qY9mdgGy9HghBed/IxOz1+iYu/+BDU QVIYX167YL9Ts1wh2z8Wj+VrV/NaAc0ttLJhNofT57txqbXwVw7Jvdj0jlZ/fzC6NXYhkr DTHDp5rMiLhGb/nPPqLgKmhsuruI9jU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of honggyu.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=honggyu.kim@sk.com X-AuditID: a67dfc5b-669ff7000002311f-81-68146a3d5fcd Message-ID: <9837bbe0-d494-43bb-8e92-8cbf47a32b68@sk.com> Date: Fri, 2 May 2025 15:46:21 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: kernel_team@skhynix.com, Andrew Morton , Dan Williams , Joshua Hahn , Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH next] mm/mempolicy: Fix error code in sysfs_wi_node_add() To: Dan Carpenter , Rakie Kim References: Content-Language: ko From: Honggyu Kim In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsXC9ZZnoa5tlkiGwYZ+a4s569ewWXyY18pu MX3qBUaLn3ePs1sc3zqP3WLrLWmLy7vmsFncW/Of1YHDY+esu+we3W2X2T0W73nJ5LHp0yR2 jzvX9rB5nJjxm8Xj8ya5APYoLpuU1JzMstQifbsErox3r30LrvFUbFvVydzA+J+zi5GTQ0LA ROL+0b2MMPaPy6vYQGxeAUuJPZvvMYHYLAIqEj2rl7BDxAUlTs58wgJiiwrIS9y/NQMozsXB LDCFSWJT429mkISwgK/E4v/fWEFsEQEvidmvl4ItEBLQl3i1bCKYzSwgIjG7sw2snk1ATeLK y0lgyzgFDCTetuxlhqgxk+ja2gVVLy+x/e0cZpBlEgK32SQe/5jDCnG1pMTBFTdYJjAKzkJy 4CwkO2YhmTULyawFjCyrGIUy88pyEzNzTPQyKvMyK/SS83M3MQJjZVntn+gdjJ8uBB9iFOBg VOLhDSgQzhBiTSwrrsw9xCjBwawkwhtjABTiTUmsrEotyo8vKs1JLT7EKM3BoiTOa/StPEVI ID2xJDU7NbUgtQgmy8TBKdXAGHr/zxuz5utfvvop73I9tVFv2rtbpSWyBmdSlGa7lq2ODs3y XCdTJduQOVmqcsqbGQk7df64LKt3srt3mF92zfbd3pfK+rzZDt9eGKq78seuGXJlU62d/HKj Wx1O3vep50sX+JsiViH7t4jLRL4u1HxHzOPDHFdNKjfP3L/88dws7ZboK75/lFiKMxINtZiL ihMBdBeWM5ECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsXCNUNLT9c2SyTDYOdcfYs569ewWXyY18pu MX3qBUaLn3ePs1sc3zqP3WLrLWmLw3NPslpc3jWHzeLemv+sFoeuPWd14PLYOesuu0d322V2 j8V7XjJ5bPo0id3jzrU9bB4nZvxm8fh228Nj8YsPTB6fN8kFcEZx2aSk5mSWpRbp2yVwZbx7 7Vtwjadi26pO5gbG/5xdjJwcEgImEj8ur2IDsXkFLCX2bL7HBGKzCKhI9Kxewg4RF5Q4OfMJ C4gtKiAvcf/WDKA4FwezwBQmiU2Nv5lBEsICvhKL/39jBbFFBLwkZr9eyghiCwnoS7xaNhHM ZhYQkZjd2QZWzyagJnHl5SSwZZwCBhJvW/YyQ9SYSXRt7YKql5fY/nYO8wRGvllI7piFZNQs JC2zkLQsYGRZxSiSmVeWm5iZY6pXnJ1RmZdZoZecn7uJERgLy2r/TNzB+OWy+yFGAQ5GJR7e gALhDCHWxLLiytxDjBIczEoivDEGQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8XuGpCUIC6Ykl qdmpqQWpRTBZJg5OqQbGONVJfNE1s/oEMz2mTyr4/P/67xv2R/huHfv8qYFx88ba6Ekyu6fn zJnq+zPwDu8FBTs52yLp1P6u5sjV/nfSguq3L1i/48unj6HxEuw2uScn9GfeETi/hGnNQw82 deM0hRnbWv5dc2PPc7s4OVpu4/vGadUa/5LTipJl/c/2di3wW7i1oadRiaU4I9FQi7moOBEA BCkJ+YECAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 18DD7100007 X-Rspam-User: X-Stat-Signature: nk9okn7b33ab9i8dof6497xgtcozg659 X-HE-Tag: 1746168385-963350 X-HE-Meta: U2FsdGVkX19Fn/Ppd1yKh3g/DddUVFGKmCg/GTyCAxZqg0K8iFN3MHtjF/FBZ9zdpXVuIeph+Zcp6ixDIKaq4+1d8cNjlRglbgQJKqNkjCuzJEtdx922qsOt1rrfJkT5bSJIiCPdKe2sK7NBE8Tc0ywMnzmMS0jOqWTcoySHPIILpyP3qxDyPme22For0AMOK2GEI4/51r9nxq7KSssawfxuifY2cqlN6Do78ke9Ptu3gIEFNVFUFwSewzqR5hMqIZzpohC9rINk72ro4E6UlNrItMooTwH7pUP9I5h8bz8oJRB6+98pDp9APIkLQbuwrfRJzEHSofbk8cQEHSgFlWDheSxoQBzDDdx2RCJQxIxF9QYDmgjJqlbK9H++10lP3JCHNaNcGBhjb/9sQd/S55/a5qx6wt4kXVV6dyjxShV0S7+EKdRk5Gq+kGu1G10i3TyYPtAyfpJDVMjAwrlD0h6O48NR8LfL5Mp3FwN93nD//A2DgWronMq9GjKoZhtjpuzstoIg5G4fKp/13J8B7nQcgjGGbF1876bwyCFeTuhTOwXpJSVBnBy7LybR4krUveaaMFTSV8s1o9JWWR9SqFcv+KJ756xX8f51uK+nPm0FY55CT0P0VzkzvsG8blSLSLljBlhSjEEM2Fz/8meptDfmsl5SNYXwJtee8aqz8K/q8rgBvVZjusaoZnpgDGRrmctcHGWL46KaTst/1dBUqYy3Js3Ccw6ETP2AVluA/8QeZxuK3Objyde4/RNb5X24KUR9l10lpqlqklhdrmMrIiw/fEL4eOyQ9wJFqCAX2NUoWAhWvLK+UfmVruNnEUQ4kaEGoq3QlcIEcDRJq0bLYLmm/qK4po+YgXmopxo2BY9w2J4USciS0H+/VNmLCdrKT1PlLXSNj+LaZqMmx3pEk/AdnCoB03AuJeicRKi8aayt/Gbw2/ejP3nc8LrOrzho4QgkvJ1aYMEVl697Fg7 CPQI7Qax onmSbf2pyv/WEqh8uLj5oRxjhyADFndr6mQf6yZSb/Ag9e2qdc68eRkzsMUMxTqViwh5Edcoth+G9s6Wwu351t1bqAYJTyJYlAJSpdbVQYictYewLsGDo76LDf4TjRaVuGm4KnoCLVwAQfvsRKmt1c6Buc9G3AfRQfs+uRZys/mw5xfNZbwVP4UNIrQ6QUy/EdyA/hSpy7e3UFGL63sF4hInov5UMMJhn3mig1XUnUOf7VqSYs2mb/8WQjlSVqRRkbwfeSryRUtrgBsXPrtBwYvxPTGprCFwkIlwEDU+dS6urtEs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Dan, On 4/23/2025 5:24 PM, Dan Carpenter wrote: > Return -EEXIST if the node already exists. Don't return success. > > Fixes: 1bf270ac1b0a ("mm/mempolicy: support memory hotplug in weighted interleave") > Signed-off-by: Dan Carpenter > --- > Potentially returning success was intentional? This is from static > analysis and I can't be totally sure. > > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index f43951668c41..0538a994440a 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3539,7 +3539,7 @@ static const struct kobj_type wi_ktype = { > > static int sysfs_wi_node_add(int nid) > { > - int ret = 0; > + int ret; > char *name; > struct iw_node_attr *new_attr; > > @@ -3569,6 +3569,7 @@ static int sysfs_wi_node_add(int nid) > if (wi_group->nattrs[nid]) { > mutex_unlock(&wi_group->kobj_lock); > pr_info("node%d already exists\n", nid); > + ret = -EEXIST; Returning -EEXIST here looks good to me, but could you remove the above pr_info as well? I mean the following change is needed. - pr_info("node%d already exists\n", nid) + ret = -EEXIST; We don't need the above pr_info here because we delegate a warning message to its caller wi_node_notifier(). This can close another warning report below. https://lore.kernel.org/all/202505020458.yLHRAaW9-lkp@intel.com If you apply my suggestion then please add Reviewed-by: Honggyu Kim Thanks, Honggyu > goto out; > } >