From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0404ECCF9EB for ; Wed, 29 Oct 2025 20:06:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45B328E00E9; Wed, 29 Oct 2025 16:06:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 432C78E00B2; Wed, 29 Oct 2025 16:06:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3212A8E00E9; Wed, 29 Oct 2025 16:06:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E36F8E00B2 for ; Wed, 29 Oct 2025 16:06:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CEBE5BC1C3 for ; Wed, 29 Oct 2025 20:06:14 +0000 (UTC) X-FDA: 84052233468.22.713E7B2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 380FF4000C for ; Wed, 29 Oct 2025 20:06:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XesAeEvE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ApPLo/gT"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XesAeEvE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ApPLo/gT"; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1761768372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1K2si2V9W9zo0go0yDRYK2pKFo0UoWxQ6EW/yImCMlg=; b=24483+7s5jEItWWuNvV5BiFQKDMIBae+3sYRpLm0bdHs8M3CkZ+y0zB/crDRqIOgQ+yYky 8AaEtOhtEAsxbKFbKaHNL5Qs8IcEGOYZDzt0fFxM0B50uAQTYjTlV4yK0WhlMAQTs96O0g b/GAm8OeOV4Jwh3zFXeHA1liXv0TclA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XesAeEvE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ApPLo/gT"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XesAeEvE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="ApPLo/gT"; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1761768372; a=rsa-sha256; cv=none; b=QoxdVT2jLZ9YlINJnOXvC2AVxMmVk9tWkPYo3j483PgTWLrtpf1ECrE6FXXgtaSo241hqJ Ez60Tc5LUhrG4RZy2w2aF1hWCCzRrTOBlqP4ciB0ykc2wyQ1ZpuyfI3jVzLoEjwzHzLNBe J6zzcZg6/WgJEhRDFACd71XIEG/QmPE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DF833462A; Wed, 29 Oct 2025 20:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1761768370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1K2si2V9W9zo0go0yDRYK2pKFo0UoWxQ6EW/yImCMlg=; b=XesAeEvEBcp2wZCBnHcDJOOrn8ta5ZEKToqcvnOK4EbRi/n1GznqYIxQpgM+AGijZDoK4l nDtZEffLTm0L7cTZEpz/x7JgmX2PudsUZodblxeHUsbW4CYWVoiMQa1yRYA++yR1wJyNSK 95LInYV7bNTlEtEqFnrAB0Not6zXUj8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1761768370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1K2si2V9W9zo0go0yDRYK2pKFo0UoWxQ6EW/yImCMlg=; b=ApPLo/gTIjc2TE/w6BQHdAVKefWoMh2AwUICgu2zdSw/lJ+74fyyGNsNe0ZTwALQdKRacg IKg35NXPDwRdhkAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1761768370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1K2si2V9W9zo0go0yDRYK2pKFo0UoWxQ6EW/yImCMlg=; b=XesAeEvEBcp2wZCBnHcDJOOrn8ta5ZEKToqcvnOK4EbRi/n1GznqYIxQpgM+AGijZDoK4l nDtZEffLTm0L7cTZEpz/x7JgmX2PudsUZodblxeHUsbW4CYWVoiMQa1yRYA++yR1wJyNSK 95LInYV7bNTlEtEqFnrAB0Not6zXUj8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1761768370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1K2si2V9W9zo0go0yDRYK2pKFo0UoWxQ6EW/yImCMlg=; b=ApPLo/gTIjc2TE/w6BQHdAVKefWoMh2AwUICgu2zdSw/lJ+74fyyGNsNe0ZTwALQdKRacg IKg35NXPDwRdhkAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D8A0D1349D; Wed, 29 Oct 2025 20:06:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XH2dM7FzAmnXfAAAD6G6ig (envelope-from ); Wed, 29 Oct 2025 20:06:09 +0000 Message-ID: <982967fc-5636-46dc-83a1-ed3f4d98c8ae@suse.cz> Date: Wed, 29 Oct 2025 21:06:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 08/19] slab: handle kmalloc sheaves bootstrap Content-Language: en-US To: Harry Yoo Cc: Andrew Morton , Christoph Lameter , David Rientjes , Roman Gushchin , Uladzislau Rezki , "Liam R. Howlett" , Suren Baghdasaryan , Sebastian Andrzej Siewior , Alexei Starovoitov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, bpf@vger.kernel.org, kasan-dev@googlegroups.com References: <20251023-sheaves-for-all-v1-0-6ffa2c9941c0@suse.cz> <20251023-sheaves-for-all-v1-8-6ffa2c9941c0@suse.cz> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: t9efsjzgku1tp8hjiobrwiejbtawpj7g X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 380FF4000C X-HE-Tag: 1761768371-53929 X-HE-Meta: U2FsdGVkX19Mgh+GtCSdobjF0PMRHEjd4iV86vXMoBs6N6jywR6yjIw0vVI8ouY4L4xcdLZyduSFp3LdFXVehHixpqeMmNPLZevNVGEkeTFEuudIFjzCtdAT9WBl7en0Z+si646PHbq8ubFOJLj32Vq9z6A2Ilvn4LJNLSRLrFqqxnwSshsDHLGcVXYFaq+I/WzYMAFQ0PryeINaikajyo9zrSwPz2BDzT0QeoabaXnHrryOmlIx4Eou7s2xAzBvihC6C8Q9tu7Mu7GhJuOlSHC9Pv379Rnc2iDjII2WgErdTg0+Xg8wZgPod6TiAShhHt6Lz76Sd3jixl6k9F/LTGHQGhXsp/CVIuzfaRuDaxx4XeqlKoXYQlCQXHW1MaszVIHtEdY53aUeIqi0fzb7Ms8s/pioxPeINEhHQd3ljOtBl1WnrFcLrW//f4QvqTQo4yNAZHKOJkDSnOgRVfyveaxpqcPsby93Vwok4HEjAd5rrEWVxd3mr0P6Hka4sjRW+2s2+2n+Ttr749tLg9wN0PyrJl9dX7LMPkVbud6oi77Rl119NXenM/x/Nm9Dc08vJLIvCfvq5GnLsNtWtMIxqUY45XnYxY/zLvugxsreGsm1gbjHu8iJT9kbMz126AdHlyusyFRx0gnqwv9XVaugPyzsySSihZv5f6pvVsowCyljJdgaj35jed93NvRZ+v6Qn46iaToGK4Ofm/nvDZZzcGbwAvJiNRutXc6HavCnjJrVFvDLEJxmHxd3wM3Gai/R1aJ5IBun5hGjkWjA+t9NAHpfkrX8nfEw7NsUQuXWSxsuOzIFaBotMig8Ypt8wv/+ExfiM3kOZQZsPTsxq230/SeuLOCGSBFUfA9+PzWEH05PQpOJk8bFniV0FzvBfNKHq+jw+GwP8olFaOz/1vbUx4KsylZLPLI/37Ua/s/ah5V/l2Nczx3WRu5Nh7b3yqUOhawEt4Z9v8hojdjG7YS 2ZyixQNC XdphCeFbUhuE/SiUOO1A5XBj3z6aSlbIjRxetbsfXIeh19iHH+D0rAcgCzRIrai5IJ4dlAEQrPA1hGcw8r4iR+J1nW9CRnl97KNWqV5MPu/04K/8HXAqUwsudvCDwbBa3+CyRjJ8SOp2UZF/VktvqfmRuFH919Rib5nz99hnD7iKT6FJiJsnSRqtfwYopxOsPSYuaHAEETOX58DK/9JKZN03SYcqOjwN2IMk9I6UPwaKqqMUTcG6O5yPz1tImgFWP3aB0Bro/eaIawqfVYqJda5SrNj/jSN74OGdQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/25 07:12, Harry Yoo wrote: >> @@ -8549,6 +8559,74 @@ static struct kmem_cache * __init bootstrap(struct kmem_cache *static_cache) >> return s; >> } >> >> +/* >> + * Finish the sheaves initialization done normally by init_percpu_sheaves() and >> + * init_kmem_cache_nodes(). For normal kmalloc caches we have to bootstrap it >> + * since sheaves and barns are allocated by kmalloc. >> + */ >> +static void __init bootstrap_cache_sheaves(struct kmem_cache *s) >> +{ >> + struct kmem_cache_args empty_args = {}; >> + unsigned int capacity; >> + bool failed = false; >> + int node, cpu; >> + >> + capacity = calculate_sheaf_capacity(s, &empty_args); >> + >> + /* capacity can be 0 due to debugging or SLUB_TINY */ >> + if (!capacity) >> + return; > > I think pcs->main should still be !NULL in this case? It will remain to be set to bootstrap_sheaf, and with s->sheaf_capacity things will continue to work.