From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAEBC4345F for ; Wed, 17 Apr 2024 10:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0306C6B0085; Wed, 17 Apr 2024 06:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F23706B0088; Wed, 17 Apr 2024 06:36:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEAF16B0089; Wed, 17 Apr 2024 06:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C0AC36B0085 for ; Wed, 17 Apr 2024 06:36:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8991C120DB7 for ; Wed, 17 Apr 2024 10:36:34 +0000 (UTC) X-FDA: 82018669908.01.E28A6BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id C15F7120009 for ; Wed, 17 Apr 2024 10:36:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nc4fhLUh; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713350192; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oIJdAoOJD1/uhXCiQOPpdfvotOmhyFiedfiW/yeHsWQ=; b=W/JxkD+4/aX7L8TxAgKYbmXlM7LUGlDYO8okvn8qQRSUk85+aKHJipmeinkeeQqBXZf7ZY e14ku6L3tH/XSQLzHU/NqC7iMCGboVrI/qtW8ydGtDp40n1Mqd1cQjP5NzOhsD2Pzxkznl wfy9qUYxpFap9BR8uhdskQM2bS3wZig= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713350192; a=rsa-sha256; cv=none; b=gdVUMaK3OcAq3jvw+UByE6mFy/Cmr59dR5KjS/s6uf70t8s+N7gxHT4KEUgJaM/blDJs+U 5VxkdS1nYWrbRwQtExj5eK2tvgS4BV3m3w2rSPGycmHLGBr0GNOcpLtdhzP5um/7ri6EqQ rhnDSuDM8jjAL4XmQkPNkiXb55O4mXg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nc4fhLUh; spf=pass (imf29.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713350192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oIJdAoOJD1/uhXCiQOPpdfvotOmhyFiedfiW/yeHsWQ=; b=Nc4fhLUhR3XXrOI0Cj3Ol3plK+A5leIkFFzoBN4yAAo7NLXYn+phCcHhKXXlAXk3iGHPNU erbCiVfxur+rPwWEXnDyeB9tpyAsO+/C2Q/BmxLU4PMOblGPBDav1A9bMA6HKlbB+RtyQ9 tpz7SnRUFnuGRAeHmJ6A3JuJdModH+w= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-tzkEwGWLMWac2hfcSazMmA-1; Wed, 17 Apr 2024 06:36:24 -0400 X-MC-Unique: tzkEwGWLMWac2hfcSazMmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 65AB738041CC; Wed, 17 Apr 2024 10:36:23 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.200]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FDF82026962; Wed, 17 Apr 2024 10:36:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87d451ff8cd030a380b522b4dfc56ca42c9de444.camel@kernel.org> References: <87d451ff8cd030a380b522b4dfc56ca42c9de444.camel@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-25-dhowells@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, Christian Brauner , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 24/26] netfs: Remove the old writeback code MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <98240.1713350175.1@warthog.procyon.org.uk> Date: Wed, 17 Apr 2024 11:36:15 +0100 Message-ID: <98241.1713350175@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Stat-Signature: 41z4hgh5d5c87xrrciu33s357gsbay4i X-Rspamd-Queue-Id: C15F7120009 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713350192-953406 X-HE-Meta: U2FsdGVkX18VBOxpPso39LiNLJehOPOaA+Rf/LYZLx8P0podMe54VvVAh6RuLyNGA+wtUOM88nuThge4R5CoIjh686sbVNeS1DyAxPQc9lGJ9/TCHX8/cKc0zofWoPuDtWrGkU9gc8WlRKPoWBxxUziDQn5b7PIghLqfG6hsp9KTH0sJQ3GS//suyqNitjYeOivxrlp4vOORKdc6zhCRRdT8IjkCA1Q5YttGS97HLP/1ECtjNFx+7f+n2QnwaxcYoA6u+6ev7Up8wSxOcJAHIioGNeEJCEXQJHoFqk2g0GywliygXBz0CzxCWXnq/rebl2RvGs9L8yD3ITcvL83rOhpjEwzHjfds3/p3yoP3a2KPPIIsMb9akVZSLBhEcbnWrx0jYRJjvFpfVYTquLwXBMcOTskXkIFJkdzWPrhPmK1olw3mUzJEqxj47rTmBEgCN70Th4cBmlwOKsh7nJGVTLT6XMH5KWNWZUBrtOe+QldzOSwUAnqXUPf/Q/NehyEdbIO9pv9ft9fjbLVN5248arC+Xnmee1sRNKGCdCKlaBG/lM5UXArZ0TFEpBXRSH8ng7yR83wZ7xuaYjnNWOu174N4dyaCW9ssDNMf8D7nQ0jeB9xur/MfrqR//1a24OEOH6CJJvY6K8JiQXBxYkGyt+mgdq9xf0eihGVrR5sgKLUqbKFGhO6wZTkWUBmqnpE0qzurtoP6yk3tVqhzBJYZVklWqklSjs4mwk40MjX+gRLopXiYJmqvCJWyZSR091D+yxM2qGxA7OzZkTMRteN1GdW2OrtyFGX8TGzDv8bbs5JQwEPDkJnlWlOSbGJc1Yhw5ZtSJYyDySe75FYFwarcgHt+Da4oMpkbi7bYK9B9R2tu3dsXN75V75SiQ/Lh70+BBkSaG/1lmoL+JNHb34o1Z+nNxpkRI3DTll0Lbif8f1IJ/y/BHiXMhk0xCa7ztC+3i+xXS2ShfZfmI4zO6yI 1UYzP5pM CnU6Pj3qaU+UHk79uVFqCT+ScXGiJALsevTl/yZeyV+st/627A/MMKIuuOh+70eC2jIyq4PQGhE089o+jssj8zyh6ZmK8DC9Z4GLA93ooZP2U4aLFfXCQ79D0hJ6s+3tzObeTwIWvph9ZeZIMDWU2PmbUBT+9GSwliySrp0LisnbuN8oi0IcxX159b+tdM2lLDGJ0bcwvu984d6JJLbupLE6uvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jeff Layton wrote: > #23 and #24 should probably be merged. I don't see any reason to do the > two-step of ifdef'ing out the code and then removing it. Just go for it > at this point in the series. I would prefer to keep the ~500 line patch that's rearranging the plumbing separate from the ~1200 line patch that just deletes a load of lines to make the cutover patch easier to review. I guess that comes down to a matter of preference. David