From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5C4C636D3 for ; Mon, 6 Feb 2023 22:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 471E56B0073; Mon, 6 Feb 2023 17:16:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 422106B0074; Mon, 6 Feb 2023 17:16:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EB046B0075; Mon, 6 Feb 2023 17:16:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E2246B0073 for ; Mon, 6 Feb 2023 17:16:40 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 071881603FD for ; Mon, 6 Feb 2023 22:16:40 +0000 (UTC) X-FDA: 80438277360.27.2B4A83F Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf27.hostedemail.com (Postfix) with ESMTP id E2B554000B for ; Mon, 6 Feb 2023 22:16:37 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DkxkuZ0s; spf=pass (imf27.hostedemail.com: domain of dave.jiang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675721798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Um8bC8VSOEfVNUwYcK9IC5VV2cW1YZgnyF14NQ4iEzA=; b=qS35Iipj3AHkksa/2FNPtNDEu9D2bpjwViI+Jr4/HzO2IJgzG8wR6Yk12ajpgZEJQ+GutJ AhCwjbsivTBjnoszzVJcc1nNwn+ryVvHy8u8E8KJfN/oNdWs6W3G336j5mypJxrpexvdJ+ ZDxYEwMQ2woZV/7L/ptQsjtRJaqPlzI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DkxkuZ0s; spf=pass (imf27.hostedemail.com: domain of dave.jiang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675721798; a=rsa-sha256; cv=none; b=3+5WqQCBjlQN4MoMAp2tR4SCJqAi9I+wNccUXzfWN9OeBNDZXhMqI2VNdz9i0NoUVJXBYy S0nsD4zkYAt8e7ge02V6+XliIggLkzIlH4hLpZY9s7WsTml2ETjNs68aZtd0KrGNLrOcBD RIrFBG+7CPKgMjfsuFfjInBQ5UK8/X8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675721798; x=1707257798; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8GE1fZKcNZbLmBi51IrXVXcHqJazEVEwOf9U373Kk8o=; b=DkxkuZ0s7NcKXLb14yxUzJxEErqCqFhNyOQNhq2EFMTSM78ATTNSxCOQ w1ScetEgnhOLWBN2eYr4/qQeFjxvYRXCkF/4auZMAFwSeaECsnGde1WsT HdOXShktVMZAstBZnDQa7e1NAUvdGxzYX60moQ61TwAZjLie80DsnA1gr wEILN66cmbLo5gbThBgf1A8PpKZt/BJSH3OH3sggpJM5h6+u4yQyQbfW8 yRb/BOZ6Nm9b+t3fYGyCv2v9YgHdFDUoBesImsrK9eBGAkJufS4tSvvoo CQqS9jR/w9aj6tLAyia4IcjV7zLFXbnSnM+0/85wl91TofqUSSw2MpG0p A==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="312983148" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="312983148" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 14:16:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="755395786" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="755395786" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.212.111.195]) ([10.212.111.195]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 14:16:35 -0800 Message-ID: <982239b1-2bd5-9045-6097-c413208aaecb@intel.com> Date: Mon, 6 Feb 2023 15:16:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.0 Subject: Re: [PATCH 04/18] cxl/region: Validate region mode vs decoder mode Content-Language: en-US To: Dan Williams , linux-cxl@vger.kernel.org Cc: dave.hansen@linux.intel.com, linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564537131.847146.9020072654741860107.stgit@dwillia2-xfh.jf.intel.com> From: Dave Jiang In-Reply-To: <167564537131.847146.9020072654741860107.stgit@dwillia2-xfh.jf.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E2B554000B X-Rspam-User: X-Stat-Signature: gsmc14bgg9sudui5cm46moq9a9med7b8 X-HE-Tag: 1675721797-73029 X-HE-Meta: U2FsdGVkX1/3pj1iwn8NoFa5DawP8FxDsQBM760gk/lojHoHLqmL2NKE6+1svpPRdGmIzVBomZ300jWAThvOn19zDKxgzAlQ5L64n4QwZ0wSoMZ4evJJvJABTyVsUcs3pCuzZ3VBzhjVGNiL5FK0I6wJmkxboJ0mN+dG4AKg3Gh7lqzjRl/D30veMElLwEx4/WUKsctDqnk2mXRE9WZD8Ob1fS90HOztzKiO3Y7TQvEz9vHfLxhuWzsTmwdC+2O/DrUb862ZX8JS7pR+yP3SbglYsERkUqYR0IipmYR/zsGySO3m/JrZR1fTkTEY07u0C664Axd3bPgQicTdDh9gi35FiDssAO0xO0tbtExDCy1U2HmjJPFfx6Ckorv+XymVK0J0IK9vqOtH3Y+p0348U9bgCiWl+7K+54/rziQOKJ6HlmirRazUf1YeU5SM+Ih/cZXvvg/yzGGTD+VjQg7ukfiebtWq8Ds3dSyHKXPxpuO7/A+2LBCktNXQTTnN6AkSjPcg2kgvqpFV4bl1mc1BL1d5vH8yB9jkrtDFef79gdH3FZfPU69IpftvVKFapDGRhl9qOc596YH1FEvMh5E3zUOELTt75EbKTeO0sJbT+ked5rZAbwYD3N9chuKnzEDkBh9iMkpjSA4ux8gbpBM9fFqhjG4O0+cVCmj73DX6w6HVZ/T5hR6ar/kMxaNsudszd40hyY1Xt5KlhfASpAZvh3vDC6eou3zxFjJiaBrPLNOjwy+4Ox4Uh1vkVf14G6SnFOUjylMqw5Ti6ouG5bU0/Ifmn7C8mPVnwuU74oEFVUqe63fF5ewJwKfqXBnK0Quz1FyDtxyDPq3K6ZvwuN/wTAtOWeJb7A1coFE7MsU5ooOxQObOjXjrepaf5QuiBF8bh6b2W57RRad7KN1ENfCtLLsSCxG8aU8oAk6Ior6t4xWpywSe6YJ1/wzOGpqg+kCg/u3MV8zs4UTIPiEjNin 96EQU4QK HXm8xI5NSFTyMsNqzYt9IJpgUH2B/aPThwFTCbZhiQhZkSFAd1ZVLocRl+pxY5e214Le2yIqL/BGgB6c5LzoKNVcrZVVQRk293qe/CEA1vMhpUTfEc3HZNTtTDu2yPc2+4NDGwxnxuXf6KjxUG6p8a48/nrDTyJIjloMEtHSCZEsphnUhVP+lsRylvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/5/23 6:02 PM, Dan Williams wrote: > In preparation for a new region mode, do not, for example, allow > 'ram' decoders to be assigned to 'pmem' regions and vice versa. > > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang > --- > drivers/cxl/core/region.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index c9e7f05caa0f..53d6dbe4de6d 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -1217,6 +1217,12 @@ static int cxl_region_attach(struct cxl_region *cxlr, > struct cxl_dport *dport; > int i, rc = -ENXIO; > > + if (cxled->mode != cxlr->mode) { > + dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n", > + dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode); > + return -EINVAL; > + } > + > if (cxled->mode == CXL_DECODER_DEAD) { > dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev)); > return -ENODEV; >