From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC506C433E0 for ; Wed, 17 Mar 2021 20:16:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 436A364F0C for ; Wed, 17 Mar 2021 20:16:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 436A364F0C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7D556B006E; Wed, 17 Mar 2021 16:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A40D76B0070; Wed, 17 Mar 2021 16:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908F46B0071; Wed, 17 Mar 2021 16:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 74C236B006E for ; Wed, 17 Mar 2021 16:16:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2DF3E18015841 for ; Wed, 17 Mar 2021 20:16:30 +0000 (UTC) X-FDA: 77930473740.05.CF6A476 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf29.hostedemail.com (Postfix) with ESMTP id EC2BE6923A for ; Wed, 17 Mar 2021 18:54:13 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id v8so30165plz.10 for ; Wed, 17 Mar 2021 11:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=rMyvcCmECo2UF5BrQ0BBNWIYi9bGONy40iMZu5iyOik=; b=nNqBakMSl8IOlJP8VjLFEVNGJ0s7A0Cm/0SrdHwHagrx/CjP3IXO6bwNoX0gISXwce H5D/P0RcWDi+nBaB76Sg2uELMIYV8PLRi+MojQBWRzAfibbDXQ3Q98MukRBTVA7i9j+0 o6gFizrXvhM1yAZWXgRmdGTZZPGD7E3H07i5TDWcAUWReX6jCIJI2lIiVNuiZx0Vju3c LRK+dAjPPiXH14E5U+ZGImniyBP5onJs4N7uxM0vihP1k+gNDHtOcp+QaK8ZWSm5Mgj5 AfpIwmqlio95IH8VIo/vq99aHeSWnpaVh74XQnE0eTAXUj9esOk/qvo+CmF5jEYUyxy+ R4bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=rMyvcCmECo2UF5BrQ0BBNWIYi9bGONy40iMZu5iyOik=; b=dZg5MhrPqC/3KNSpxwTVVfAiU0KSobNjVkNpV+gtxM2NTN7SYfi3/mfmij1a0I8adn T7u5AyH3omQGVCEe/FuKB93HZbRftKr8pG5VgUu7UlHgYQMoO21CSkU7pn9o6sdGYx6T STaONP5gw1yEwVNB4leiNwiXzFY51JkPBAExKkwYNUUhEma03NtrYh4okWQcEqpy4ZWp KERCi6Topy7nFy4Cn2v79G3vjNPfEK8r7kbUYb779QnPK6OJ6gKAc5AVkd3znicm8sb6 64VF2BJAXe1fiWSct/itSbEeavibPwIk3I0F3UwNSgUHsq0iuXvfe+yjYggkgzN40T1j TfKw== X-Gm-Message-State: AOAM533kDw0NKU/X/FVxXPYjQh8iO08EF60Nc4aPElzfQzL3M9RUzO/Z TeSlz3vhyqbuGhSEwZ3Sj7tILw== X-Google-Smtp-Source: ABdhPJxoJ/lR426aplD+YyMkxVJUtHq6Vt1FBVhabjeKlgXTrUcdrMGKFzdHnIdTH+dr9vJJdjvERw== X-Received: by 2002:a17:90b:514:: with SMTP id r20mr247990pjz.145.1616007251900; Wed, 17 Mar 2021 11:54:11 -0700 (PDT) Received: from [2620:15c:17:3:b56a:51db:a0a1:259f] ([2620:15c:17:3:b56a:51db:a0a1:259f]) by smtp.gmail.com with ESMTPSA id y9sm3522935pja.50.2021.03.17.11.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 11:54:11 -0700 (PDT) Date: Wed, 17 Mar 2021 11:54:10 -0700 (PDT) From: David Rientjes To: Oliver Glitta cc: cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/2] selftests: add a kselftest for SLUB debugging functionality In-Reply-To: <20210316124118.6874-1-glittao@gmail.com> Message-ID: <982058b5-6db0-d85d-126b-502f24447528@google.com> References: <20210316124118.6874-1-glittao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: eas6fxqp96kmhi354wwj5thb6guyg9sn X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EC2BE6923A Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-pl1-f182.google.com; client-ip=209.85.214.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616007253-232525 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 16 Mar 2021, glittao@gmail.com wrote: > From: Oliver Glitta > > SLUB has resiliency_test() function which is hidden behind #ifdef > SLUB_RESILIENCY_TEST that is not part of Kconfig, so nobody > runs it. Kselftest should proper replacement for it. > > Try changing byte in redzone after allocation and changing > pointer to next free node, first byte, 50th byte and redzone > byte. Check if validation finds errors. > > There are several differences from the original resiliency test: > Tests create own caches with known state instead of corrupting > shared kmalloc caches. > > The corruption of freepointer uses correct offset, the original > resiliency test got broken with freepointer changes. > > Scratch changing random byte test, because it does not have > meaning in this form where we need deterministic results. > > Add new option CONFIG_TEST_SLUB in Kconfig. > > Add parameter to function validate_slab_cache() to return > number of errors in cache. > > Signed-off-by: Oliver Glitta Acked-by: David Rientjes