linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Kevin Brodsky <kevin.brodsky@arm.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Andreas Larsson <andreas@gaisler.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Borislav Petkov <bp@alien8.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	David Woodhouse <dwmw2@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Jann Horn <jannh@google.com>, Juergen Gross <jgross@suse.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>, Will Deacon <will@kernel.org>,
	Yeoreum Yun <yeoreum.yun@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
	xen-devel@lists.xenproject.org, x86@kernel.org
Subject: Re: [PATCH v5 07/12] mm: bail out of lazy_mmu_mode_* in interrupt context
Date: Mon, 24 Nov 2025 15:11:44 +0100	[thread overview]
Message-ID: <9800804f-6e8a-4d08-8eb1-f114df6d6b7a@kernel.org> (raw)
In-Reply-To: <20251124132228.622678-8-kevin.brodsky@arm.com>

On 11/24/25 14:22, Kevin Brodsky wrote:
> The lazy MMU mode cannot be used in interrupt context. This is
> documented in <linux/pgtable.h>, but isn't consistently handled
> across architectures.
> 
> arm64 ensures that calls to lazy_mmu_mode_* have no effect in
> interrupt context, because such calls do occur in certain
> configurations - see commit b81c688426a9 ("arm64/mm: Disable barrier
> batching in interrupt contexts"). Other architectures do not check
> this situation, most likely because it hasn't occurred so far.
> 
> Let's handle this in the new generic lazy_mmu layer, in the same
> fashion as arm64: bail out of lazy_mmu_mode_* if in_interrupt().
> Also remove the arm64 handling that is now redundant.
> 
> Both arm64 and x86/Xen also ensure that any lazy MMU optimisation is
> disabled while in interrupt (see queue_pte_barriers() and
> xen_get_lazy_mode() respectively). This will be handled in the
> generic layer in a subsequent patch.
> 
> Signed-off-by: Kevin Brodsky <kevin.brodsky@arm.com>
> ---

(resending as I pushed the wrong button there ...)

Moving this patch earlier LGTM, hoping we don't get any unexpected
surprises ...

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

-- 
Cheers

David


  reply	other threads:[~2025-11-24 14:11 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 13:22 [PATCH v5 00/12] Nesting support for lazy MMU mode Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 01/12] powerpc/64s: Do not re-activate batched TLB flush Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 02/12] x86/xen: simplify flush_lazy_mmu() Kevin Brodsky
2025-12-04  3:36   ` Anshuman Khandual
2025-11-24 13:22 ` [PATCH v5 03/12] powerpc/mm: implement arch_flush_lazy_mmu_mode() Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 04/12] sparc/mm: " Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 05/12] mm: introduce CONFIG_ARCH_HAS_LAZY_MMU_MODE Kevin Brodsky
2025-12-01  6:21   ` Anshuman Khandual
2025-12-03  8:19     ` Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 06/12] mm: introduce generic lazy_mmu helpers Kevin Brodsky
2025-11-28 13:50   ` Alexander Gordeev
2025-12-03  8:20     ` Kevin Brodsky
2025-12-04  4:17   ` Anshuman Khandual
2025-12-05 12:47     ` Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 07/12] mm: bail out of lazy_mmu_mode_* in interrupt context Kevin Brodsky
2025-11-24 14:11   ` David Hildenbrand (Red Hat) [this message]
2025-12-04  4:34   ` Anshuman Khandual
2025-11-24 13:22 ` [PATCH v5 08/12] mm: enable lazy_mmu sections to nest Kevin Brodsky
2025-11-24 14:09   ` David Hildenbrand (Red Hat)
2025-11-27 12:33   ` Alexander Gordeev
2025-11-27 12:45     ` Kevin Brodsky
2025-11-28 13:55   ` Alexander Gordeev
2025-12-03  8:20     ` Kevin Brodsky
2025-12-04  5:25       ` Anshuman Khandual
2025-12-04 11:53         ` David Hildenbrand (Red Hat)
2025-12-04  6:23   ` Anshuman Khandual
2025-12-04 11:52     ` David Hildenbrand (Red Hat)
2025-12-05 12:50       ` Kevin Brodsky
2025-12-05 12:56     ` Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 09/12] arm64: mm: replace TIF_LAZY_MMU with in_lazy_mmu_mode() Kevin Brodsky
2025-11-24 14:10   ` David Hildenbrand (Red Hat)
2025-12-04  6:52   ` Anshuman Khandual
2025-12-04 11:39     ` David Hildenbrand (Red Hat)
2025-11-24 13:22 ` [PATCH v5 10/12] powerpc/mm: replace batch->active " Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 11/12] sparc/mm: " Kevin Brodsky
2025-11-24 13:22 ` [PATCH v5 12/12] x86/xen: use lazy_mmu_state when context-switching Kevin Brodsky
2025-11-24 14:18   ` David Hildenbrand (Red Hat)
2025-11-25 13:39   ` Jürgen Groß
2025-12-03 16:08 ` [PATCH v5 00/12] Nesting support for lazy MMU mode Venkat
2025-12-05 13:00   ` Kevin Brodsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9800804f-6e8a-4d08-8eb1-f114df6d6b7a@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreas@gaisler.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jannh@google.com \
    --cc=jgross@suse.com \
    --cc=kevin.brodsky@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maddy@linux.ibm.com \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=peterz@infradead.org \
    --cc=ritesh.list@gmail.com \
    --cc=rppt@kernel.org \
    --cc=ryan.roberts@arm.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=venkat88@linux.ibm.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox