From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C89CF11DF for ; Thu, 10 Oct 2024 12:36:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A77FD6B0082; Thu, 10 Oct 2024 08:36:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A26776B0083; Thu, 10 Oct 2024 08:36:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C7466B0085; Thu, 10 Oct 2024 08:36:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6E9086B0082 for ; Thu, 10 Oct 2024 08:36:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 59DC4AB113 for ; Thu, 10 Oct 2024 12:36:46 +0000 (UTC) X-FDA: 82657641906.05.3910B28 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 068EB12000F for ; Thu, 10 Oct 2024 12:36:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728563629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVCl/OGnpRlOrqDgmCi9NEV33sZ5DJsIG3PnXG58jUI=; b=Nm26+0E3SAAscB+xLLO8IWwyl1UXRlL+BrYLibBiB5Vj0+fmOHjH59ChVMZKDQboGWQQ8/ wvoYKRnRGmGA28Wy608lyjxDXTXTjW24mNaS1b1Ws9LPi1eG+1j8mgtkp58WoipR4UNcN5 J5uIwHIMojQf8hZZjG4fDkQekzH5D9k= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728563629; a=rsa-sha256; cv=none; b=5Mf/Buoxtavf/lJSWe5Q8MeIwIngZRFs8eVT1eI9gX2DZyKrHnFAZFJ/0O+gkyzTI+VLtp G6txSh1ezJZU8UrG9qYWj21SpqiGGWlVkwF4AggBbRjaatn6eFIZJoJ/Iq0ehC3b+H2CLi ndybwIIAiytMaQYuaiyvfn7YdPE7Sdg= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D9CA497; Thu, 10 Oct 2024 05:37:20 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E41783F58B; Thu, 10 Oct 2024 05:36:47 -0700 (PDT) Message-ID: <97dc6f9b-f8b9-425d-9962-3a6e2831679f@arm.com> Date: Thu, 10 Oct 2024 13:36:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx> <87ttdlr3s5.ffs@tglx> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <87ttdlr3s5.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 068EB12000F X-Stat-Signature: ucq67n36fdipff3w7jgecmgacxwy794u X-Rspam-User: X-HE-Tag: 1728563809-765163 X-HE-Meta: U2FsdGVkX19o4Wwjxb80bp/MkRKPTJK0z1QxIAgdtnbSjx6ThYPwsUnhq7Rp231vpvbRXxvYvKwt7gpNpxeZfb33tameP7m6RmHeUGfdG4y+9iY0qh1vaW+WwXmlg6QlwG92DYoumgGL9VPZqK2AM+Ipy2hTIUWh67wSr5OQdJohE46YEFHVMfIcb1hOYlSuyjsVm19Vh0jFgrpUNDkFqoMmacDTa/xiQcz5a3jC/VPTh45fQ2CHbiPr1x7FYY0+yAaS7FMoHKMFPYcbBd4dEjFIyddNvnbp0F0cKZANra05IkwnP7cKRaKeSnrukrfiUaw6iGL/6JbBpLaGUh9JHMAZIFAE3HRKNZazMjI2qbO0o9BLkQmrJs5peBLjl+VVANxN67AWwJ+JTuPMK4n9JNE3ulI4eGFDf35FDt95ye0Zbz1QrtFBAx3w1SczrkdVJN/B241/gJU7ku9qVd9QzcUeIHe0EhO88Cv0GAohnuBJzl8I/AIo3G1xY/QA3FvJBL/JoCCla34oOajnfcOc7WD6KctUgAVoLWrmBprYHNg071uM0hDWaIEyasAGkgxfLGtv7V2PKbOwA/PxjqK270lQsoD+2B7/PwDEpip/dCvdK3YK6702zy7j4NWm7fhTMvMW9AMs1vTyZUPa2DfbudgDtIjVZMLUFBcQ8i2/yW4UStqDVdgnDmfb48Bl3thMOfJhd8hNge2ESPeVu2EqsrE1R74NvpOvgYM3zU661gBQmHzyYEjJD5clDp20MAfTy7Lp8E78Orj6mftLH2/m+iZ2BLX3owo8irENUHja5BSKxVNrHXTltcIj34LfvLuX5P805539l9R9u/qLDrbMc5jOMSV/8bfAF1cavBGNf0fJ4NM0LuCTrfssqg/8k0PiGUAESmEwkoIl2M/0eno4uThXGbs4qAGRBFYnh8Vn1zeiBfXE2mqksUgKbiMy9+MXhn+23D/8aR0rC+FNOQa LKvz+jC3 cICRU++na1X2BgPW2BGE3juOTh3jP+PcSqZg2RhNnVMu+ZTMmzRhyRBXCmOsiT3eCmRVCiC1jAYr4/tGltmgOAMkKnQUb8kNGexRx4gEP5sjqv4GIpfDg5RhAcH0ofiTdpYWdKOovoMKLV9fOPvTwBMXSYQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/10/2024 11:04, Thomas Gleixner wrote: > On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote: >> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote: > > Hit send too early. > >>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT) >>> +#define PAGE_MASK (~((1 << CONFIG_PAGE_SHIFT) - 1)) > > This really wants a comment. The magic reliance on integer sign > expansion is any thing than obvious. > Sure, I will add one. Thanks. > Thanks, > > tglx -- Regards, Vincenzo