From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21119C83030 for ; Fri, 4 Jul 2025 07:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6D8F6B0191; Fri, 4 Jul 2025 03:56:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A452D6B800A; Fri, 4 Jul 2025 03:56:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 933D66B0193; Fri, 4 Jul 2025 03:56:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7FE0D6B0191 for ; Fri, 4 Jul 2025 03:56:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E4968C2446 for ; Fri, 4 Jul 2025 07:56:32 +0000 (UTC) X-FDA: 83625825024.19.67469AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 8CAF2140002 for ; Fri, 4 Jul 2025 07:56:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="htaVz/HO"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751615790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0uaRp4EpGhUSeziv02wWzTYB6IodAtLkWURM9ee31dI=; b=SuNvqaluhW1rmUVZW8uPO5mTjRDqzwQQRmbB0cz/myGRFCpW8Oc52ahqGe2UrEOO+oLtgZ 1sgTSKQe6Q/JdQFV4g+J+Tyd1Q4Z4eQPOcyV5E9EzyEPHfFxCLEbaR41hK/Lx7oZNFSaC9 I88EBULvwJcNoxQ0hpczvm8JNoziZIY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="htaVz/HO"; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751615790; a=rsa-sha256; cv=none; b=PCJA7hJWqTvQbKyhkhsiddAktqHhLfvXm+bu15Sd3lSiSojdXyCsp8AtS/W/Xy3xfxXXss kk6cpuzauGDTajW/GqhUb5J7k3MIIAIudAYnLuBQSAUGqrNmEL8FPF9wkIIx3+n20vE8qv 2M5cGvlrAreVDHLHwObasQfpLs8mowE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751615789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0uaRp4EpGhUSeziv02wWzTYB6IodAtLkWURM9ee31dI=; b=htaVz/HOxh8Tl1QrG3wNnlRloqT4aDwEN+vzwJPj+T6mCjc44IUlFj+ZeCVqdvHJzCXnii jsM7s4MP4TujZ6OLSusprIYftphSrZq79QGioaVEnjSRzq8FSYXXK0jgWEPLX/UomVMPWG 9gNrgNB+YmnyON8xQ4NlFMkHOo5wlbc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-4IZ1-IXFM6254mibS4Ewsg-1; Fri, 04 Jul 2025 03:56:26 -0400 X-MC-Unique: 4IZ1-IXFM6254mibS4Ewsg-1 X-Mimecast-MFC-AGG-ID: 4IZ1-IXFM6254mibS4Ewsg_1751615785 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45359bfe631so3144425e9.0 for ; Fri, 04 Jul 2025 00:56:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751615785; x=1752220585; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0uaRp4EpGhUSeziv02wWzTYB6IodAtLkWURM9ee31dI=; b=LFI4OKQ1n1lYqbsUkMF9lxDvydUVc3EAE3qnYWHV89oxjpgBRzXjvulk93LAXoZ9wY oZDIvQoinhJhXw3dJ7FaES0NAEuFheNBt+mNDlkEOsRwutnyrl8d6Qvgoj6M4GFepw0j l7XIYNuIVRV7EJySFGxuVIo8Syc4LJVYKTfFSRjnBSriTZ/YcLLQkTwmy8zNo9ssAB5n zrXZQDPF+jMe2o15S01xbXamC43NT7OgpdbSp5b9MCs3YxDuX88pL/bqo8aPPHAHRBOT H+ZjRkjHyq1PwLmjZMVes7mvzVZtyVwI26kwVabUAKNcrkQymnSf+bMDIlTURzqLJT1W p+iA== X-Forwarded-Encrypted: i=1; AJvYcCV2Gz7K2lwRRj81/7TyoBPQbqNoELy4mk31b6g3KS2O/QvM56giF3gsdT7wij+m4mAcqpU+KMf4Yg==@kvack.org X-Gm-Message-State: AOJu0Yym3BE7CFWk6ryKwNHg1JnNZxczYUz82oYd0Kx0hw+Se+6M/v83 my7YRxWXNTdjQ3RdeVpWNZ9ZkYxsZIpsapV3SW/Rt7Ul2Oh5Cfh/liYogSgRYmfiiLwXiW6OZZ1 wRqKfI6BgaWAG3IjWeqlgO+Eqz4jvanyX3E9bdiwbto2Zrg18j9l5 X-Gm-Gg: ASbGncv4qdR19K8+FNKkKqwcrdgFQgyogWJm/Hzr0HygQERgCPM+c8AIO53hY8+MwNC QSavFGsrpFx2+Bdu0dT2348jwSYMGBlj0KJWfspQFizgTbyMfN34GErIR3mtzw8gdjXcTwzEKuW mdql2RezFW7RL8rIqikCN86WCZkKkSD5CZsUVvGNgAOdqPEbzoY2v4dQI96JlQ+VpeqxUPQzp2E IArW3UMnpDlOl4QKUvacpvdR4PRHIbjEh/sghyQr4ilCHTviT0Kdodvpw4xw5icGyNwIo5GvWL6 f58NZxTknLDj/VKniM9zz30ud5mXL4B81hl+jcAP6JOaju4UIB3vUAe/RM58EIzHngKIJ6+7ES0 KWrJ4q1+N6uSu3Fg79qWB9V0GYN6LzM9X5OYICLT2XSLAz30= X-Received: by 2002:a05:600c:3e1a:b0:454:aba2:c332 with SMTP id 5b1f17b1804b1-454b3187c22mr14015545e9.29.1751615785170; Fri, 04 Jul 2025 00:56:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5QPrWj7L9jFsdKgPgTH8F2oFmdewm+dCoh4A6AxVtHkNOjPG73CwemCQhmtK/JCTNeSmafg== X-Received: by 2002:a05:600c:3e1a:b0:454:aba2:c332 with SMTP id 5b1f17b1804b1-454b3187c22mr14015215e9.29.1751615784694; Fri, 04 Jul 2025 00:56:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47285c9f9sm1807879f8f.93.2025.07.04.00.56.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 00:56:24 -0700 (PDT) Message-ID: <97d3993c-12aa-4917-9bbd-d9c94fbda788@redhat.com> Date: Fri, 4 Jul 2025 09:56:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm: introduce num_pages_contiguous() To: lizhe.67@bytedance.com, alex.williamson@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, jgg@ziepe.ca Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250704062602.33500-1-lizhe.67@bytedance.com> <20250704062602.33500-2-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250704062602.33500-2-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nBofNSnnzyFDO4VHztLhLHJFfe6OAQnCojH5COJFJhM_1751615785 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8CAF2140002 X-Stat-Signature: nennjw1hrniayyr734gozebmyh6nqjca X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751615790-491525 X-HE-Meta: U2FsdGVkX196U4Zd4CZ1QjIEhKT5uwzwMq45lThd3Tz3yZtYpB9wtgIzQXH1A6EIutSbSTUC9w0zJzkT8iGFoM0red0dVRyNBgZr9YUlEPH2xmJZYlwEkcPMOBbtAz/ryuXTQtNf1O1jyD192jhTBNDQNVRebc+AQCMfxYiCF0Pn/P5YTnSJp1XBS8QfplnMZtg4U1heat5O0l/P1/1Mo8oZ5QxsaEpqWZ0iCeskDg6kr+w/Uj/cK5MfShnioYzp2nAVA/V4VR9SkI6TBbzSs80326aAuD+tnra5errUGMJFRJa19UPMKCkW6nhRXfG3AxhJrYt3MZN0DrMVFvcIfNw+s7oFHEtOQ1zCGE0XJ99X/V9+sTbZsv+Kk81ix8eQCeYXhAFjgfKr2q4Ue0FrwxyuYSQ/c8+iC8Wi7yOgmxrd3l8Y6R6rmbR/0Ke7Ms8dCzzvz7IeBYKAc/6XFfEq0J0HFFdtJLG2h7IIQuI6FUHCPy/LU/1w1qpV3jfuDjCkSSJCXMaoGwLv5i/j1CM+QZ+nLdJxywZYgUmKfrl37/wXKUsh6M4C7Gao6DwdxLquLLc+Nj3r3gdu3rpqi1OIS1DwOU8jbf5rDbloRZ+XIN4ae79pTK2VLypC3hkIA34pW72utZT0S1G6MjuZW9Ckag1RhD1e70kBS9ygYRnUUqNvL00Z02oy1vpTSj7Hw3DbnrXqlaNS38DCHyyCX2GnJa8WQtzQA9dxkU2M5MkA6z4uTMzRrU9sG1t55GXGr/vZvXg1Xw2ibRV3+WbgWveuc8PKubELTydXcSe/5NbdAFoCJuEPXTPAhVrwt8X1wbKLelOfiXABaQIBkICBOee8YJCl/hAV4+FAER3ZyjP0isfxUuDzfkaBie+XmDtGbmQwP4sl/r2qh+Dhanb2A7VBGEtGW9EZOeEUKWw2pSba82hn8u/Xh5Lmw3qKxKJwXQ7iIF/ZOs/eQeyLZkqrVxp IJqLN0pS NNC1xfNoENeHdssIjRQbNNSd7+p49AVjEAB2UXnbkBz7z9CbRmjyY1+qucUTFcCvIuPexGs9oSmWOiISd1SIpAFjejangQbu2T6sSfBdgqtmd6LfxS5vX33BdLiFJ/tJvgocpMjPN1zbkHlBOcQHPU4eqxlgWgXFYw4th X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.25 08:25, lizhe.67@bytedance.com wrote: > From: Li Zhe > > Function num_pages_contiguous() determine the number of contiguous > pages starting from the first page in the given array of page pointers. > VFIO will utilize this interface to accelerate the VFIO DMA map process. > > Suggested-by: David Hildenbrand I think Jason suggested having this as a helper as well. > Signed-off-by: Li Zhe > --- > include/linux/mm.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 0ef2ba0c667a..1d26203d1ced 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -205,6 +205,26 @@ extern unsigned long sysctl_admin_reserve_kbytes; > #define folio_page_idx(folio, p) ((p) - &(folio)->page) > #endif > > +/* > + * num_pages_contiguous() - determine the number of contiguous pages > + * starting from the first page. Maybe clarify here here: "Pages are contiguous if they represent contiguous PFNs. Depending on the memory model, this can mean that the addresses of the "struct page"s are not contiguous." > + * > + * @pages: an array of page pointers > + * @nr_pages: length of the array > + */ > +static inline unsigned long num_pages_contiguous(struct page **pages, > + unsigned long nr_pages) > +{ > + struct page *first_page = pages[0]; > + unsigned long i; > + > + for (i = 1; i < nr_pages; i++) > + if (pages[i] != nth_page(first_page, i)) if (pages[i] != nth_page(pages[0], i)) Should be clear as well, so no need for the temporary "first_page" variable. Apart from that LGTM. -- Cheers, David / dhildenb