From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BFDC47079 for ; Tue, 9 Jan 2024 18:11:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97946B009E; Tue, 9 Jan 2024 13:11:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E206F6B009F; Tue, 9 Jan 2024 13:11:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9AA26B00A0; Tue, 9 Jan 2024 13:11:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B7B3F6B009E for ; Tue, 9 Jan 2024 13:11:19 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 98C831C1171 for ; Tue, 9 Jan 2024 18:11:19 +0000 (UTC) X-FDA: 81660564678.03.C3EA003 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 756A340018 for ; Tue, 9 Jan 2024 18:11:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704823877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zq4C/p3LP7aTVTSvQDdWZw7hWF41Ime+Zohd6uLB4vM=; b=HKUsKEOxpCECT9Om1heuQC22jv2vzPoohrtrgSSFWxlexz0X3Sy+f3VxOknzuWL35moY7w fwo6oLCZQDWXJu1soL8W6amjxkj75XhSznj7+jhk/79LiX+elQf5z+G9S0ueuiAZLa6WKF 9NWsjl0uxxKny1TU4cXux3MMYtvAbBo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704823877; a=rsa-sha256; cv=none; b=iDyp+HngnI32LC5Ez9DaYSPWafMM1XXFAzREUhLM+PWsLFuBEE7R4cDMA0UiEX8ANiswD3 oBbCgpEFtCRyD8iog18j+eD5QO7DCSeWTU08rwK3bRk8BAT4EueXzqltGSltm3tlsIoHrN D3SbeGzCDSx4+F/kwbsX+OhW7cLhGxo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=27;SR=0;TI=SMTPD_---0W-JAUV5_1704823869; Received: from 30.25.253.88(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0W-JAUV5_1704823869) by smtp.aliyun-inc.com; Wed, 10 Jan 2024 02:11:12 +0800 Message-ID: <97d0e776-d672-405a-9359-fb7f16969dc3@linux.alibaba.com> Date: Wed, 10 Jan 2024 02:11:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] erofs: Don't use certain internal folio_*() functions To: David Howells , Christian Brauner , Jeff Layton , Dominique Martinet Cc: Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu References: <20240109180117.1669008-1-dhowells@redhat.com> <20240109180117.1669008-4-dhowells@redhat.com> From: Gao Xiang In-Reply-To: <20240109180117.1669008-4-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: qajwob1rxzo9qxaam189nxfcxteczb7r X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 756A340018 X-Rspam-User: X-HE-Tag: 1704823876-346783 X-HE-Meta: U2FsdGVkX1+2rQtqUosR/G7L+GlrCKe06IhSMAAi6sMJSh+XXPhfC9y+n1TrUPZqvihqP9zS6LlVL8IS/LWAyxs9Xbrq3+VLWGFBh5fy4Cb4giSumfWGv7gZhal2JEp3UCZ89+3oRvI/Fihhxg9yvOlSVdDDEXorMwH7Pr8sNVA9a0SeBd1UjFBs5e7Zqm1sAMx5Uwrhm0289dP4uGUqmn8Eh0RHR0mSj0eao0+P68K/x8xLCI76o8oyz3wYSODwEpSWVDiGQxswHbjCWCVSFk7f8sqWnfinVhL8XwBaK4gMdyWAg38hAZAO005hwhFmQ8N/a4N9RQS8A3UxwNz4mAaOiLCW1qTooCGTrO67O0rk5k4gRjtlaEfG1mo/aGYytdKoXdN8MPklaKgKjbTxoCh5a+HetkaNWzG+JxwF8uWEamZZgHRlgCkxDd9fHWRCMyMcXyAAx1JsTbMGGDx9xFLaJN1EDBMNw0hFFRhrKTo4omnzbOlhalKeUHS3pcXR09lrweIKPbpaqK7sEzHsXnNm4XpfVVU6VX9Kl8yGSx8WgujzKz9PNJgANJFZuuzIFljSam7juWrNiFPzYa93aN6p+vSmHfFdnTAoOhQckD1/Hjj51HgCj1Thx+rdgf28QCm/qmq7YOEA/0+9QLrWM179BuhFs7qpOaGUJ4augajkkdEDvSa2tk12snelN5pIgJSOQjC/W0I2d3QR7Dj6T+UpvwtqEhb2dqedLtGnntywMqhrAvz4w/yU+vzNpFrkeEdUvTxUJxpoEITjumURxIZpBswaexMJen3WF9qzyuCLTn5YNDymgnBkvGldX8xlcZkYlhyggdMorvRiCRbpd7Blk6F0dFUSkdZ3EM/Vj5fLyBDTNgdAFs10mwR9OazWjRHjsqPJuNfGrADOkN9cihh63ESAGe+iS606dxkoYixFmc1OjpIefX45P56H8uWr9BQ2NIzK+0YP5IBBUIp fLpwFdvu RUIP3PfaDdbP8J98WLvUCA8exMPB3H35vLGNIyVaI2GxqsnAzJPMVOxTqi/n5Q1EaqUuuTUAws2NBbVQGs5eC5MwD4+1B6XJXoajaK/+CAGHCyvxDs2YAqO2vXK8g+caTghPUSwrEF+NVcMLgmrnKwg6awIm5EBvahAuPNJ/yfYKaVqswR/HCutF8I09oj/p6mTxhwqbxw0mHabOuxMNGauD8aSuLl76h8xvwUM8o/yWovHuqvZ0UhEg8iS+xMD3pD/61O/hda+Q/7bjlQXIzIXZuUQiQOs6b2Unx1db0xsnxngmGM/RHyHEuYsV7TaLH8M6F7bPPbbh4tp+VvN5PQsTDfrh47f69JjlrqCN/xPxF7C97+xFBmzFR8aXaygy5rHqaPzkFOBInFNzbdlEBH38Ps4wnyU4SFU4nagYNcnaLfT5x2Qavs5hIAe3URdhGiFIQHx3kKhoqi4T/JRXvD7X5JY9CrBLJ8zZauROAvoTT27r24rZoj1LUQiOpX3tucOcR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/10 02:01, David Howells wrote: > Filesystems should not be using folio->index not folio_index(folio) and > folio->mapping, not folio_mapping() or folio_file_mapping() in filesystem > code. > > Change this automagically with: > > perl -p -i -e 's/folio_mapping[(]([^)]*)[)]/\1->mapping/g' fs/erofs/*.c > perl -p -i -e 's/folio_file_mapping[(]([^)]*)[)]/\1->mapping/g' fs/erofs/*.c > perl -p -i -e 's/folio_index[(]([^)]*)[)]/\1->index/g' fs/erofs/*.c > > Reported-by: Matthew Wilcox > Signed-off-by: David Howells > cc: Gao Xiang > cc: Chao Yu > cc: Yue Hu > cc: Jeffle Xu > cc: linux-erofs@lists.ozlabs.org > cc: linux-fsdevel@vger.kernel.org Thank you, David! Reviewed-by: Gao Xiang (I've asked Jingbo to find some free slot to refine this part for later compressed data adaption. Yet that is another separate story. The patch looks good to me.) Thanks, Gao Xiang > --- > fs/erofs/fscache.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c > index 87ff35bff8d5..bc12030393b2 100644 > --- a/fs/erofs/fscache.c > +++ b/fs/erofs/fscache.c > @@ -165,10 +165,10 @@ static int erofs_fscache_read_folios_async(struct fscache_cookie *cookie, > static int erofs_fscache_meta_read_folio(struct file *data, struct folio *folio) > { > int ret; > - struct erofs_fscache *ctx = folio_mapping(folio)->host->i_private; > + struct erofs_fscache *ctx = folio->mapping->host->i_private; > struct erofs_fscache_request *req; > > - req = erofs_fscache_req_alloc(folio_mapping(folio), > + req = erofs_fscache_req_alloc(folio->mapping, > folio_pos(folio), folio_size(folio)); > if (IS_ERR(req)) { > folio_unlock(folio); > @@ -276,7 +276,7 @@ static int erofs_fscache_read_folio(struct file *file, struct folio *folio) > struct erofs_fscache_request *req; > int ret; > > - req = erofs_fscache_req_alloc(folio_mapping(folio), > + req = erofs_fscache_req_alloc(folio->mapping, > folio_pos(folio), folio_size(folio)); > if (IS_ERR(req)) { > folio_unlock(folio); >