From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A050E9370C for ; Thu, 5 Oct 2023 13:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 081A36B02BC; Thu, 5 Oct 2023 09:41:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0315F6B02BD; Thu, 5 Oct 2023 09:41:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3AFE6B02BE; Thu, 5 Oct 2023 09:41:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D4F5E6B02BC for ; Thu, 5 Oct 2023 09:41:54 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ACAB5A020A for ; Thu, 5 Oct 2023 13:41:54 +0000 (UTC) X-FDA: 81311520948.19.948934F Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf09.hostedemail.com (Postfix) with ESMTP id F23D914003F for ; Thu, 5 Oct 2023 13:41:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cuCVAU6k; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of zohar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=zohar@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696513312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R/QTM1fzVv6cm+wswFVzDr/m9+FgX0LQuY8/jeKmhko=; b=po28F5/FE7JVNeGg7Xd2C7N7gKnU7RLLlFc62cZmpcoadSE6U8vMKBmrMPbX3ab8UX17qA 1EHHjU8teezgLSAe2OReI7Qhe+Qysjl4BEuIgayc5F1u+iyAEXLGGCBkvtds2n1Re9CQeY CgM6zS/GqpUb20e/yIi5romeWZnlSbk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cuCVAU6k; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf09.hostedemail.com: domain of zohar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=zohar@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696513312; a=rsa-sha256; cv=none; b=8DvnFGqGMmPMEwoUYLpLLs2MWfsulvaOLXKWpxiNaVahnRt508KYJiaATJ8fdxuBeVzSCD ULQ5okaK/s+sfWuNfpGGjs/giamCwSHLWpaEVeMI0dcoigsFJ6q+gM7cq4LbyEsA3vN7oF lHB+SrvqACvRPp4VvEkHqSwqB8uV1WU= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395DQhjE031548; Thu, 5 Oct 2023 13:41:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=R/QTM1fzVv6cm+wswFVzDr/m9+FgX0LQuY8/jeKmhko=; b=cuCVAU6kZBORw4kNzQM8QhKATzaQYQx9sq9VyXtyAcbUjSJlu2csv9UKwRsMdWToW/kZ 0C0RhlLfSx4clzeAM9kri0/U0zoNlTG8RblVDlrVkUr8EElTobyZsMXrLACmhgSCyeNj mwc7IV+kj/e+X5u63Eo6l2E8JPclAG8R1FP1Mai2lrKjyos0n24UwIr+NGmFo5l/dmCQ dGyPtibDLCjR17Zb0bp+IBJPg1LpSIU+tL/CMmv8D5xPmvorNRdNYuKpBMJSXVYh1+lJ yx7r7YcPGH6+f/EQTT0ey3+nrJjVS9Dgplu6YZos1rGIOPl3jrrD8md/aNUQm4O8WJSh nw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3thq9k02u9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:41:49 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 395DR6nD000477; Thu, 5 Oct 2023 13:36:47 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3thq9jywwj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:36:47 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 395BKrDl017644; Thu, 5 Oct 2023 13:35:43 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3tey0nuqkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 13:35:43 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 395DZgnd64356738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Oct 2023 13:35:42 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F204A58051; Thu, 5 Oct 2023 13:35:41 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4CBCF5805C; Thu, 5 Oct 2023 13:35:41 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.61.90.188]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 5 Oct 2023 13:35:41 +0000 (GMT) Message-ID: <97be76d94fdacf369a324b6122d5f5bc19a3838c.camel@linux.ibm.com> Subject: Re: [syzbot] [integrity] [overlayfs] possible deadlock in mnt_want_write (2) From: Mimi Zohar To: Amir Goldstein Cc: hdanton@sina.com, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, miklos@szeredi.hu, mszeredi@redhat.com, syzbot@syzkalhler.appspotmail.com, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Date: Thu, 05 Oct 2023 09:35:40 -0400 In-Reply-To: References: <0000000000001081fc0606f52ed9@google.com> <25f6950a67be079e32ad5b4139b1e89e367a91ba.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) X-TM-AS-GCONF: 00 X-Proofpoint-GUID: SRYz0AUECWsolMMPvJe_2XVNQ0vgpjPQ X-Proofpoint-ORIG-GUID: 2cgjxh7a4g6A1IxuXODZIVABZC_A6upp Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_08,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=642 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050107 X-Rspamd-Queue-Id: F23D914003F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: tjyd6dd595rk6zk9hssgt1depg9gzdx6 X-HE-Tag: 1696513311-313265 X-HE-Meta: U2FsdGVkX19gKieb3l89JswGCTMmtYK7O/2fE32fqTOcWE46JP0kCRA2+1Rdcxf43APCWqYotvETDsysiJlVUDy2U3cfgF8TNjpiegf1GRIJm9QvDV1e9cBmTjWUnnVPmAJx9ELpEXO5RSQREiTAxNKcJhGHjQhJG9debMZL8HpIk5MlrugTIzjyeJJuJb+PO/zgZg8DhSKVugyudww9jerIL9O9c1/KA6YwUFDwR3L+gyNiiPgODxZFQ0myWBmkh0nruOihMHR9E2MK+MxoRd7Ks9xHYVDiXselrK0agp9NG6WbF7172Hx4EFfH0xSVGn95xKmPtWAevfDrZ5BJPPoxbGEZzLC3QYTvecYrMePciWZcDk92n0B07rdvU1EPz5xxymKV15ROQdd3XJbccp2V/vjiYBGWa6hKCWGfTA33jIWvclBak75e5uMujbRSu7F3RmRE/CzdlKYs21GFoIKl8Lq/cBm0tu+lxTRIp1/d2C1goc9/JTrRmIDnS0W9/x+5/JKVnVuykvZV2d5Jc4Jti6Hmc+GLb7zPPH4hUi4elYcQTbENY7W4kcCl1pGZePFsOJLhCoyngRnTXsifQ2Oqqrm/iQFmFA5YT0z+mK83A16qCR51zPiC6Hf+vyvL+4ChhR5Jedq4YHcKGt+K8Z2FaecsUuJu9Xu9f89eUmxkNcK3NN6wYcsrQue6MHT4sDIYHqazEDNpP2BC8h2I1BxRmRhZNUJ4CiySc9nyTuoOF+WybcDxV12gWT4tjIgFuqIwEvMIPSzWmDhWHQnLTggM3+pvZQ31K0MAHah/nB9HjvJmANMBASM8GBxK614+vgF1clXjFDeZ+whAKJ+beA1eha6RG8tPUvnuSYakbfHECPjq/kHH3wllUlqFdh5EAldUReJc26k8Rd2BjP2oHYy6oNWds5onPSNnv0BK0E3WZSLj+6lEiupze7AdNYq9D4kZBZGuKEu5bBIvp1h Z0P4KkeX dfXRvaWK3u5udyjmluPoVxj6xE37PkCvYfpCZR9U1d76sUEOqyziob/0tePc6ewhmkxVq/qtkiuha03a2AMsVScSU7Sc/65Xf1MFjzSUtEHjVZ/vRCnaepx71a7s1SSDM8pFFfh/Hu2irquIVPHYpX+A6IgFAEMhIxr6Bk+vb9A9c/DbVmYL2CtwuXIJalJXLY34wHe+v0E+MTJ3JJUh2KZMThtEJJW1bAPrCdFrYYfFCjjM5WQuwq6w7vcTK3e0uGETpfgwvISJ3x0/Vp36G5avFYyIp0/RW/qRE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-10-05 at 16:22 +0300, Amir Goldstein wrote: > On Thu, Oct 5, 2023 at 4:14 PM Mimi Zohar wrote: > > > > On Thu, 2023-10-05 at 13:26 +0300, Amir Goldstein wrote: > > > On Thu, Oct 5, 2023 at 12:59 PM syzbot > > > wrote: > > > > > > > > Hello, > > > > > > > > syzbot tried to test the proposed patch but the build/boot failed: > > > > > > My mistake. Please try again: > > > > > > #syz test: https://github.com/amir73il/linux ima-ovl-fix > > > > Thanks, Amir. "mutext_init(&iint->mutex); moved, but the status > > initialization lines 161-166 were dropped. They're needed by IMA- > > appraisal for signature verification. > > > > iint->ima_file_status = INTEGRITY_UNKNOWN; > > iint->ima_mmap_status = INTEGRITY_UNKNOWN; > > iint->ima_bprm_status = INTEGRITY_UNKNOWN; > > iint->ima_read_status = INTEGRITY_UNKNOWN; > > iint->ima_creds_status = INTEGRITY_UNKNOWN; > > iint->evm_status = INTEGRITY_UNKNOWN; > > > > They are dropped from iint_init_once() > They are not needed there because there are now set > in every iint allocation in iint_init_always() > instead of being set in iint_free() I was only looking at the patch and noticed the removal. Thanks, this looks good. Mimi