From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45969C7EE25 for ; Wed, 7 Jun 2023 15:45:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B76EC6B0071; Wed, 7 Jun 2023 11:45:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B27056B0072; Wed, 7 Jun 2023 11:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C87F8E0001; Wed, 7 Jun 2023 11:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F4706B0071 for ; Wed, 7 Jun 2023 11:45:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 43B10120307 for ; Wed, 7 Jun 2023 15:45:36 +0000 (UTC) X-FDA: 80876376672.20.6BAF616 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id D5EC7A0019 for ; Wed, 7 Jun 2023 15:45:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OiFEcgeM; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686152733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WmCSirP/uxnPSNlkT1l+fq1faJ8Vy9bVgc0QZjRILzA=; b=x9mIGeS2UdrCyF9U5jMD7QulVN1cklC1iUJru5wlbBw/MDLBdP1oTOWmwh9YkIIVpNnQ3/ dPrN8uiVYZL983jP0B8AjabN5oqwmuKnmFE2c7mxeOWhraAp91DkdUItsJVTmdgjlXu84d C5y2nhbgF0qK7+kLBfQE2lsQ52EG0nc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686152734; a=rsa-sha256; cv=none; b=HMoroL94z784jEukygY6l8oAKjQwlh1TILfcy6fpVUPngH/UFHGdYMvd3QOPLe9E1uZJou ZVH24Fo1AMx/8MqnTrmh1i3cF4CeteFhU9o/0I6XNZg9i8fdFlzTMpz5eVqKJjQKDb2LJl r8ivb9bh52Riv4iLDs2Obxa3Z2yZas4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OiFEcgeM; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686152732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WmCSirP/uxnPSNlkT1l+fq1faJ8Vy9bVgc0QZjRILzA=; b=OiFEcgeMzhpx+R4h5Hp1GH0xe0focssJ2wxqY3tTKsfHKFhcX8g9gyQ1jcLKfaHZGKdx38 qG3G0TdY+sHKNFCYhCMFHdUqvGz8U4A76i9DTKv3B+EI5o5p99/4iX6+JFo4UoCz5dSwZ3 j8lrIJhC8x8t0uOeKFlgt+0okmtOlBk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-bWLwk3ULOj6-6DJuphJPYA-1; Wed, 07 Jun 2023 11:45:31 -0400 X-MC-Unique: bWLwk3ULOj6-6DJuphJPYA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f739cc1aafso20305875e9.1 for ; Wed, 07 Jun 2023 08:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686152730; x=1688744730; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WmCSirP/uxnPSNlkT1l+fq1faJ8Vy9bVgc0QZjRILzA=; b=FoV/P8EuOvhiZEdU4j0lJSzv+t7rJFOqD7cWgacPLH2EKxCXFMo3L1rPOp/ppdzl9A kmFU3lNrlV8KiShj4vJV9RdIqsGWnhTujGTepKxWmfIxMWrbjt4pn1147aKy31CAFqP4 sSKPkPkoNWrIMhXwniaSJeNYWOshIFixo7G2H67Mtht7WIEZQA+zz0O3OXk74FR/9g/B gTS/P0fflzzTxciyrcvQW3BYWgC3sL9YBDPZMdVN9Re9gvHtfSwp8GYBDOb/UhLaM6Ib G04TmkZWPbHDFrXviynVN8vY2i7kxrze0kL6sTiweCJjt/rwZGhTcA1v4Boao6ftiUVU zILw== X-Gm-Message-State: AC+VfDzeLHt5mMbHNRpRfPqfmBVmX6iV88BUG9DBpMfKnrrQ7zdxM0V6 fng2Kp+Ilq7U6FwZluC/RJAHbU9AcN224ElxTPCXYoBS7Dj08UneDn+pQPZidtR9zarTRtFf4Gd LFsmEW1O8hhY= X-Received: by 2002:a1c:740b:0:b0:3f7:f5a4:1f95 with SMTP id p11-20020a1c740b000000b003f7f5a41f95mr142225wmc.18.1686152730301; Wed, 07 Jun 2023 08:45:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FaFQN/GNNGZTokhRQWAHWMqnlDhi4xKe+gXZoDnfcpWheIr6e68L5//L7KFdheo7GePJQ9Q== X-Received: by 2002:a1c:740b:0:b0:3f7:f5a4:1f95 with SMTP id p11-20020a1c740b000000b003f7f5a41f95mr142209wmc.18.1686152729932; Wed, 07 Jun 2023 08:45:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9c00:8d26:3031:d131:455c? (p200300cbc70e9c008d263031d131455c.dip0.t-ipconnect.de. [2003:cb:c70e:9c00:8d26:3031:d131:455c]) by smtp.gmail.com with ESMTPSA id fc14-20020a05600c524e00b003f61177faffsm8660506wmb.0.2023.06.07.08.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 08:45:29 -0700 (PDT) Message-ID: <97b5657d-e09d-b3a9-c09d-eaff9fb7929d@redhat.com> Date: Wed, 7 Jun 2023 17:45:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/4] mm: Fix pmd_trans_unstable() call sites on retry To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Alistair Popple , Andrew Morton , Andrea Arcangeli , "Kirill A . Shutemov" , Johannes Weiner , John Hubbard , Naoya Horiguchi , Muhammad Usama Anjum , Hugh Dickins , Mike Rapoport References: <20230602230552.350731-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: f15ndrcx5to7bfkjp1g7oik4yfiy7fbq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D5EC7A0019 X-Rspam-User: X-HE-Tag: 1686152733-725998 X-HE-Meta: U2FsdGVkX1+DPGOErohStl77AnPI/QStIAPBcJDPZG7bHg5R13O+Nl3STQbX05faDehjcZXsXYmFzKlAn/nEiYZFHIavCYYsAlZF3xMFZ+j00xvlkYarhTK+9VSykE4kNhXn/YUUBnu1Wcn3v8psUWuwaZ02ky9D09dEZ3pUx3KNqJy8nWBqhHM/hpMzU5DdixLAwGTMz3jRb/l6s8mO2eMUG0W2kwg8igMoR07vk9Nk6Whk4CGt4pnX95SbmYuZmctCmz1TzqHBLJCoERAPocPEzPD49eWuNbj4LD3ikV7fojnQ2UlyNWMNzULSQ/T9O76N2Chit7AdOCDgM8fzLj5Rry3b5sVRL+Ux+8h3RP4Y7DUi6QB2I1xbwCBoAys/lwxkJQ2sO0ubulhF5Td+ZyjLd63SPS7fJrCqW5MjjPRT7KxFx489twuFwOSYo6l0iK+PB2MSBj1dZ3MgE/4PmfjNjER7XNmT8IrV+knN+179iGgDnrptfVGaQWR4U8EBW54N1xtqdseJgxGGDqfh8iLb+D14t3kqapE2v9HSCSLVN/TT9W2uypOlyu/dsS73/rJoDP2yLazNi0PB76kuGHFYh4xwxzTXtuwfqKhPbYYEV7MARnQh/fG9+BlXBfGACILdnUHm4pgHaJ4axTs8B1SAuESuS4RtLPo2YEm16v8FUAJfjQReNNTvlUD2T0nBP7hLEZK3kB1djzkxnu7qi8B9OkuaEGoIndT44nQ+91biKueHfykw4g3IPnoZecEaazU2nEE7DD390X2PgH6kCv1lcKDhWDEwokUoPNTj+j2YXuxGWZctXDO2i9LT4ceJ6eP5IkQsWy7sEMCeXoQWE5wUmXyhIK7uNsq8VgldlLMizJrtwe25bcpAzj0fSqNFd7+XH9vhB/iR53ZMmth3RK38sZPvlR6vPUVCx8wUExTSoy0CCa/NvSxwZXW2Ijl2M+G7mLHs/be59v6OaBI 3F7lvE83 S/rSwkYlayG2FQM01ShKDMz1JvhBwqd9BtqUiPvnHFgFw1Ec1wkCHgET07c6pl8X3IZnIxJQ4EQr5l7eNsl4UYbe6SY200RiFadEA5ktN1UrYBHVZedsjyaHwQx9bVZ51zT5+kq2DhFX2PTCHJx0vLtP+hXe0X3jA0w2fMS+U0q9zHnX+1SZTM2Bz87MBsHHotXp9yhWiCV8cDHgmtkPARgMVr7eqQCXP7yqqcffIjylB5eZBh+l/92UcE800mu6QhTT3HB75Bi8BBl6Jel9j1/Ydrj0ep/yVtCfpLFObnH6a/jHJuyE7oSf63OVllkrumhP/YkP8mxu224HFYiwFMDcMatYMF1J8A3BsRjDGN+Yd9TXYnCKytX2FJK3PORLegxEWs7LggfhQZHXF+8yZErK/WbMXFTMkHGaGt3zBYTp9PU0BrpJmdjN0YQ8KG71c0JmK271rC4JfURw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.06.23 15:49, Peter Xu wrote: > On Fri, Jun 02, 2023 at 07:05:48PM -0400, Peter Xu wrote: >> Please have a look, thanks. > > Hello, all, > > This one seems to have more or less conflict with Hugh's rework on pmd > collapse. Please hold off review or merging until I prepare another one > (probably based on Hugh's, after I have a closer read). > > Sorry for the noise. > [did not have time to look yet] Are there any fixes buried in there that we'd like to have in earlier? I skimmed over the patches and all read like "cleanup" + "consistency", correct? -- Cheers, David / dhildenb