From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E36CD5BC0 for ; Thu, 5 Sep 2024 13:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7E7A6B030B; Thu, 5 Sep 2024 09:13:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2C606B030C; Thu, 5 Sep 2024 09:13:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857EB6B030D; Thu, 5 Sep 2024 09:13:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6698D6B030B for ; Thu, 5 Sep 2024 09:13:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0E0841601E5 for ; Thu, 5 Sep 2024 13:13:27 +0000 (UTC) X-FDA: 82530726054.12.08657E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id ABE4B40009 for ; Thu, 5 Sep 2024 13:13:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ayzk3Ysp; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725541956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AYFFhAYGLWjIKXe/lp6WVXnfENFxMkNEag3Fa1KXCQU=; b=aISLCrIg6AFU+QiH6kEw+02IeMwW11OyDnGaHE+Mv6fXXWIhdyeOv79Pa43buL03ogv0xn 93SaAjIOkgZbDtWcb/nDJU187hQECcEkZkxMj0XYxKccdKeEZrD9tTXA4O+Q5YZH8+7LJG UKk+kYnuq82zRp63b1zYwYmiMKefsvw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ayzk3Ysp; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725541956; a=rsa-sha256; cv=none; b=XCxsbEFpDeprFLcCiwuZPVVSYkt+6qyqf0yzSL/ICjSY0t6cucnUY/xC1XKiTx6mTzqDGt PWO5fc8vKmLegM8yvzdfXZGaURx+r0tCpPvOMxYycsaSI6N4y9Uug8nNd9NaGRRlOiRBqD xY4aNcOYjqcik6dHgjndd2K+UCR5bjM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725542004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AYFFhAYGLWjIKXe/lp6WVXnfENFxMkNEag3Fa1KXCQU=; b=Ayzk3YspU47p9NAns4u5OiMkC4/tgKah51jSrvqEiZimSaZWSOGkYQv6YRoR1JjRICFUOu zbiA8plnXySL53o3tPku35PZtNCBcAJxpB9fUbM0aivG4Ij1sT/KrXjVgzAZNxyE+crWhE VI/3DnB+oAgQl3PHSez1o/2nCL2IXgI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-ZQ4GLjZEMZGvIEYV-2FaVQ-1; Thu, 05 Sep 2024 09:13:22 -0400 X-MC-Unique: ZQ4GLjZEMZGvIEYV-2FaVQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42bb2899d57so6835855e9.3 for ; Thu, 05 Sep 2024 06:13:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725542002; x=1726146802; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AYFFhAYGLWjIKXe/lp6WVXnfENFxMkNEag3Fa1KXCQU=; b=ibjM6Lu3u1Evj/5T8O5xJ5Z/+q69Ymv+7sRpWUi3SK8nELz1oy7oLJpULVpXKmLrJO hmJCVoPxfUUWBy1nM/lvwHCLMMiUCpkjIfQCgtQ04ymLDwrsqnxvejJp+AwgLqlYFyIE 73bwW7Eqq6SmIibnb93QPV+xtBZuq55j0/HGsu9JE5lwDJHutTI5akovN0qhkENZqpfu ihxd1gQ37o2Tt7z4//9XZOnWE3AmWXSDCKZbuN4Rd3wjZNYpZkioZE6GU684z8+Vj6YA 05LUlPrWWoeISxuqWq8uBcJA71FZJCDQCAxiI3gQJCut+TnhFj09iQK8QvmzIIpLc0le zViA== X-Forwarded-Encrypted: i=1; AJvYcCWIO1j3Hf62VY5gzn4lvskixj2OTHGtvSYAnpFnumiEegGXaW/e98TbaR+SBjXc+lUHu0zDIjIO5w==@kvack.org X-Gm-Message-State: AOJu0YwSm6h2WupMfzHFfYboy3a6ZzFCgWAf/XXdEDDY7h5Hs4fnbcka gZXAnfgyI6YqMuI8Ez6pgJH3t7HswKRfPmZ1ccN2QGsWB82pYYbHKbrRzRBLFuuZJo9ppp7AOeX 5ZSmZE/MTNfpNC/60u7A7xbqQK7htFWAWMyq24hhaPPBiTYfD X-Received: by 2002:adf:f106:0:b0:371:86bc:6c05 with SMTP id ffacd0b85a97d-3776ee902f2mr4076210f8f.10.1725542001660; Thu, 05 Sep 2024 06:13:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFvik4mz7clc9mCfUKO1QM0VVLKwna6dQQ171Rn+bRn4aVk8Yt91uTdDtZdVji09pzCcf5IfQ== X-Received: by 2002:adf:f106:0:b0:371:86bc:6c05 with SMTP id ffacd0b85a97d-3776ee902f2mr4076187f8f.10.1725542001081; Thu, 05 Sep 2024 06:13:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:5400:6c12:d0e2:3757:2963? (p200300cbc70854006c12d0e237572963.dip0.t-ipconnect.de. [2003:cb:c708:5400:6c12:d0e2:3757:2963]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-375f59f3d5esm7342495f8f.96.2024.09.05.06.13.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 06:13:20 -0700 (PDT) Message-ID: <97a56b6a-bafa-448a-b082-917b7f9f30c6@redhat.com> Date: Thu, 5 Sep 2024 15:13:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm: move bad zone checking in gfp_zone() To: Wang Yibo Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, trivial@kernel.org, wangyibo@uniontech.com References: <50595531-87b0-4420-9624-948810066a6e@redhat.com> <20240905104808.27528-1-wangyibo@uniontech.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240905104808.27528-1-wangyibo@uniontech.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: ABE4B40009 X-Stat-Signature: qqf4wg3a3ftg5a1wfbo869x1s1i3igza X-HE-Tag: 1725542004-238609 X-HE-Meta: U2FsdGVkX1+wDPD/mlI7aXeNPD7utzqoOCWeoMQSf4h+hvgCK5nJOwz5Xq9n2wy4Kz0ZVVhiVu4l+snyX6L6BPoCJSsjXLg752XH+l2vUcF8sh+OMCMb+NJY/aOniFynkP/kw+5wf4qM6BZnI7Y+ms4FbpRxG5QV9qTZmwZEZKsjRG0KeIWeSgSmBHJspEsfuGMpwH41AXMdZM4Up/cOO5ozjSTjW0ZPSOEgAyzQImQlBhy8+sJgzPXAvXxdjCJj3ZGbLD7oZkFsd+qxexgJdJsr5D52IL94CL8U1KnVzsTYW74+hJLy9T3/ihRIacMK1JhMekLSNSydRhzpunqbTyq3fgbKDBF9G36ZDyTPf+FYfCSp2PFQlWVYopHtorH7OtZ7uy9ksTP32is9euOkz7elx9+SCR477MyRjmHrEtjxXRbiTjozQZbrkNLKNZjVzToRNu7vpzj5wCJYUjjGoQV9dj5mAcNNeWgkRnfaNk42SGFg9g/1brIWbblRg/2FibNzbW4ngyYYchOtHRp0QD/1J+4+BKbSoTGtlzOs+jKbUF9FWSu26x72+uHKGLPj78k+FlFhYVWYAwKeFrrKlU7+p9dZzWnbd24yDQvsC9RrdIYFdiPDWxN7TfCT9nFF9/H76dNUpPR2M+hKDK6xzps3hnoKyp0wCvFwqSjmXlN6bvf2piJmR6khPekVZyqNJwkm7PMggEaO+7aqTEtOpDFJe9EPN1P/X2DmSTp9auBpdee2tbzTugaShZApmg4RF+XkTJLfwP4cpQq8TL3xfJ8Zsl42BHqLKLnM9C2QZS98hOBfy1kqHE8QMXYKEYFpomSo1qlBo5BItbmcy9uOLTdBUKCBqQtFVWavhTHMmWanUpHdtVA3pVMf5nY0r5NaoTI0x5+n7LoFZEWvJVRNZkSITC/1tYNsf/KU0TUrJxaj0Idwgj4yeXsTx89iP/T6nw50aZ4/1L3fShjTXww nJVayCOX ofQZQ/Enbpl83m+U7/7oKv2XbXP3CLwKJiy9jxW3WpktU7IJvK3CyPgsbckkrTQN68Zf2bz4o+kH7JVaoVvT/vcYdkMTw87ak0tLOaD5ATpcNoXl7BwX++0BMKQwwcArQrYkaL48cMbJDCakKC88v6swBk85WwF3xeDfoLEtFc2pyge8XoDM+I5Y1xfJmRbf3mBDwj4n8vuLDX/H6zRo40c6NDfIrXWpgf8sbKVSnrJYpFp6wBs7Lum5pcjMocmKXPFThbZTLJFilAlUHxx/UE4FWCOcoaCXBB4vAwxXHR5Gsi8K/4UTMx35uG2oCX5/pxrvkPz0pTCh6vGBEtgNjCGAH6B6OEn7riOEl5SFXdFtD6bMVmLuN4uIkVCGgasUgBuZ5RqiL/ydqq/EqH8O4EhraOTjLjLLn66esOA9nRZcJeJg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.09.24 12:48, Wang Yibo wrote: > When flags in gfp_zone() has an error combination, > VM_BUG_ON() should first know it before use it. > > Signed-off-by: Wang Yibo > --- > include/linux/gfp.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index f53f76e0b17e..ca61b2440ab3 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -133,10 +133,11 @@ static inline enum zone_type gfp_zone(gfp_t flags) > { > enum zone_type z; > int bit = (__force int) (flags & GFP_ZONEMASK); > + VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > > z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > ((1 << GFP_ZONES_SHIFT) - 1); > - VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > + I'm afraid you either missed half my review comments or your answer to my mail did not make it to my inbox. -- Cheers, David / dhildenb