From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAC8C05027 for ; Fri, 3 Feb 2023 13:40:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7B4F6B0072; Fri, 3 Feb 2023 08:40:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D28976B0073; Fri, 3 Feb 2023 08:40:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7BDA6B0074; Fri, 3 Feb 2023 08:40:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0E756B0072 for ; Fri, 3 Feb 2023 08:40:04 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78EB81C617B for ; Fri, 3 Feb 2023 13:40:04 +0000 (UTC) X-FDA: 80426089128.08.4F8E8CD Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf11.hostedemail.com (Postfix) with ESMTP id C7BA240010 for ; Fri, 3 Feb 2023 13:40:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h35fiPDM; spf=pass (imf11.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675431601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BsZlOigTF8/USYkVmtVJE4rnGpoZIHDMiNF7AXJOMlM=; b=MVD/X5MbzRj69/3LepnDy1d0/1X7/Jhr2kZp8mFOgYg7sXgmRpalZU7w+NvoppvYn02wgv rEycN66bQMAoNB9gCZA2pMzp+UYGbfgXlVa7RBAE8zZ641t4bLElGwu1bps+2mYcCbp89+ JnGm/ZOX0HqGAtwKNVDVGRwbYEXmhww= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h35fiPDM; spf=pass (imf11.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675431601; a=rsa-sha256; cv=fail; b=3X1gwxxmtKZAxyLegbfx9optU5a/ggbldKSmx4W4A9V27sqI+u9h1QNTGS6q4hPAwH384H K3LpTiMCF3o94e5+4jysSh+RxxzKpOilzOfnvVP8VVC/hImDWZUhQZsRRy8uR+CEHodReq dHY7THyEwVzIE0WMhCDMvZ/wg/IQoCo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675431600; x=1706967600; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=kVFlWo9Ms9IpjnhXqA0QhpDSgKJ2tvlaJSqY6p8dMdw=; b=h35fiPDMH7hWQIIJgl1baJZabVYT5Vi5Z6I9/44eVQjMS0WgWKxTBzVw jAQaO7B8YWi3l56V+DHh3mdFNJakQ0VRydBZ+vMVvb1Lt+IU+tUtQJWHU S+dqKnRrp6l9UbCx3fRyj50a2hpN4HbuIpOFSAgfnnT0EX8FJ2EGVdtpK 2GMyejJYIrQ7Jm+6/olzDuPVORLxiKdYNqcXR0JT65CYhk3/KjxNtcnKw xMaKQ4QtuoD7rEVZjy26v60YQCc9PAut5FQt1P1rvI/ow/7vjMUbjwFEW 4VsnCUjEUuxLFu5W8UCvvpkJJquiX/oo+rKY1ImeT1kZmbj5gFPxsZD8N w==; X-IronPort-AV: E=McAfee;i="6500,9779,10610"; a="330033770" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="330033770" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 05:39:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10610"; a="729260048" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="729260048" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga008.fm.intel.com with ESMTP; 03 Feb 2023 05:39:59 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 3 Feb 2023 05:39:58 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 3 Feb 2023 05:39:58 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 3 Feb 2023 05:39:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQ12hzRoFXXHc3u9N8RKeIvp0HEEinnXbQZzDjOwQiFxjyCO0vYBQGKMqkIarGnwrFiq3rlUMLt5tzHNB5BKktAI8MJFWKRQcuivAkfOSHf7EIpETUNCZXZje8cvbvgsdrFim4X3NWWpikfUtxDpVhw2GudBp92fVhBLmITv5kOCQMrE/0eOP3Px0eXW58/soUzPO9AoIw/2q8atNYdpezzrDZ5Ea59pKWy+zMkL0Ru0xQIf15vjFc0ICiV7zW5IEpkmeyDUJeEIkR/78FAfq1F+fq4PZV6bgqiluLNHGA1VDB26fd1XI/mnyAtH0OM9ISgLIk/Pg4CavaY8QuZxnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BsZlOigTF8/USYkVmtVJE4rnGpoZIHDMiNF7AXJOMlM=; b=LBxPCzy7eVYXFDbqc+O42XnFOL7lCO11WSrRheFERnMxQCt+T5WE2oqjfeGwfEzLzwJx0+BQdUnaK4FBmiWjErlOSC0ZMkuQhvZrCZTvGgRFNDmrDGJh5pcNqbWAnh6VvLGOkV+pDRmjJdEkarFu0JeT1qSUOEBD9vK/x/2D5Rmaqpu3VXUMEywSGe3hqRyDZfIpxg1q2YZ4G2NFSMHQ7NQNnPPgg705ga34xrXyPVh0eYUHAL8DHhcwx25o3O7cL+P9cITBjj3zT49wH1D4o/rA/x9UDeh+HeGU6ZfrbI4EteP8nIAvMzbsnU1s6Il28VnsGzKhDbzKwRNpS85MYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH0PR11MB7541.namprd11.prod.outlook.com (2603:10b6:510:26d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Fri, 3 Feb 2023 13:39:54 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%3]) with mapi id 15.20.6064.031; Fri, 3 Feb 2023 13:39:54 +0000 Message-ID: <979404a6-0bd3-9854-448b-0d5a4312a95b@intel.com> Date: Fri, 3 Feb 2023 21:39:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v3 3/4] mm: add do_set_pte_range() Content-Language: en-US To: David Hildenbrand , "Yin, Fengwei" , , CC: , , References: <20230203131636.1648662-1-fengwei.yin@intel.com> <20230203131636.1648662-4-fengwei.yin@intel.com> <5c85d6bb-f4bf-1969-8ec3-c16399e5d6f2@redhat.com> <6ccb2392-70fb-5135-d61d-c79aa82b9276@redhat.com> From: "Yin, Fengwei" In-Reply-To: <6ccb2392-70fb-5135-d61d-c79aa82b9276@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0008.apcprd02.prod.outlook.com (2603:1096:3:17::20) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH0PR11MB7541:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cc8bd44-daea-4d04-4a1a-08db05ec21c4 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kg4rJueex/1Ybz/h2HxVStshBEjU49dPVFlgBjKftrkufhwSoUtb2aNGEZ0uy62/fpg/N1+evWZzhE6rOYflGYEfXrNiD/iJaEzDozVxVVPULSkJkpJzhKAc5EM1Donsgm5upGVV2W6PwsWh0R8JK3RHSt85KKilCHLWeFGTbpU/tWqkp7fZzuNZdiRJY2wVL+dToKZ2sNHzm5ERX6RxI+H+ZXk6od0odourveBqSFTZ6HolkAD8YPfNiWwPINQWOAsclp8uwu1N++td1dxE3Hhdnmj1jOCKZHLsFhgDl+WTsZ44MYMgCYvNdn3HEXK6pPa7fN+SvCG8hDfMIPvgBCliGof9HV96czadP5rLr53C8HU9gQ8McWamxIXcaBWYG7YX4FJAUJltCX8vL3mvoCo9X4EYeQnRtzNSjETKV1Kur/p9r2BsfIvXkM41nHEgYSynEGEKbwA3RBDFS8GgWtw/vrjZGyfZzo/G/T4HVtL2/5MJGGrNfAdwS0a/dtXMfEaPotoqf1pE8OZY7n5QijnWmgpW5qe4jvMiZpUDhrnicNdOXlpVN7XeIsiAgQ13cb00sNoc/HbWzfLHbg+bpwAM71j3gLzuLH5JL1/HSfSQFQrfN/jEcq/K66nlseRuLB0TZZlunJxefYRYexSj3zKRCCIQCFBddCVq7/zbRYWx4mrfE1W/KbN+zXs2wWVbwXqYACA8HpRN5N1yAwJsbLBwoda5yjqOBaOvNDEmC+I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(346002)(396003)(376002)(366004)(39860400002)(136003)(451199018)(83380400001)(6512007)(186003)(26005)(107886003)(6666004)(6506007)(53546011)(2616005)(36756003)(31696002)(38100700002)(86362001)(82960400001)(316002)(110136005)(66556008)(66476007)(66946007)(478600001)(6486002)(8676002)(2906002)(41300700001)(4326008)(5660300002)(8936002)(66899018)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2lpWXJ2OVIrbE5velFLSnY1VTFCTG9FR0JxTjliZmduM3BCMjNEZlFyZkVy?= =?utf-8?B?VEhsZjlYeEZIRUJ2OWpLWER2QlllNGdSVWl1NmE0RUFOdnV0bC9SU1ZCTms2?= =?utf-8?B?MFl1bGRYMlZ3WUFOTkVPUjlxMitxcDFwbitWNmQ1QlRNNUtJVzdFMy9UNVda?= =?utf-8?B?SGlEVm5aM0VHNGdDcFJYcDlleFdmb2QrNThpMXRQQTNKU1NCekI2ZGd6V0N1?= =?utf-8?B?c2o5WGtGSTlhd3ZNR3dLM1A5QWhEMmhtcnJSanJmWTY5ajg5UStWV2tvOExD?= =?utf-8?B?N25zVkdjbTlOZ1BCaGE3WEdTVmNWaVJVUU5US0pORFFHYXNxTVY1RTR6a0Qx?= =?utf-8?B?MVlCTnl2blN3UlIxc3VzUytDeDFvM0lnbW1tNkRpbFdCSWNPU09tRm5ndC8w?= =?utf-8?B?RUJJdnV4YUVvSVhhU05FV281VWZVc2FPazF1UlBuK1BYd3pJd3ZOdzEyUUJm?= =?utf-8?B?YzQ5WkZRM3RNcnlaV1B6SzliTFlEbVA5R3pkak1tcVJ2czY1Y3RPTHR0RnYz?= =?utf-8?B?cHhUb3NyQlpiREs4cHhEOXJEa3dIbVdhTXVQbjMrUUdteTBocDNFY3RqZTdH?= =?utf-8?B?TWdPUDJUdUNHKzd4dFp6TCtQRkhXN1NONnBRclpGUmkrQXZJWEFOeENnM3pG?= =?utf-8?B?WFJER2hKY01sSGJQbDE3MFlNMDhGcjdITDhobHpvVGdiZjdmQzRWNXA4Q1Fm?= =?utf-8?B?a0dsQ0pEaS9UTTdtUk8xbS9LbXVVRm9yWEoxa1lFK2ZZcStmS1NVZ09hUUdG?= =?utf-8?B?QmVzR3M5dFJwNUVYaE9ucmdPczRDek9JSVpYN0Uvd1NVMkRHdWhSSVg2ZE9K?= =?utf-8?B?K0pMd0x1RzJDYXZyUUxTYlM0TXhMWEJaZkQzT05iK2pOMTBLS05uSVFydVFN?= =?utf-8?B?bDIxTG9OWGIvTGQ3K2FFUEZtSUhqUGlQS254ajVMOXlnT054M2xoMHduWmhW?= =?utf-8?B?blh3bFFFWmovZWIwaUlRWTE1Y2dIT0Z2ZVlOUTFXWWF0TWgrb3RXa2c1N2dR?= =?utf-8?B?Mjc1VUlYRlZpOVZ1NjdSOXAzVFJTUEZ4ZGpaRWt1cGlkZ05GbnVWeFB6emVN?= =?utf-8?B?R1RXRUJSa2IyV3o0dVJkYjliVDhDdXNDTXg0WE1kaGc5Y3ZNQzZFOEEvZjZ2?= =?utf-8?B?M0VCMnpqWE92M2ZWcGovc1lwR0pqdVNuWmVLcnpVSWs5QXdZNWVYZ2tWZ1Rk?= =?utf-8?B?KzdlckpXNGhYaTZ4dkw3Z2NBWmVmUWJHQ1hWb29sb1VJOExTTTVvSnlRdmxN?= =?utf-8?B?bm5kMExFVkJPa3lidno2OGZLVjRxOVFJUmNHTVpJNDdXK0R3WDdmYVFvZk50?= =?utf-8?B?NXkzNHZtTWxZdWNQMU0rR09vcFFzcWowVFQzV0p0Y0V3ZFhqbE5tM1AvTDUw?= =?utf-8?B?WFRpZUt5ZzlvTFNWa0VUK3o0LyswOTN5ZWh1S0U0YlZ6UE1GcVNOUk1pVWtK?= =?utf-8?B?clRIekkrOGlzWDl1NXBnOFBmeis3eFpRc3V1UXRWSXBZejFKcnhxUXFVcWZI?= =?utf-8?B?dSswak11aGVKWDJZdXZTcmZ4ZjVHOThoUFluL2pFUFg3MDQxb1BkUDhCdXRB?= =?utf-8?B?dnZLYUJOYi94TGFKQjFyTUdIT0NjeFpaZVlWa2hZb1I0VjJQa2xRbmprNjkx?= =?utf-8?B?VWVZakpOZno0c2RQckJJc0txMFFMblVPVEFlbWxpQkpKMVhzRkZLcGVZYWU3?= =?utf-8?B?SVBZTEdOK0MrYkwvMFhLRmlzZ3hvd3FtY04xNjZWUWRuVzVLeUg0RGdaK2Rr?= =?utf-8?B?aURkVEZ4L09mTno0dHBrMGluVTJMZGdhWXVvOXVtM09VcEE1SzU1OEI1Nm01?= =?utf-8?B?ZVk5YkFjdVJWWW1ua29NLzQ1T0VBWFM2dWdNZ3RWbzhvWGcyV3VvL0JyaXVa?= =?utf-8?B?SHhuZFdkMlMxaVFDNEFXRHMyOXp4QWZlcjEzRjB1Z2VHd0kxSVByb1JPTElS?= =?utf-8?B?dzFGaGJZM1NiNFhDRWtkZUwxalI3MmRsTCtDdU95WURBdm00MEs0THJKY3lu?= =?utf-8?B?RlUwMnJ1YmpGbEg5S0M1VHhOVTlPTWVVYU5lWjZrdWUwR1ZXby91OTBIOGtj?= =?utf-8?B?dVZwbFhTbDVMNjcvZ0RlcjJWWFFZWUJ1UE1odXR2TmRoWGRlM1lwUkJLRUg4?= =?utf-8?B?T3gxZU5vMG5kK0crdU5mVkhyNjFCcE1wTXgyN2hOUHpJemtxS3Y3bHhLS1hp?= =?utf-8?B?eGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8cc8bd44-daea-4d04-4a1a-08db05ec21c4 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 13:39:54.1709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bvlyD5AbSvIEzl8kUW/WBoWV4gkxpmMe048oVviB0u0fhFP3w4mYrej6VUoq/2eRajQ/qAHUPb34i03p/MqmUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7541 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: C7BA240010 X-Stat-Signature: rpn5jfad5iy4c5d7xdobrfsjjjbqmou3 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675431600-906138 X-HE-Meta: U2FsdGVkX19TDnjYYulDsF/kqVuBn7tiRmNKlwSplz0KAxReDywjFze/OohioLKqQwhHI+F2HVry4KPUh+S3K4zpj+jmhRfyQ7vL68W8enK3nHFzLdIrWHnC1J64ulphaL+Dto3ck+tUM83+yr63kFWQg4GCU+fp4WaFHp32vi0eKvgj1AoCSeZT2Mzimd0n/lbOS7lbjYvYt63uZkfIeOSPJsG4VfsSzFVMk74m/Deq3y62ldw67iMqSUjI8VOyb1ttwQlcFGNkV/7WAvGMvqpsC5629DvtBfQWey0ePj1o6EmRG/2KBX8v6BxXJI5tvljXGCAeLI/GTQtlPCR+lyfWI38YsgrX+I5KcXQwL0FXa42povqhZzALuhlJGaOgN42xP8ASPyAtUOCJPEy6Hrjjm7O9fqu0hAit9Rubz6eDcsp+TT6+pDx3E6x+GWoW63HyA0xo2jV3P+HP663d3rDLvp5hOUHcDyMnIHD71aHMg2ZGdbGnWOSMU/7ozYFQRfWXsvou+GARogl7V5Ww3/h8JgZlKcDrX0rdZhrsrZD+oZbQIy4lflqyx1dsp/KWuBKAHiJdKtzdSNaxR+YymHO58Q5aiQU7gJNXdyw/VrQIYcReg06CvM6xE6yWaLMCg07aUkRMfRAdBrDnBrS3Hyu+wu81msy6jRDJSRmyfPFqRpp6kqvnwZXm+5uZLNS4ZASaWma61jNaK6vqLhT0TL4MBOqRmoQS16V/R8tmla+ryMfLoHFlrd2rHq8rX6NPdV/ScLgA6b27exSkK5dh5vMFtDf/X5aPWuNjTKxhIGgNCYoXIFnWg8ntyDcsCsqt1FwTVUyv+HFHqyw2kHtc6A2Gp0PjOn4qZ7ajqUypuskBTPuTW9wcoDhyIUxTgPNwdX1PVC8/oe2Lgj1thM2ct75pRfTByqHsKU5/LmhLxc5ZgezuqYadg6zH7/Qzvn9OaqFy4ChPaT8R4aLAYEP 5tOnPB28 Y1CgDUkUfNggFNu3DaRMM6dYuA9FKXnBs2yC2uLoypAth562heubLYJy/KnRFDuAuv+MPDTtATPBqjwevDX/fdbjJyCzytz4UMgufSgQ2YzsB9mriK9fIuiuFugVQXr0GCABKQERX6XPq4qdYzVPZcmi+Rc0u4nWXpPhUl0eoqeomKrpgJMxhA2f+BSIufvThrSVLsxC1a56e8YvuKjeLWd7WkoqVhY+h4P2hrtQfFFW0PTJcNKVN9DOVLDbmR7XTQEySwrTf2G+iIMFZYqbKHqG1+WYlm51Sa+BTcJtWrnXOLsAib3IM6eb44QRd0sAlEhIuepXNw56vgkf3KKwXzd7KaFkvNWPbgOIHwFVjC2AmX0GsAeXheFYX0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/3/2023 9:34 PM, David Hildenbrand wrote: > On 03.02.23 14:30, Yin, Fengwei wrote: >> >> >> On 2/3/2023 9:25 PM, David Hildenbrand wrote: >>> On 03.02.23 14:16, Yin Fengwei wrote: >>>> do_set_pte_range() allows to setup page table entries for a >>>> specific range. It calls folio_add_file_rmap_range() to take >>>> advantage of batched rmap update for large folio. >>>> >>>> Signed-off-by: Yin Fengwei >>>> --- >>>>    include/linux/mm.h |  3 +++ >>>>    mm/filemap.c       |  1 - >>>>    mm/memory.c        | 59 ++++++++++++++++++++++++++++++---------------- >>>>    3 files changed, 42 insertions(+), 21 deletions(-) >>>> >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>>> index d6f8f41514cc..93192f04b276 100644 >>>> --- a/include/linux/mm.h >>>> +++ b/include/linux/mm.h >>>> @@ -1162,6 +1162,9 @@ static inline pte_t maybe_mkwrite(pte_t pte, struct vm_area_struct *vma) >>>>      vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page); >>>>    void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr); >>>> +void do_set_pte_range(struct vm_fault *vmf, struct folio *folio, >>>> +        unsigned long addr, pte_t *pte, >>>> +        unsigned long start, unsigned int nr); >>>>      vm_fault_t finish_fault(struct vm_fault *vmf); >>>>    vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf); >>>> diff --git a/mm/filemap.c b/mm/filemap.c >>>> index f444684db9f2..74046a3a0ff5 100644 >>>> --- a/mm/filemap.c >>>> +++ b/mm/filemap.c >>>> @@ -3386,7 +3386,6 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >>>>              ref_count++; >>>>            do_set_pte(vmf, page, addr); >>>> -        update_mmu_cache(vma, addr, vmf->pte); >>>>        } while (vmf->pte++, page++, addr += PAGE_SIZE, ++count < nr_pages); >>>>          /* Restore the vmf->pte */ >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index 7a04a1130ec1..3754b2ef166a 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -4257,36 +4257,58 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) >>>>    } >>>>    #endif >>>>    -void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) >>>> +void do_set_pte_range(struct vm_fault *vmf, struct folio *folio, >>>> +        unsigned long addr, pte_t *pte, >>>> +        unsigned long start, unsigned int nr) >>>>    { >>>>        struct vm_area_struct *vma = vmf->vma; >>>>        bool uffd_wp = pte_marker_uffd_wp(vmf->orig_pte); >>>>        bool write = vmf->flags & FAULT_FLAG_WRITE; >>>> +    bool cow = write && !(vma->vm_flags & VM_SHARED); >>>>        bool prefault = vmf->address != addr; >>>> +    struct page *page = folio_page(folio, start); >>>>        pte_t entry; >>>>    -    flush_icache_page(vma, page); >>>> -    entry = mk_pte(page, vma->vm_page_prot); >>>> +    if (!cow) { >>>> +        folio_add_file_rmap_range(folio, start, nr, vma, false); >>>> +        add_mm_counter(vma->vm_mm, mm_counter_file(page), nr); >>>> +    } >>>>    -    if (prefault && arch_wants_old_prefaulted_pte()) >>>> -        entry = pte_mkold(entry); >>>> -    else >>>> -        entry = pte_sw_mkyoung(entry); >>>> +    do { >>>> +        flush_icache_page(vma, page); >>>> +        entry = mk_pte(page, vma->vm_page_prot); >>>>    -    if (write) >>>> -        entry = maybe_mkwrite(pte_mkdirty(entry), vma); >>>> -    if (unlikely(uffd_wp)) >>>> -        entry = pte_mkuffd_wp(entry); >>>> -    /* copy-on-write page */ >>>> -    if (write && !(vma->vm_flags & VM_SHARED)) { >>>> +        if (prefault && arch_wants_old_prefaulted_pte()) >>>> +            entry = pte_mkold(entry); >>>> +        else >>>> +            entry = pte_sw_mkyoung(entry); >>>> + >>>> +        if (write) >>>> +            entry = maybe_mkwrite(pte_mkdirty(entry), vma); >>>> +        if (unlikely(uffd_wp)) >>>> +            entry = pte_mkuffd_wp(entry); >>>> +        set_pte_at(vma->vm_mm, addr, pte, entry); >>>> + >>>> +        /* no need to invalidate: a not-present page won't be cached */ >>>> +        update_mmu_cache(vma, addr, pte); >>>> +    } while (pte++, page++, addr += PAGE_SIZE, --nr > 0); >>>> +} >>>> + >>>> +void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) >>>> +{ >>>> +    struct folio *folio = page_folio(page); >>>> +    struct vm_area_struct *vma = vmf->vma; >>>> +    bool cow = (vmf->flags & FAULT_FLAG_WRITE) && >>>> +            !(vma->vm_flags & VM_SHARED); >>>> + >>>> +    if (cow) { >>>>            inc_mm_counter(vma->vm_mm, MM_ANONPAGES); >>>>            page_add_new_anon_rmap(page, vma, addr); >>> >>> As raised, we cannot PTE-map a multi-page folio that way. >>> >>> This function only supports single-page anon folios. >>> >>> page_add_new_anon_rmap() -> folio_add_new_anon_rmap(). As that documents: >>> >>> "If the folio is large, it is accounted as a THP" -- for example, we would only increment the "entire mapcount" and set the PageAnonExclusive bit only on the head page. >>> >>> So this really doesn't work for multi-page folios and if the function would be used for that, we'd be in trouble. >>> >>> We'd want some fence here to detect that and bail out if we'd be instructed to do that. At least a WARN_ON_ONCE() I guess. >>> update_mmu_tlb(vma, vmf->address, vmf->pte); >>> >>> Right now the function looks like it might just handle that. >> You are right. I thought moving cow case out of it can make it explicit. >> But looks like it doesn't. I will add WARN_ON_ONCE(). Thanks. > > I guess I would move the cow check into  do_set_pte_range() as well, and verify in there that we are really only dealing with a single-page folio, commenting that rmap code would need serious adjustment to make it work and that current code never passes a multi-page folio. Yes. There is !cow in do_set_pte_range() already. I planned to add WARN_ON_ONCE() on else case there. Thanks. Regards Yin, Fengwei > > Thanks! >