From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44C10C48260 for ; Wed, 14 Feb 2024 00:16:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE5B28D0012; Tue, 13 Feb 2024 19:16:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C950F8D000E; Tue, 13 Feb 2024 19:16:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0EDE8D0012; Tue, 13 Feb 2024 19:16:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A3018D000E for ; Tue, 13 Feb 2024 19:16:42 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 489241C1677 for ; Wed, 14 Feb 2024 00:16:42 +0000 (UTC) X-FDA: 81788493444.26.57A30F1 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf11.hostedemail.com (Postfix) with ESMTP id 58C0640013 for ; Wed, 14 Feb 2024 00:16:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YeB1GHhl; spf=pass (imf11.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707869800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x83oaEGfY6XUdfnCvqHHviv6QlVDgBe3k3FbFciVrKY=; b=jhthpOkexodWQ/9qHXc+l642teANGfwsfI/1OrwpMbOChG9MysbA9xn6cjMDro6MeI+P/3 wnYUswotQF77ev8xooywAYq30nAEpH34qLGUcEv98YenstWF5u5E+UPvTYxtLdoNQPM4WL EU+Uk5MsKaMruv5zTWV0AFqNKFTahY8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707869800; a=rsa-sha256; cv=none; b=EqxphlhkBzTJQQ3SEx+byZo72tt5kUwKzVUX1rMjkNwObNXvap3lxpmRgn73L7A9dmGuNR lbI6LXICTl3uxEu0hAKPXxbYC4wjqR1IqpWmARuC6ua96UUfQZw3tcGo+wlKgjd1lLxLm6 rUlCZmPzfV0pOzVLfPlTGe2qEjJXSTI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YeB1GHhl; spf=pass (imf11.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.41 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a293f2280c7so694989766b.1 for ; Tue, 13 Feb 2024 16:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707869799; x=1708474599; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=x83oaEGfY6XUdfnCvqHHviv6QlVDgBe3k3FbFciVrKY=; b=YeB1GHhlRHGIBdePPJ61FU270Dw83jRN4uJ4/XCYTEOKDcBKNOryvtekhTEQazQZTW e6vyRu0mbKldweqI4gyuQBEPpyJcSdWk36zStfWJQMdzY6M/BcRDed8OuySpZIwWMW03 fJBFU24vDfpSNR+aVvjymNvAlmov0OzFI9nyjp3iqMZCOuWdm7Busv59838ZNnttNjfA TWqhJHLEqXf1zGVtPlfuZfxarBtoLiJodSyQe7wZqVb/lrLS5ihXFh4itGgs62Fj+K6G 5WfkpyUsbSdF9jJyGmVJFyd3qUMVH3OC0ynhgAEKmbIohdR/7YgENaMWih8tR6sqLqW+ Gr3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707869799; x=1708474599; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x83oaEGfY6XUdfnCvqHHviv6QlVDgBe3k3FbFciVrKY=; b=nySH9nQNa6b4u+UdqcKEjPkZaEjAwIvdkSzSIue65qLrzBe2bd9JwYz6f/FKaqAgXg 26MywwUWT2je9xVzSpXUhiNnkEIKDJ4LSX9ik7zGDcT8yAIJs0q8dMYaB4hy2cvo2d+U UnLgNzxsOL8MZzUwE/ffmCctO0D7dbMNGNxa2St7t1RgTJyQ22iHqsbcZpdcnV/rsNqg c+njzcKNEUNLNENLju+iHbGE4v1Irgu+Ki0fMpNXkSsgujpnf6R3aVqWXaV85raxWqkY VCCXQep7wW/9/0aLRkdHvskF7qarzSWEq4I+y73R8aPSSwdXYtRUj24BbOVpRzwlNHhO AG7Q== X-Forwarded-Encrypted: i=1; AJvYcCUpM5CaTbd0tihlHNHDj8V+seeo+QKxyxUbKBZsfysUPxY/7O4Uu+BSA9iuERiZ817RORocTliHeyXeFO2MLARjwqU= X-Gm-Message-State: AOJu0YxGqKicPJnneMkOH7KiVltaOcFmIPuPtdIKu4EQLWNhOAxwJm4w fveoenug8CSPUP6Hxgf7A1FFiuVOzR3UgIC21kPkhVUZjFNFnu1Z X-Google-Smtp-Source: AGHT+IE/MNFDlk4yHlNN97dJ56ckM4TRb3UBCOdX9dzdirIj45GLTyrgeNrAfQK1w+z067gxX3MqBw== X-Received: by 2002:a17:906:f14d:b0:a3d:2762:71f5 with SMTP id gw13-20020a170906f14d00b00a3d276271f5mr578144ejb.28.1707869798537; Tue, 13 Feb 2024 16:16:38 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVCUt2ZEZDyR/gJdG7VPNXaOm0ZF93EKLbxd7Tj2BJZBbmtw4+AH2e8ahwd1MMPbSosSd02fXNUO4r6x2zgAcjqRRh5IeRbh6xTmsMJx+PC7G/yM73JJG85HuXB1/w80Ix3uJJRm/XCdsUsZ+2LlJAtxkOlfM/mgq009fW9pMI0GIuDVF5JfW6riakxuv3XIE2GM0HfBpM6kfyJ2Thpcqt1nlxjai0RDxa+POqUDkKNdrZghQOe73gPuoYflykw8NXPCFHbFAH1NWq3n+mdm9HbsgDdnjfyhzP3ojS23Hu+Q0s5ignY3HyAsD+biDdnywtntvagRhT0/XsWfx0jFZzT/um9ELNU7g4Cx9tC2fX7HkC9+D4TbjD5jBPVeOIrr67xDVXpU+TfKDp2PvsCMA== Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id ty8-20020a170907c70800b00a3d09d09e90sm996537ejc.59.2024.02.13.16.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 16:16:38 -0800 (PST) Message-ID: <978e656fb27850b002194f0cfdbe603997ef70e1.camel@gmail.com> Subject: Re: [PATCH v2 bpf-next 14/20] libbpf: Recognize __arena global varaibles. From: Eduard Zingerman To: Andrii Nakryiko Cc: Alexei Starovoitov , bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Date: Wed, 14 Feb 2024 02:16:36 +0200 In-Reply-To: References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-15-alexei.starovoitov@gmail.com> <7af0d2e0cc168eb8f57be0fe185d7fa9caf87824.camel@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Stat-Signature: n1uieq58hbstj8bkfnkodkr17uhg7sz4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 58C0640013 X-Rspam-User: X-HE-Tag: 1707869800-731740 X-HE-Meta: U2FsdGVkX1/PqtxiV6WFRcw0RNttutRn5akKX8fdmw7YNNvduVl/02VHSak7JwwJLvZsO2+IMJvXMZGMAfn+lgVL2OwID0Y1WG5279Yi4yFZxy+4YC+MIHFFuLg7n8kt6WuAqtHpx29iEr4RLdhGeJAxw08j6KbWbC32gXRpH1eP6N3nBjML4ywxG98rxQslUitIi6CgMQud+IvWUTmsSu3WtJU1F79whHKBUdl2ceBu8W/kvBKRnFwZJjd0Q+r2vnOrsH2MMfyOroGXkCjIfGmqvld4+4Iqu4/6bpCXa9smc584NsSUcldiaoP5WgKDJb4relQLxmTpXXtjWIgLdn0GJ7BYtO5wPNuje4cNTcpHFpp3kC+cRpPlXURuBmCWsATbSe+8PaTo59aKaM8h5wTLQtu88taRU17P30PDis9J4vwWhnsH8ZnuCUlrwSxkLVk5oQnuAE7i8VTxUgKopiisxRyxNpHwgv4o3Ve78b8NFQns0yqo3TZntyYkl9GAGrYzPqqBr2rSo/YgU2ykLYrWOqrgTvcxQJ3o1hGE0Q+n+1k6KFhtCtKBLNgvZXMi4bgHWYrQIp/qPK1F1rC+/iQ8hB93iKOAy45iSjHv+EP+va4dwlqyrVT1NignHTwQDZJjCz+RCsrfCEDb26C1v/JWvjisrym6MuB9aOEx7zDCfpjX/aY4Up0Of+y1A2fp/GTyIQPvf/AL1otMQohVNJI2nMj2QazJz4zcmaYbBfcBMvS4+/lv48BdLN8LDfKJf418vRWlMdtIEe7TyfdCKKcFp2EVHgJvLYpKVS1sSOvWHCAUy6Pb5nDc39nzm9yTSWLBEin5ii7AeiP/JOonRqBpfluDKqn+cOaqFOIuP5xDPK/elnvCCCINihhj8MUmgKvKIBnYSs4VN54BaKo+VAP4kH5Fs3GXJL+yxKoQkPiYJop2Sy0KEcXu6T6Xb/G8TBhr5YTxPu5692YOrpX DkL5Pevc nm1QjOSVG/E93WLd1wa/IHjwLroNZ4ikEm3NoATfuvgDDNWxMJRU2ZQfllkx0daxNP9OEmUVCFgkku5h59Zl6O1F/Wxv+5ptXt/DtpBn7Lj5ZNYu9o5WcJZIU/r1j0Fp4bsaB9af2bgU8+i58Gg7qctaN9ZQCXFjggfrFLVOm8963k/gnoMdSg4xkR3rz9Ci3zy// X-Bogosity: Ham, tests=bogofilter, spamicity=0.043080, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-02-13 at 16:09 -0800, Andrii Nakryiko wrote: [...] > The "fake" bpf_map for __arena_internal is user-visible and requires > autocreate=3Dfalse tricks, etc. I feel like it's a worse tradeoff from a > user API perspective than a few extra ARENA-specific internal checks > (which we already have a few anyways, ARENA is not completely > transparent internally anyways). By user-visible you mean when doing "bpf_object__for_each_map()", right? Shouldn't users ignore bpf_map__is_internal() maps? But I agree that having one map might be a bit cleaner.