From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577CBD1171E for ; Fri, 25 Oct 2024 08:10:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2C006B0085; Fri, 25 Oct 2024 04:10:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADBAD6B0088; Fri, 25 Oct 2024 04:10:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92E1E6B008A; Fri, 25 Oct 2024 04:10:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7476A6B0085 for ; Fri, 25 Oct 2024 04:10:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B30B6140689 for ; Fri, 25 Oct 2024 08:10:01 +0000 (UTC) X-FDA: 82711401696.23.2392037 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf20.hostedemail.com (Postfix) with ESMTP id D850E1C0008 for ; Fri, 25 Oct 2024 08:09:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=UvN9TTJv; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=fWXNT4+9; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729843766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GAWD8TC/djvhQBVEuJhu9MPWQacSX3DPWg7oUJxb0rY=; b=rsHzABJMMU/00ZjOWnE1BZpn3uDVmJn+kgXQNU6Nof5XmqEnqzNW5qosX71z7Xxp7RDMm2 1s67xCuudGaWxxSg8ZcYU/96fgoGWXw+WRrmO04nCNwhMurel08JQPi8vIV3TB/sL5Pxed Z6tGDt9/lkWt1ePot5cBctdgocy3fEQ= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=UvN9TTJv; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=fWXNT4+9; spf=pass (imf20.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729843766; a=rsa-sha256; cv=pass; b=5sFfHxicSV7kcgD8yTHvuaCqTl+RHaGqZcAzgn85b34X1KR5OXCSLdVqO6oFvUIR3UCP6X lTRFUP2dq1BQS8UtonH2kCKGj814jHG2R216/KopfdKln1CEsX4dQiMDYZA9Lf7/ukigT8 7udlJQFuh4mMUw+6bFl7x1Btu0g/G2M= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49P888Vs005217; Fri, 25 Oct 2024 08:10:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=GAWD8TC/djvhQBVEuJ hu9MPWQacSX3DPWg7oUJxb0rY=; b=UvN9TTJvR5C5IJ0qpy7BFvNtyaDarTglPD EeteP1wqgZq3Zlgm5sVPSS/cshtkWuIGwxBagoTDA4vfV8olsYtUGoGgJNHJ03iI 1B1UczCU1efOj+k/A8soyC9TkekR9YduRBMxmr3oG4IMgEbs8RJgWBiXeowZR/Qg /LMYC7FKx88NnSG+Seg5tWKEIf0JAZuRwOqOr63EBn+kk13415wlZpzc7CeOqlhv cxjrnJ2OsK6Z9pPUy/68LplALd1JFCFhEP+c/G8ifV1sRu5wnbwUqPgPytB7VIeh GlcBxi8CM1IF+C7PKoVEtzNEcKsCe7bWgK7SYKQQA+JMWptKWn5w== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42cqv3kghs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:10:15 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49P6Qoqp018375; Fri, 25 Oct 2024 08:10:15 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42emhn3afq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 08:10:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lamgeemESWhZ9XIywf3OtnNz4vF9ivL7OPgsDMvlhPSspmpVqXUAKqT2pA6FoDY7oXn5NzZ4BoPc5NQJperKGx4cEoI0Jrdwti4sLBJ8O0RbuWoqEQ+HgIYcgDue9T8yp1Oj2iCQaMOwz2rFp4VzmUBq+a+sHyhDFCVa/3fO+WI6tf12S9S5UhpOzraPU+y7ZbredS2Evwgr+fUU33ou8jz3JEERdrJGXbdlr35Mi+ITDBrHF/J2WcTp1lXQhpO8bP1HFppAw5zL1xBoSXzZ70HX0L/Q8gb0ZVBMfP/PuHvhBLKJbNQ7+OcUUZlo+6Io6L9SkMmitrCg79k5+i4vFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GAWD8TC/djvhQBVEuJhu9MPWQacSX3DPWg7oUJxb0rY=; b=l08Ea2kzemUSqd468CKH3MlsbY+abuD4CHItwimWZ/SDsJW4HGV0PK1/RbsED4PboQDPW4t63t2LOFY95MR/tULczxf12F9dy77l/rL4m/GF8YcYTPWhMRTXN5fUPmoHa+FisUAKyJoFChNMKBAj8r7Ojido5axwPVWeBxpPoJvmtiqfbZaytZgTsPbQHJQAN85VW6Dxzqqb/CTuVjOuVLezw54xTeL4ylrE/kjoBFDq1R3XFA6jnlHj0sn8nnzC0XME5Pi95Zvchr3lNuq33oitdqx5yjMpc/HtMG024nM5b8S6BJPXIF4h4KOWPFy34O8qZIlrE0xEt2SNRYAu8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GAWD8TC/djvhQBVEuJhu9MPWQacSX3DPWg7oUJxb0rY=; b=fWXNT4+9lxswJh6mf/YbBsES+G4yj79cLm0ZIr1zB/2cGExDAorjalK6qAHxBiCDDtAtIrym5Ig9UxJ/tfXkLTspVLub1sbBiMpeoqmEni7liCjvWFau4QoDNAufhBpzd27aM4SK4mt+C3/OLhow/72GXzKe8tNdWh2PXZ9hTeQ= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by IA0PR10MB7352.namprd10.prod.outlook.com (2603:10b6:208:40b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Fri, 25 Oct 2024 08:10:13 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%6]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 08:10:13 +0000 Date: Fri, 25 Oct 2024 09:10:09 +0100 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm/vma: miss to restore vmi.index on expansion failure Message-ID: <978e1d13-bb8b-437e-adc2-8af389064ae3@lucifer.local> References: <20241025031847.6274-1-richard.weiyang@gmail.com> <20241025031847.6274-2-richard.weiyang@gmail.com> <848b5701-9dec-4c69-bcca-f9186090978a@lucifer.local> <20241025075955.hczpuimxcfqhjv5x@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025075955.hczpuimxcfqhjv5x@master> X-ClientProxiedBy: LO4P123CA0612.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::6) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|IA0PR10MB7352:EE_ X-MS-Office365-Filtering-Correlation-Id: 100e168a-67fa-401d-f4f8-08dcf4cc7388 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|10070799003|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VupqwL2n7UJI6ZFRaMnSfHfVehmjr/H5tCkrJFg53fOEQmLuzlgR+OnA/UCc?= =?us-ascii?Q?H5lpTfEQcK3U/emNXPXexmPkuZJ71H1wcQkhHmWt+QcNnFD4lenbXBNDknbx?= =?us-ascii?Q?cinDddIqZK2wMWE7pFErRnClSbpsVB4JEUecb3KzeuZ37q3JtAcjXXgKsU1i?= =?us-ascii?Q?UYgc5OVEmvMwwHbNWEGuQYIS/IuCVrOytEChfBzZtSluJw9kpFfm9Yta2DOp?= =?us-ascii?Q?yzHX2N6KqBAcNicxNRmbzlzGMFMnAnaMXeJnZQeSHt37R1nR7BZTR8KzPqSd?= =?us-ascii?Q?APKb9urhR7h1eXuO8fFpGEkrAEI6RwB7xY7d3KnQxjPZQWT9w4gaelxejeFu?= =?us-ascii?Q?PTrJ6INQ6ICZtDDBVivMOfqCfDrJsJsFm+S9Fsej0mh1UcEsoNZ+kEvnL0/J?= =?us-ascii?Q?KZWqAixO9fTeeHHqtA1XuxjgIXOW94aiNC2ceMxziDYKl7JYEezvB9Y5Yj1L?= =?us-ascii?Q?PeSp/DL58RSd3978g9sDEHysgdxjMZPvR7LrAYnn0xCvBiD6rx8PuqsYACKd?= =?us-ascii?Q?SYi8ik4x2ViWKJ6LBc9Z2Bbbz4HYpKrSA9QQsfnjYAgByE5zdnaGe4HdTXiW?= =?us-ascii?Q?Wxts+l6rqEf0jvtkgXpq2GUZ2VAW8D1ZwCRkhhEhdbGhJ5QbUMPcPIuC9SI2?= =?us-ascii?Q?Yn27OYB9Gqyxh44zXHEB7t24zPq9Z1gxWnrEb/msMMxX6AnexohWhsl7NJI0?= =?us-ascii?Q?zjDZhpxVbKdCNGiCWN1+dWF1+3g68DfMCxOS3StYReN8SEJ8k1iopGEcuLwA?= =?us-ascii?Q?/j4i9I+JFEt+Q11B6cyXtMyqmIOREw4gvWW5H6A1nxfakA+l/OgYeLH9y+C1?= =?us-ascii?Q?nTjBSbGXZjBIw++DMOEbb+sStpockpTUJZdYeVJ9zYIRd+WD3A78N2f+60Kd?= =?us-ascii?Q?iEjvEt2KfrPcnTew+bxgj2a9DwMOQh3tfzob0OdaFsTfpO9XEOIRpc6cKHNU?= =?us-ascii?Q?9ZxYF6fizh3eyzq2qCF1tPe3dNAi9KXLWYlKQaleZ8usonuUEngQXvT4GSDa?= =?us-ascii?Q?ShQWPlC395hUDQUSKn/hOcZ8dHy/tVuDDZSPxVTyBru2kbpgK79OqHw/zIHa?= =?us-ascii?Q?7mgy/5Qa0mtGqMKmEB91ogtMcqq7aypJPWcSa3yPWSO3hpx4IUOIhZ3R1ZKm?= =?us-ascii?Q?qKN289RPW7309RuwVlN8D3ecK3gHxnTu6oEGouf0MVPtFnSuzaW7oWgflTaV?= =?us-ascii?Q?vL0moAvc8ZvEtgWZqRg5QwWcgLtMg1udfxWbXGCXwRKjDn1BJDFnNHFPOXXm?= =?us-ascii?Q?wpgyJ+NNrPz9rxkegOBzhMroMZbiNWNdSZLXndE647toBGiQE7RzYK8cQ0zX?= =?us-ascii?Q?2qZLSP8P5FV/sN84M6LupBsg?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(10070799003)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?URqyf6RsI9ovTyTuLsHjrDU6ClVESpkuP8q80G/xtYbgZGWf3tzJ8FDYS/AW?= =?us-ascii?Q?hXLZ42MhFEK7PSkwgKifXpMqbgN/FmO0oQS2cYksqbOyicDLD8S9l2EJqnHy?= =?us-ascii?Q?3FZYNiY4LhSGTk1eD5x1xHdxFoiDHLxRbxP9jJ5sHcmFiByDc+AOE+5pkscv?= =?us-ascii?Q?WkuPc3Vp7JRyuwl7dBX/1r/IEG5ll7qsdGmj816JyeHE2zu2jvbn8ySm5jAb?= =?us-ascii?Q?BM9mwG3R0OwDrS11jlNohskXnXqB8Bw2zb3hAlzS5i3m+3HvfM9kh6rNk3UO?= =?us-ascii?Q?SclR2uG59OoOADU7uA6bHiMmJ9/6OzPdzdOxam6TG6AIXrRTWeIAZoJUd36l?= =?us-ascii?Q?pqBnYWBFXHXs/sig/kfMB4HHaWJS64cmC+YpXrdkdfFrEKsYH8kJH+fh1b8u?= =?us-ascii?Q?1snE8aSUNTYF/OCfSl0vzvncRPq9u1weL9J4RwCjEoxcpW4uwe8Z4v+1XTZB?= =?us-ascii?Q?AJ/8BZBxoF3f5Ax6i70erQxMhzKDKWCZvI/Ff3eEkYGZ+jj5SSvkMNuymGjY?= =?us-ascii?Q?RQDNHUJJA1LRSatPFAtjHqGkmkBukmMab7wy6EZfY+et9LkLEyuU9Bj5SsVo?= =?us-ascii?Q?v/fkq4TSEyvmOl7T6JmW9sgGETDVaMJ7HiznRAT0Nn3k1R8k5dj+Aq90Jrw7?= =?us-ascii?Q?/Ash4f3ppmAFKOIlMn+nI9tRp/csw4yd1SzXYoH89ColPTPcmribvD0O8RKB?= =?us-ascii?Q?zsvUQgOBTTedvUDiPRT0ZaLLrfAaUeG8F2An9Vx5/NaNNPCw7r+4PVTX9NgE?= =?us-ascii?Q?9vyXxji0Wncp/WC4ojdiRCfyY1YiD5THHtv6ETWptWv7JCpUzOGJTMWeWeHK?= =?us-ascii?Q?AzZy9ODLAizB5l+PWYU9xA+II36EQYlw6/oQmnnkaYAgL8itNd00Q+F3SUc6?= =?us-ascii?Q?dyygqDzsqlBuXOmaPm421BB3VJEJS/54vjGupgWrrfdHWb/eb8b37KvE/klT?= =?us-ascii?Q?g6bXe3XWdVmrehy76jAGg3Ghtyqb9sO+YXdndot6Ha6783eX0fc5MGHgzVYo?= =?us-ascii?Q?g3WrUFE0SKPyXEXL9u6ylWaLwcyLX/rpTWbGrAjb4zdVzAzC7kBmhqGquJT+?= =?us-ascii?Q?iq1JeH/3H+iE/gnOcZz9KoTK6DZdkIfYJFOL1Ca1GOK0gIL2GV0TBPP75YYl?= =?us-ascii?Q?FpyTIF/HuFoPdr93B/9edzjNoo/1sk4xK0c+mo8ahq+XpaRD13QfsLDvZcmY?= =?us-ascii?Q?wYlc9yeztFZVY5PfUcsebpHkERE6KSS72Y751fKk1t/ZJkop6UDt3lrAo+0T?= =?us-ascii?Q?aSrqwrzs7qjSw58/7bF5RKwDd5jaoze0WxrH2hG4m7LhkeAf1ZJzD8Z7x2mg?= =?us-ascii?Q?BJQy0OZKQ24sqzuXyJAAnWoshz8Rc7UD5XqPCRwDJ6p5EjQheOWCipdSPU42?= =?us-ascii?Q?erKRHdd98Kgpwt2rctSYOPzePotxCC3sLb41+4jryc7S82mJqJ2xzfKh6/kc?= =?us-ascii?Q?AZqWX4BBDOf70x0uiuKvOCgNu24CpwzKGvRzrDbcnDxf9ngCJ8knyTov28+V?= =?us-ascii?Q?syUqvfixZkf4udG53Nz3NYsW+Wj3NszFnwFjA2+xUg5u8FwIuq77DZ2gwNcO?= =?us-ascii?Q?lhNSNfrcENPNQ4U7RnNS+ycjLRtcm/Ip28PKC1eQKePKZxPdHEqgrvcJIHZC?= =?us-ascii?Q?vqDP9IzG/ZDCkS6PirTEYny/kITZj4e83UmlHcDpdMys+HIsdzrSX+q23HCa?= =?us-ascii?Q?sWUXWg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Jez0ESTIoQhW/x4XWRIJzaKqOKY2drRx5MkExU0E6OtbIOFfzW24HwRufPd5OlsBknxn7uiYtWP7hvqd/DprjDO6aDRaFj43+i+5ljbQJT/2/cTZn1Hb3ocEFEcKZvLOOEsRGfHAwoxPzL9MeVL2UIQpbq1huvFZtY14PCqtW6O4e1cATEAwBv87aiMtaZWwD4UPe2JEJWWh6huUQfLbJRc30T5wXt7DKY3GQmguEusECfHyGkonUDQCn/ivikaKLtiWYRYRiFIg57fhxJUXmbuPbkD8baf3baD81ZiWuAX1tU2NlEK3OFgEzgdJHAn9HgIQ1xX8FMqyjQIAIks+TpJ0s64UnajB3JrmiPR6CAogCcAipgFA8Oadcajz5lJ8+PsDyiIoRjUUQHmT04UM2K4TfSK9jfycWvQ0GGyHDyODbdw++Tj2wWkCmr4KCTrnpZYXLdAZgZGcsuBLlTtP20r4B61K45RiBbyMqiXRoGI2B60s7dLhCEq/w6qcFLhstu/QRqTsuHTrCdxL/Gd+ILRCzVxazsYS0BI3MoaYcfZQTVuvc9o7JL+eHzdbyrZ+xfzpkYla6hpjSz2ta9Njjgr/JgyPdrgNn+pSfrQwboE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 100e168a-67fa-401d-f4f8-08dcf4cc7388 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 08:10:13.0909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8JFhWh5gjlBhxh3G7APHGIvtzOfGIhNuFyJj6iJX+B2q6eMQrYBe3Cf61re+yu5VQL1OTrxRcXWjeQq5N9waoQpNuQ2KOTVjGe3mCQe2v/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7352 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_06,2024-10-25_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=751 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250053 X-Proofpoint-ORIG-GUID: rBB0MP6H18PEbUY77ujroe7Byr_UIlw6 X-Proofpoint-GUID: rBB0MP6H18PEbUY77ujroe7Byr_UIlw6 X-Rspam-User: X-Stat-Signature: 35zszief74qo5t13orf1gxq7ecrqu61h X-Rspamd-Queue-Id: D850E1C0008 X-Rspamd-Server: rspam11 X-HE-Tag: 1729843794-941723 X-HE-Meta: U2FsdGVkX19vFxfzCegsLwiVhZy4GqtJg9zpyPHBAzxSfc3gl+r0bWaYGO7ydw6d0uHo7k4+XRcuIf6NpnVK2X6u+HxLLwhy2sxK2w9rsBGq3viUTLBkQ+Jk+qXXejdGRg3vYcKtl9rOVhtD86DXoQarTu3VP1bgMmyIyjfSMW4UPBUooZU22RMu3TgQ2U9AzfBQFXnXmUKP/s9sVoQ0pZBFL8bmVj+KLbTw+6s5/jCoOPmlBp0p1KByP/CpCStvy6soOfV9Pv7lkZmHY+kKfJ28PyN0blVidZ37lP/3LhDCPuZt0v8CnJCH78IOz3YDDFqjMFtNDuxT/Zhk1IOaV+yPNhNmPnWPra/WKFyK+kB7331B1qBoCzAkCFFjy0G9kykTC01YZlD4Zye9Ckb2l0siuRUuEkfI5VwRfqV6RzNgukx1lCizL+ZbNYdKK3lehZhnGYbxKf72ska5mnfg/PXj7zN+dzs84/KsV+ZTDI06Ajp5dCizhJ5EtUOC2gn6/tJYCHdN56J3kpMjh0Vs5R3tg1JkWzmXQF1xbLOiZWREheQ7KHi6PH0xZYO5DKz1xLRRyBjFkxSuF1ilokzg2Ub4InF8Ae6zRcaGzmNro3XlNG91VMPss6yf+RPYDJnJ6LpsSHj8+C00o6yyv/Cl9X0qP2GiYDryI3Ci7cTmh5vS4hyTkk0b6+iMPibBpruJ+L440Pz7gqX8qPZt2uYH+xfjadBEcNscuKW5ROk6SEL0zywuuOGqCTX/CiNF0wUOGrTWBrqflOYVmjjesnSoAiJpV6lOZv8d3G+mR6UNDFh3XESxIiCVFtbKJCBJWSFGZ100NdM/A4Cqpt2+qUj+JDhXs0oJqPZjI2U2y1K1G/1suYdjaX4j3ph5i6sVuD512HEhU/pVEBRzqXaS0Y1TKqVvz3pnp+QCCLdhv+tHkokoInjyFE6YIZ+znPVaVOapKpUDZubcwYqoYr9IGJv at0cobuG je3z5ClpBiwWJxDvfDbW/6hPw1+Ipcu0tD0cd8SEiBiFuIwmamIN5yWScGwDvFnxadeVUscvwdzbPDmWO4H2lF73G1R2BJqTO8wcJMUT6mU9agIWU6zUHzfJqNO1foUmcWPKgc9UZpPNP5S3/+9KIvqdoSESWzk31z03SEaSSceYlZ13nRiK5TtPIQm+aUlfdtLGfLYmwRSZe5rNOAEOwqSeE3zzoBs/MIBo+oqHxQdx94Ga8nRE9PHrlk5cyiPciFZzcdT77G6zDVrJdgG3XguL+8x0QrhXgnuKEjwD0cr1yRaBhDyaZ/bsiMyBMozGrNPcrzWGlPHnKSjdkeWqndAOh7OxjdIICa1mHDByk5h9+v1ECMp/2zNq2DItkSLajq774zYmHP17a4T2ud/akLVXyaV59wxAPnp/lK7MmwuSNWFD4zrm+8Zdai6Zi+1v05PUaDEsBDnI6O8BL7XU3ZYtWqyJxYaquNgQec83nVhKvbmHhKsZ8kM+1RI/IubjkEUbpppImrl6ZxrcWx4r0KyBPUi18L5LtHmJLbBYbROUa7de0LkzhlBQxAtieQP1X98QwhzlsjrOlC7Br8CmeMvUcrpJloiMR3s6bblzEbUyR314Mr3sbZ1BhHfF6NG/IvsUpGGnAOgdRAPUTdTZEW5me5gZJ7xe9cx52 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 07:59:55AM +0000, Wei Yang wrote: > On Fri, Oct 25, 2024 at 08:06:06AM +0100, Lorenzo Stoakes wrote: > >> vmg->vma = NULL; > >> vmg->start = start; > >> vmg->end = end; > >> vmg->pgoff = pgoff; > >> - if (vmg->vma == prev) > >> - vma_iter_set(vmg->vmi, start); > > > >So please replace this whole series with a patch that just removes these > >lines, thanks! > > > >Also what tree are you making this change against? All mm changes should be > >against akpm's tree in the mm-unstable branch. This change looks like it's > >against another tree, as the code for this function has changed. > > > > For mm-unstable, this is what you expect? > > diff --git a/mm/vma.c b/mm/vma.c > index b5c1adcb6992..03b4838026ab 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -1003,16 +1003,6 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg) > return vmg->vma; > } > > - /* If expansion failed, reset state. Allows us to retry merge later. */ > - if (!just_expand) { > - vmg->vma = NULL; > - vmg->start = start; > - vmg->end = end; > - vmg->pgoff = pgoff; > - if (vmg->vma == prev) > - vma_iter_set(vmg->vmi, start); > - } > - Noooo! Sorry I wasn't clear :) We need this. I mean: - if (vmg->vma == prev) - vma_iter_set(vmg->vmi, start); And with an explanation like: We incorrectly set vmg->vma = NULL before checking to see if we must reset the VMA iterator. However, since the only use case for this reset is mmap_region() and we always reset iterators there anyway, there is simply no need to do this. However, we absolutely do need to reset the vmg parameters to what they originally were, as well as resetting vmg->vma, as these may have been mutated to attempt a merge. There will be no change in behaviour, rather we simply avoid a pointless compare and, for cases where the VMA was the first in the mm, a pointless assignment to mas parameters. > return NULL; > } > > > >> > >> return NULL; > >> } > >> -- > >> 2.34.1 > >> > >> > > -- > Wei Yang > Help you, Help me > I want to refactor this further, but only after recent mmap_region() changes have settled down. Thanks!