From: David Hildenbrand <david@redhat.com>
To: Yajun Deng <yajun.deng@linux.dev>,
akpm@linux-foundation.org, rppt@kernel.org
Cc: mike.kravetz@oracle.com, muchun.song@linux.dev,
willy@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm: pass page count and reserved to __init_single_page
Date: Tue, 26 Sep 2023 09:44:32 +0200 [thread overview]
Message-ID: <9777812e-c8c8-2105-cd2c-443438786172@redhat.com> (raw)
In-Reply-To: <20230926023341.991124-2-yajun.deng@linux.dev>
On 26.09.23 04:33, Yajun Deng wrote:
> When we init a single page, we need to mark this page reserved if it
> does.
I failed to parse the last part of this sentence.
> And some pages may not need to set page count, such as compound
> pages.
Usually, the refcount of all tail pages *must* be zero. Otherwise,
get_page_unless_zero() would work on tail pages.
Can you elaborate why it should be okay here?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-09-26 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 2:33 [PATCH v3 0/2] mm: Don't set and reset page count in MEMINIT_EARLY Yajun Deng
2023-09-26 2:33 ` [PATCH v3 2/2] mm: Init page count in reserve_bootmem_region when MEMINIT_EARLY Yajun Deng
[not found] ` <20230926023341.991124-2-yajun.deng@linux.dev>
2023-09-26 7:44 ` David Hildenbrand [this message]
2023-09-26 7:57 ` [PATCH v3 1/2] mm: pass page count and reserved to __init_single_page Yajun Deng
2023-09-28 5:30 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9777812e-c8c8-2105-cd2c-443438786172@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox