linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: andrey.konovalov@linux.dev
To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
	Oscar Salvador <osalvador@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH v3 18/19] kasan: check object_size in kasan_complete_mode_report_info
Date: Mon, 23 Oct 2023 18:22:49 +0200	[thread overview]
Message-ID: <97721c54e9ccacc494dbcfcd0cbd5f5aaab6973b.1698077459.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1698077459.git.andreyknvl@google.com>

From: Andrey Konovalov <andreyknvl@google.com>

Check the object size when looking up entries in the stack ring.

If the size of the object for which a report is being printed does not
match the size of the object for which a stack trace has been saved in
the stack ring, the saved stack trace is irrelevant.

Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

---

Changes v2->v3:
- Added missing "../slab.h" include for accessing a kmem_cache field.

Changes v1->v2:
- This is a new patch.
---
 mm/kasan/report_tags.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mm/kasan/report_tags.c b/mm/kasan/report_tags.c
index 78abdcde5da9..55154743f915 100644
--- a/mm/kasan/report_tags.c
+++ b/mm/kasan/report_tags.c
@@ -7,6 +7,7 @@
 #include <linux/atomic.h>
 
 #include "kasan.h"
+#include "../slab.h"
 
 extern struct kasan_stack_ring stack_ring;
 
@@ -58,7 +59,8 @@ void kasan_complete_mode_report_info(struct kasan_report_info *info)
 		entry = &stack_ring.entries[i % stack_ring.size];
 
 		if (kasan_reset_tag(entry->ptr) != info->object ||
-		    get_tag(entry->ptr) != get_tag(info->access_addr))
+		    get_tag(entry->ptr) != get_tag(info->access_addr) ||
+		    info->cache->object_size != entry->size)
 			continue;
 
 		if (entry->is_free) {
-- 
2.25.1



  parent reply	other threads:[~2023-10-23 16:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 16:22 [PATCH v3 00/19] stackdepot: allow evicting stack traces andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 01/19] lib/stackdepot: check disabled flag when fetching andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 02/19] lib/stackdepot: simplify __stack_depot_save andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 03/19] lib/stackdepot: drop valid bit from handles andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 04/19] lib/stackdepot: add depot_fetch_stack helper andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 05/19] lib/stackdepot: use fixed-sized slots for stack records andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 06/19] lib/stackdepot: fix and clean-up atomic annotations andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 07/19] lib/stackdepot: rework helpers for depot_alloc_stack andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 08/19] lib/stackdepot: rename next_pool_required to new_pool_required andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 09/19] lib/stackdepot: store next pool pointer in new_pool andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 10/19] lib/stackdepot: store free stack records in a freelist andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 11/19] lib/stackdepot: use read/write lock andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 12/19] lib/stackdepot: use list_head for stack record links andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 13/19] kmsan: use stack_depot_save instead of __stack_depot_save andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 15/19] lib/stackdepot: add refcount for records andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 16/19] lib/stackdepot: allow users to evict stack traces andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 17/19] kasan: remove atomic accesses to stack ring entries andrey.konovalov
2023-10-23 16:22 ` andrey.konovalov [this message]
2023-10-23 16:22 ` [PATCH v3 19/19] kasan: use stack_depot_put for tag-based modes andrey.konovalov
2023-10-24  9:32 ` [PATCH v3 00/19] stackdepot: allow evicting stack traces Anders Roxell
2023-10-24 13:13 ` Marco Elver
2023-11-03 21:37   ` Andrey Konovalov
2023-11-06 17:41     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97721c54e9ccacc494dbcfcd0cbd5f5aaab6973b.1698077459.git.andreyknvl@google.com \
    --to=andrey.konovalov@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox