From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DFDC433E6 for ; Wed, 24 Feb 2021 20:03:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20BB664F2D for ; Wed, 24 Feb 2021 20:03:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20BB664F2D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 312696B007D; Wed, 24 Feb 2021 15:03:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 275406B007E; Wed, 24 Feb 2021 15:03:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 002BF6B0081; Wed, 24 Feb 2021 15:03:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id DB4CF6B007D for ; Wed, 24 Feb 2021 15:03:42 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EC1DFB62 for ; Wed, 24 Feb 2021 20:03:42 +0000 (UTC) X-FDA: 77854236684.04.CFD7B67 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf04.hostedemail.com (Postfix) with ESMTP id 9B96CFA for ; Wed, 24 Feb 2021 20:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=P/q4e9o0q2aRbLon+bFIsbOrV4BIhsNyv03Nr5GJxAg=; b=NGDHafa8tLcTPjPf/YnTh94KsK sLIfI3YiZ0AtiYRi7WbqcgKrXUGwtWQSb1KhFQRq0/JWvKw43+24K48CjLxOtgRvsFWjTfMkR5BIV swDA7XAJBRESowTK9sbAdMviAfqv6bfdYta9L49uxbxUX5GRgDo2BavJ6wFVlyTptTrN7UoatgMAP uA7lvRQPBvepJr0t3MdlpKA/KiVU85mXSCKxhDRHimPAQCueifT0wLI02iG+sdmu46Cfn/ej6Bdbd Bk4B9Ur+IKFnyEULBfhNCgFaGH57xFqW5HCH/n6wi16Y1Vq9lwdKHQgTunTjteaoAohB+WDQ1h7ax eCodn6aQ==; Received: from [2601:1c0:6280:3f0::d05b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lF0Nk-0002mF-NX; Wed, 24 Feb 2021 20:03:37 +0000 Subject: Re: [linux-next:master 11942/12503] drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' To: kernel test robot Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Daniel Vetter References: <202102242016.MJskK6hp-lkp@intel.com> From: Randy Dunlap Message-ID: <97716bb9-6aca-d7e6-e390-1b9d3a0b99a8@infradead.org> Date: Wed, 24 Feb 2021 12:03:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <202102242016.MJskK6hp-lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: wk5ymgwfa57a69su4y4miwzre5cedcej X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9B96CFA Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=merlin.infradead.org; client-ip=205.233.59.134 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614197017-721288 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/24/21 4:46 AM, kernel test robot wrote: > Hi Randy, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 577c283560fe8a81a23a95654c6d13e8412d22f1 > commit: bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 [11942/12503] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() > config: arm64-randconfig-r004-20210223 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project f14a14dd2564703db02f80c00db8ae492b594f77) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout bfa5782b9caa26f93f42ad79804e1f75a1ce9f18 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> drivers/video/fbdev/aty/atyfb_base.c:180:6: warning: no previous prototype for function 'aty_st_lcd' [-Wmissing-prototypes] > void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > ^ > drivers/video/fbdev/aty/atyfb_base.c:180:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > ^ > static >>> drivers/video/fbdev/aty/atyfb_base.c:183:5: warning: no previous prototype for function 'aty_ld_lcd' [-Wmissing-prototypes] > u32 aty_ld_lcd(int index, const struct atyfb_par *par) > ^ > drivers/video/fbdev/aty/atyfb_base.c:183:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > u32 aty_ld_lcd(int index, const struct atyfb_par *par) > ^ > static > 2 warnings generated. > These 2 functions are also used/usable (depending on CONFIG options) in mach64_ct.c so they can't be static. AFAIK, we don't make functions have different qualifiers depending on config options. > > vim +/aty_st_lcd +180 drivers/video/fbdev/aty/atyfb_base.c > > 163 > 164 u32 aty_ld_lcd(int index, const struct atyfb_par *par) > 165 { > 166 if (M64_HAS(LT_LCD_REGS)) { > 167 return aty_ld_le32(lt_lcd_regs[index], par); > 168 } else { > 169 unsigned long temp; > 170 > 171 /* write addr byte */ > 172 temp = aty_ld_le32(LCD_INDEX, par); > 173 aty_st_le32(LCD_INDEX, (temp & ~LCD_INDEX_MASK) | index, par); > 174 /* read the register value */ > 175 return aty_ld_le32(LCD_DATA, par); > 176 } > 177 } > 178 #else /* defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_BACKLIGHT) \ > 179 defined(CONFIG_FB_ATY_GENERIC_LCD) */ > > 180 void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) > 181 { } > 182 > > 183 u32 aty_ld_lcd(int index, const struct atyfb_par *par) > 184 { > 185 return 0; > 186 } > 187 #endif /* defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) */ > 188 > > --- -- ~Randy