From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D301C5B549 for ; Fri, 6 Jun 2025 09:17:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 352C36B0089; Fri, 6 Jun 2025 05:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 303CA6B008A; Fri, 6 Jun 2025 05:17:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2C76B0093; Fri, 6 Jun 2025 05:17:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EED7F6B0089 for ; Fri, 6 Jun 2025 05:17:30 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6FB9140D64 for ; Fri, 6 Jun 2025 09:17:30 +0000 (UTC) X-FDA: 83524422660.09.E731E9F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf23.hostedemail.com (Postfix) with ESMTP id AEFC1140006 for ; Fri, 6 Jun 2025 09:17:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gxv1K9RB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of jirislaby@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jirislaby@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749201448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vwNzhjlcZMizcSE6Zqq4maSw2ihWs8p6YWz9MWuTsDQ=; b=emaHtPzS8esU3QtygbvfYM3R+ezUm5D3+GMFpuAiunMiEPGVov5ZOeZUAp71RJIHhH0SE8 X1JIsWwaZL1z24V59lIlBQoibApPBXQn7i7NgvlFTPHFqdidcAaDxZTNLVnjGTwukBlPwd dw5KNaNc2yVd/IhR/fTlIRLsUVV7AnU= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gxv1K9RB; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of jirislaby@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=jirislaby@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749201448; a=rsa-sha256; cv=none; b=g8zoSOeLExha02j1wGzghmXKAPA/FRppid81RJZc4mDh9soNjbaL1FfiJp2bwytW//5xMt tx0zvVFt07m3hHvzmfNYyBdBqxAs8LMwojvign35/Cexkhjj7WFvhgLCZizp56ga8vR4xZ Au/MdBk6EDNYoywzhzZlE+4yvmd5YR0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5CE0E4AA86; Fri, 6 Jun 2025 09:17:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6961C4CEEB; Fri, 6 Jun 2025 09:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749201447; bh=CjeE3+LoclCRyl6TuFvX0hWyFjMLD2xC9d7fgme2REo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Gxv1K9RBg+ikSYDrWsGTVi4QyTWp1KgiEWdg1OgYbwv6vwRKGkzBojDEqzdBfx5Q0 XMsPq0WumaKOH6MZUioHuKgQuGP9dAY6ZUiZWwNN4dz3LKi2UN9mjPxJ+LA5urJKYl 09O86hEbboia8Ss869hYlxk1Tli64WgOAC5RvLGe70io5fjJEoOtBcMrST5yT/MYQ+ D+CtM7oOBXD7tCWMT7+Sx3KI223pcCOVZQMOJZFJ+WWS0oeniyhttSy1uSgfm9wQyg 04NXFSEHInFjGwYjXMUdHC+RIOfvEImBvgGxt0ex8TJSytBCUu9NQM3uc0R9/4HhNF ZQeTRpbfi72Dw== Message-ID: <9767d411-81dc-491b-b6da-419240065ffe@kernel.org> Date: Fri, 6 Jun 2025 11:17:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Large modules with 6.15 [was: [PATCH v4 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers] To: Uros Bizjak , Dave Hansen Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, Nadav Amit , Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Brian Gerst , Peter Zijlstra , Shung-Hsi Yu , Alexei Starovoitov References: <20250127160709.80604-1-ubizjak@gmail.com> <20250127160709.80604-7-ubizjak@gmail.com> <02c00acd-9518-4371-be2c-eb63e5d11d9c@kernel.org> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AEFC1140006 X-Stat-Signature: psguwxoz6akxj7yg8n4sp9e49cohd4w8 X-Rspam-User: X-HE-Tag: 1749201448-275555 X-HE-Meta: U2FsdGVkX19GvJEVcsmjy0AasMow813+n1hVd/Az3S3PSYY74XkVILdbcdNsoSotfKUaLh4DcoJTzxldwIHqhOrf8xerqe0DkdfmMpbt0B79ioJQBaqiOoGbT+hqX+U3UUY23BYrSYNm/mHF12VAFkNhm11xFafK21Au8hHYT2aR87lQc46wPdqTtOK5VLE9XnGviiZ/UFxDFN8ZME0YwQG9t9wGCf2J6KfGya8XyAq5+0jbjbXMbJdGnwadlAoXXFi2/JDiuqHIvacLtiwXhxXrsqkUIiKbUeaYdHwEVRku7p8q+AeTeImm4vVzXJb6+Pgf1BiRdptkO6BD5ktMmKiLycHDlYPI+toBEDueaJ8n56UiHjs9ziLLEcKqiQNHzwDJ/8ZOBAgvnVC7XYDOb6n/2z5I7uyAKPUaXaBzNj1YutNmb0BdHkrC8KzgsLVfLTEytBTFW2fRiNI/Iauzfw7fgWwY4B5IG2wawinUj9heJm1A//7uzYciTjo+7wGotmPXzESIZtXqmeRzUipUkKakd+44wicUbTtmhimYOWawKvb2uNuKEo0i4LgRI28te8//mj2MUVhFI71tNM7fMv1/sL6kNrNe6gpQDIgUIb2+R//lQ8p2KD1wktZPH0aTot9Gxj+Fd2zj1qQA49WoaqWZHeR3FUm4MFDfgud1+QW5cjKEx4m5zCdZwh6lJ7WQYpx3Wcp1+1CivbeYtRUMNBkXrlNK/baam9MO6MifIYGqnzQ4DnugjSBmkEpWGDXBxCJClb/oQ1C2T0FIAFQj6kVc52S5+erCz7tCmmIELqGKMAoLLd4tO0Ec7Xk1NvwF2VE7hjG2rYTjoT45rxWpB/V2mGn96cpxlHALZTN4AHdz8RT2Mpq4Za/tK18Svoz/H+E/qvx/fTJYtB/7UPmWU+zNcwihkdlaQrFI//6FqfOdmF2ARl9NC7cT9feVXatEutTF+sT1/xS7J5uFoaI E/Sy7VLf BQZmJGrqTQpF8MHnnjoHzyEs9a2aPIcGY6VB8YQpVfYDNcheAp9cTTq6yO973KoLHmCpzhFXVSDhp1SlQyUMx0bLTrp6o27j0ArLYs/JDTDFeDiffIVV6tSC8IvOv1ncK8esj4gZcgTkgtwcgLp6xLJii+jezIRXmSJWlxSbDTvKTK+63NwekodUH7sjePrz/buB1wp6dJtqYL4x4/6X4diwWBws/4rMw3FFprN2aG9xvONigMh0eqOSU+b5zbsklv4jdmgAzH348wUDw5MLsDLmkp28Zhe2KbZ0aw9cWFka4SPMaLJO2vXYuk6IzEbwDm2d+EXXXTMHb7azZ90OQ0hAj6MUYkpjuOSTMTigav+WD3Zx7lPUE1W4jfjtUzZAy2fXiJAanaM/NBRd+OnuUxCb5U0hiOA74WaFyJV5qUuRJH3I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05. 06. 25, 19:31, Uros Bizjak wrote: > On Thu, Jun 5, 2025 at 7:15 PM Dave Hansen wrote: >> >> On 6/5/25 07:27, Jiri Slaby wrote: >>> Reverting this gives me back to normal sizes. >>> >>> Any ideas? >> >> I don't see any reason not to revert it. The benefits weren't exactly >> clear from the changelogs or cover letter. Enabling "various compiler >> checks" doesn't exactly scream that this is critical to end users in >> some way. >> >> The only question is if we revert just this last patch or the whole series. >> >> Uros, is there an alternative to reverting? > > This functionality can easily be disabled in include/linux/compiler.h > by not defining USE_TYPEOF_UNQUAL: > > #if CC_HAS_TYPEOF_UNQUAL && !defined(__CHECKER__) > # define USE_TYPEOF_UNQUAL 1 > #endif > > (support for typeof_unqual keyword is required to handle __seg_gs > qualifiers), but ... > > ... the issue is reportedly fixed, please see [1], and ... Confirmed, I need a patched userspace (libbpf). > ... you will disable much sought of feature, just ask tglx (and please > read his rant at [2]): Given this is the second time I hit a bug with this, perhaps introduce an EXPERIMENTAL CONFIG option, so that random users can simply disable it if an issue occurs? Without the need of patching random userspace and changing random kernel headers? > --q-- > If the compiler people would have provided a way to utilize the anyway > non-standard name space support in a useful way, I could have spared the > time to bang my head agaist the wall simply because this would have failed > to build in the first place long ago. That just makes me sad. > --/q-- > > [1] https://lore.kernel.org/bpf/20250429161042.2069678-1-alan.maguire@oracle.com/ > [2] https://lore.kernel.org/lkml/20240303235029.555787150@linutronix.de/ thanks, -- js suse labs