From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE4BC07CB1 for ; Mon, 27 Nov 2023 14:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 764806B0150; Mon, 27 Nov 2023 09:18:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ED1F6B015A; Mon, 27 Nov 2023 09:18:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517846B0154; Mon, 27 Nov 2023 09:18:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 35E8C6B014D for ; Mon, 27 Nov 2023 09:18:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 858C21CAF50 for ; Mon, 27 Nov 2023 14:18:32 +0000 (UTC) X-FDA: 81503939664.10.47C6A30 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 0F4FDC0183 for ; Mon, 27 Nov 2023 14:17:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USJ6KXZJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701094636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WhdYJVzXXt1pFzcMraV+31z1/4TvHuz4d3g3ZmURbQM=; b=Kq+IEBKQx6ZBv4K2GG5VDI+BMyWbrjHfQEVI1ZWSg5fgj+6bCYY93iOhqEtLivdwJ7CJhs kpC7get1ChafstE1gnOtMVBDp1cGt0qJ2U16lcyZCXtoZbCO2pjZeDHUq3WGJHvQ3ujV7l Lu0dDBBnFWxwpnPZ6Tbgv+jpHWsSJRg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701094636; a=rsa-sha256; cv=none; b=Pu3qkZ72jcOTMmV/Uz7AuxjrtwoW4xRyhsquodXEqcpjJT1KIr5nvPxsI8s1xbDoT3A63D vEZNPQUcHfzumriOH2m2oh2iOqXcZsX0J9z0RAaT+3FVrv6Xe2VsyeYL+jdEtpbPZdyNeu 9r7eFbhWYJUc3VypRcUThHdc71huJLc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=USJ6KXZJ; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701094635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WhdYJVzXXt1pFzcMraV+31z1/4TvHuz4d3g3ZmURbQM=; b=USJ6KXZJ7P5KC1PaoOv5k78Vi+gztWnW/8HPI2DfTTOGmCPMUoC29VZTI8AcnFqKhRLcAF XafW5LWeMnZ3Wh/L5KVeIjG4Cq9PTyc7vw2aN7ieve2LsrtChTiRq7csv+hsE1foKVDO5u XE4HAAoz0m3xu5v5ImqbIoUoo9VTKic= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-504-RqbhHlyBNCiPwZ4NEXoJhQ-1; Mon, 27 Nov 2023 09:17:14 -0500 X-MC-Unique: RqbhHlyBNCiPwZ4NEXoJhQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c50255b905so38953001fa.0 for ; Mon, 27 Nov 2023 06:17:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701094632; x=1701699432; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WhdYJVzXXt1pFzcMraV+31z1/4TvHuz4d3g3ZmURbQM=; b=Oaa1E7ZvVfE/2ZyV1zxZjrz4TSDzkLX7VAA37upe+ssxMJFN/1GCCiuME35kXfQS0f Uvv56CVZKcTvp/66xQPTnJ56tm76KevfJpwjsNVvQtrymnI6Gns8I96K6Gc4yh5nPq2H 117NvY1Ojw90u8AK1mcYAUwOSL7GjK0lID4LVsFIMO2b+UWMZdJF0ftGsYDgjpBKFlkJ aB7Sx+JPvzR2UpH7fchvg7RA3GJrnEOvXWhJ/nyS692mA06sEJe2lIFsX5oCmiJflsdm tLLhlPlYaZ1VTUy6v1fk4PlYizpbe37osC+wFijs09u+k3VK14ot/PZq2CEl7oUTinMc yeeg== X-Gm-Message-State: AOJu0YwWlwPQg6K2ExV0LhH6zS2QObG36o9otlm4TqB6CXvuYCwWWQE5 v2tqMThxzM17vsa6wTFEpNBj54azZMqlMNORzNsP0K6xKeTFR+q6S7mjvuopmolcl3xtnm01iMs gM5a1f7D9woQ= X-Received: by 2002:a2e:8e74:0:b0:2c9:a1d1:813a with SMTP id t20-20020a2e8e74000000b002c9a1d1813amr2072736ljk.34.1701094632461; Mon, 27 Nov 2023 06:17:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1PrTvT0NMBqX8K/GrsQzYFyAxRUQe585T2EOMwi7DPCweyKFbMAI/onPivKWNoOcn9rBpSA== X-Received: by 2002:a2e:8e74:0:b0:2c9:a1d1:813a with SMTP id t20-20020a2e8e74000000b002c9a1d1813amr2072651ljk.34.1701094631233; Mon, 27 Nov 2023 06:17:11 -0800 (PST) Received: from ?IPV6:2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3? (p200300cbc7452a00d74aa8c520b63ec3.dip0.t-ipconnect.de. [2003:cb:c745:2a00:d74a:a8c5:20b6:3ec3]) by smtp.gmail.com with ESMTPSA id j12-20020a05600c190c00b0040b3b6a0e1fsm10504290wmq.13.2023.11.27.06.17.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 06:17:10 -0800 (PST) Message-ID: <974467f0-de25-40d4-8a8b-1c7e0b91e719@redhat.com> Date: Mon, 27 Nov 2023 15:17:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v7 09/10] selftests/mm/cow: Generalize do_run_with_thp() helper To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231122162950.3854897-1-ryan.roberts@arm.com> <20231122162950.3854897-10-ryan.roberts@arm.com> <15c288aa-feab-4d3a-af33-b87481eaffe3@arm.com> <1ebb9a53-63ee-430c-ba65-8e48eff6d25c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0F4FDC0183 X-Rspam-User: X-Stat-Signature: 1p3bkw91k9anryhfi6rfjfhjmw4dye8d X-Rspamd-Server: rspam03 X-HE-Tag: 1701094635-723809 X-HE-Meta: U2FsdGVkX19KqnVARmAchnNqax9rykvOroMWYChg1mi7oyYbf8+mmq8y4huUOSpbwDRjZ3mM6uZn7LsU+l739RJN4vqUtPEetQH+JrZ/QeOXzksp4e5z2rdx+K5h59boiojrEVSSZVqPpnzwOaTUHPhRdDzaTy6MgNplGRWJiU7kjp90Xi1EM6szMM6vtXe5DMPfKC1MNtKhyJcGAUw6RkFA4sZoeRLa8T87BbZ7NS2gnx7Gs/9OHEFzZBHudFzpYi0SPTisnesJMwycUhrnBFU1fP4i/2OmIoA6Y43B9axbfqWpy07fOnJV3r6zZ/QWy7kTWCaK0vyuIVHVAtOXeSzd3qDeSJJEBVuVjOTm7nTXeMVzXeo3LNvrcKLCK1E/U4DjmftbtRBZmL2l55w+zv8yC5c0VG3RnmtJKHR4LwGrxT4G1dH/HMXo1q7J9SrQHN1JJpOgpVYwezEjaizh2LeOg3F5A5ahRfPUTU20udR7jQjr+kCOkHVJ/47z12jHkaNMzFkn7u9VSncPUh06lHEg1LZEjKxJn2kcaAWCuXwmZ7Z+U4QDi5q9JluFDzGo/4+MZG3A0dJp6onoh1Px5g2zkHwao1Yb80B7ZDk4nqWfrr4TsWPG4lyLrRdTKFE4b3MefVSgcvcQ73XxZaqQSyBgn6ZXhfPZMM+Vlxhdk9Zx6VQOfHp2+PcasRCLrSrIykW6pW4zqU3skYV8MSd0IpblG1uOFah/4TELNDAcJcG9PPyxJXKgkOJnHpvwlX7uxN3bvE8ipOtv1C2pBjt9dAkhDXk/Sffz5GontaILut3KCfw9F7pzx81Ss31qNlyvYYLj59epOKj+PpfUsBng4ZcU+wgi4CdBCDA4ClBBGZV/oZdYUJsCZpdtcnMYcQNSGT/64xQkWUpGV2bddXDd4j/OX8QKY+/+r4ngDRY7U68kQkdSrKV5hx7s1D2Q1lnJqUg1/XCSmsbmrHErZux fXjf7vgd 9b+0n9gbx1LzYZ03NWGzmgDyRszUTsU5xLe7HpQ8Wc/7h5Yip/g9183iFwiO/tXoSGMbsdV3A7EfZj6KIPEbGnsE1Jmu/fGDBEFgoshDqYTiPnHg/9lRWHQn3BnKDejwU7fNYvqIBrzYjAJcicoHOGOdA2Nt2Cw3a8tdxEiOxX8A705KCgp9mOreyrtnstJNO7w1f/p9xjpXYWCgm+Ggu7nr9bQ4uOvEL39Hq54TB+UQU4Ls958N7mYgnztAxUzUYN1JF/XNrvzOxbyBNBhNpESNTN5h6TJ4W+jrccUdq3tMMpZxbuQctmwQNt8Fknra+dn3jAt5YQ5SL56Im7R6yureQO2kVXufskUfTNMjlAudK+0RuAqx4iXuXb3LKMx6cwkyaKrRIjAoxAriC7SQMxI7xKraz6otvI0xLIi6wsE06AIhnmRzsyYk12MksUewj8dlHEX4X5ITImMYjVBRasMS/6VBarOlaC896DX+yXLlNxY8yIBLUzRIGTsk2aMkhWEPrdIX/hKFBQmfCH8GMxKQJznkFEQN5a+by X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.11.23 15:11, Ryan Roberts wrote: > On 27/11/2023 13:59, David Hildenbrand wrote: >>>> >>>>> +    pmdsize = read_pmd_pagesize(); >>>>> +    if (pmdsize) >>>>> +        ksft_print_msg("[INFO] detected PMD-mapped THP size: %zu KiB\n", >>>> >>>> Maybe simply: "detected PMD size". Zes, we read it via the THP interface, but >>>> that shouldn't matter much. >>> >>> Err, just want to clarify what you are suggesting. With the current patch you >>> will see something like: >> >> Not with this patch, but with the other ones, yes :) > > Yep, we are on the same page (folio)... > >> >>> >>> [INFO] detected PMD-mapped THP size: 2048 KiB >>> [INFO] detected small-sized THP size: 64 KiB >>> [INFO] detected small-sized THP size: 128 KiB >>> ... >>> [INFO] detected small-sized THP size: 1024 KiB >>> >>> >>> Are you suggesting something like this: >>> >>> [INFO] detected PMD size: 2048 KiB >>> [INFO] detected THP size: 64 KiB >>> [INFO] detected THP size: 128 KiB >>> ... >>> [INFO] detected THP size: 2048 KiB >>> >> >> Yes. If you'd detect that 2M is actually disabled, you could still log the PMD >> size only. > > Note that in the final patch, where I test the other THP sizes, I'm not > detecting which sizes the sysadmin has enabled, I'm detecting the set of sizes > that can be enabled, then explicitly enabling the size (exclusively) when I test > it. So there is no chance of reading PMD size but not having 2M THP. Minor point > though. Ah, makes sense, I missed that and thought we'd check if that size is actually possible. -- Cheers, David / dhildenb