From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8471DC433FE for ; Sun, 6 Nov 2022 12:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B49408E0002; Sun, 6 Nov 2022 07:38:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF95C8E0001; Sun, 6 Nov 2022 07:38:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E82A8E0002; Sun, 6 Nov 2022 07:38:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8B6488E0001 for ; Sun, 6 Nov 2022 07:38:17 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4DE9280B8A for ; Sun, 6 Nov 2022 12:38:17 +0000 (UTC) X-FDA: 80102970234.12.E0AF615 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by imf09.hostedemail.com (Postfix) with ESMTP id 60FDC140005 for ; Sun, 6 Nov 2022 12:38:14 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VU3D5cg_1667738288; Received: from 30.15.235.173(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0VU3D5cg_1667738288) by smtp.aliyun-inc.com; Sun, 06 Nov 2022 20:38:09 +0800 Message-ID: <97361840-0a56-f074-0495-712dafe4313d@linux.alibaba.com> Date: Sun, 6 Nov 2022 20:38:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' To: Dan Carpenter , oe-kbuild@lists.linux.dev, Heming Zhao via Ocfs2-devel Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List References: <202211050722.8YGvtPaR-lkp@intel.com> Content-Language: en-US From: Joseph Qi In-Reply-To: <202211050722.8YGvtPaR-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667738296; a=rsa-sha256; cv=none; b=xNtvEQ6jK8lqEflY8S9i0R0cVvL4Gd7V0kZE3gckkFJIdcIbaEDH3NGmINSuDP4FPqnxcy F9fjR6lEu6xi3Y4zMZCfEJJJO2Xy+huepcLTGAqIUlRz/I6l+i/AyLlfLfWWQrOXcpEYA4 PHElaDh0NGfP5xV2QAkJdXLz7RyE9Dk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667738296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fIhJYHnlTYYEg/GBKmZs2K3zqEChIc064Fr+EwEn/vs=; b=6mlz5I+h1dV9R1z95RJEAfZ228thV97kiEz8yyxxbm7Pf8jbz+MgtIRZyQ8v6lOvd2NeUj 7MPlVHq/iRi8Y0dSV7tpZcJT0GHZeyF8bj3PjrHAbwnFXdpJcQB1IE9XGvr0OvEO6uoY1D qlXKEeqQJ4Nf0yvyaeZZBuHrW9s4098= X-Stat-Signature: 38tg7xpfp1bnj63p6k8hja5n5mx7aiif X-Rspamd-Queue-Id: 60FDC140005 Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of joseph.qi@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=joseph.qi@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam05 X-Rspam-User: X-HE-Tag: 1667738294-34890 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/5/22 7:15 PM, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 10d916c86ecafeccaed89175ebf9b832dddde380 > commit: 0737e01de9c411e4db87dcedf4a9789d41b1c5c1 ocfs2: ocfs2_mount_volume does cleanup job before return error > config: alpha-randconfig-m041-20221030 > compiler: alpha-linux-gcc (GCC) 12.1.0 > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > | Reported-by: Dan Carpenter > > smatch warnings: > fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status' > > vim +/status +1809 fs/ocfs2/super.c > > ccd979bdbce9fba Mark Fasheh 2005-12-15 1802 > ccd979bdbce9fba Mark Fasheh 2005-12-15 1803 static int ocfs2_mount_volume(struct super_block *sb) > ccd979bdbce9fba Mark Fasheh 2005-12-15 1804 { > ccd979bdbce9fba Mark Fasheh 2005-12-15 1805 int status = 0; > ccd979bdbce9fba Mark Fasheh 2005-12-15 1806 struct ocfs2_super *osb = OCFS2_SB(sb); > ccd979bdbce9fba Mark Fasheh 2005-12-15 1807 > ccd979bdbce9fba Mark Fasheh 2005-12-15 1808 if (ocfs2_is_hard_readonly(osb)) > 0737e01de9c411e Heming Zhao via Ocfs2-devel 2022-04-29 @1809 goto out; > > Unclear if this is an error path or a success path. Honestly, I would > have thought the checker is correct that it looks like a failure path. > This indicates a readonly mount and bypasses dlm related initialization. So it seems an expected success return. Thanks, Joseph