From: Yang Shi <yang.shi@linux.alibaba.com>
To: Christopher Lameter <cl@linux.com>
Cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com,
vbabka@suse.cz, mgorman@techsingularity.net,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node
Date: Thu, 5 Dec 2019 13:59:44 -0800 [thread overview]
Message-ID: <9731e7ff-6c0c-419f-5237-decf9a54e8f3@linux.alibaba.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1912051944030.10280@www.lameter.com>
On 12/5/19 11:45 AM, Christopher Lameter wrote:
> On Fri, 6 Dec 2019, Yang Shi wrote:
>
>> Felix Abecassis reports move_pages() would return random status if the
>> pages are already on the target node by the below test program:
> Looks ok.
>
> Acked-by: Christoph Lameter <cl@linux.com>
>
> Nitpicks:
>
>> @@ -1553,7 +1555,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr,
>> if (PageHuge(page)) {
>> if (PageHead(page)) {
>> isolate_huge_page(page, pagelist);
>> - err = 0;
>> + err = 1;
> Add a meaningful constant instead of 1?
Since it just returns errno, 0 and 1 it sounds not worth a constant or enum.
>
>> out:
>> up_read(&mm->mmap_sem);
>> +
>> return err;
> Dont do that.
Yes, my fat finger.
next prev parent reply other threads:[~2019-12-05 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 18:54 Yang Shi
2019-12-05 19:19 ` Qian Cai
2019-12-05 19:27 ` Yang Shi
2019-12-05 19:34 ` Qian Cai
2019-12-05 22:09 ` Yang Shi
2019-12-05 22:23 ` Qian Cai
2019-12-05 22:41 ` John Hubbard
2019-12-05 23:16 ` Qian Cai
2019-12-05 23:24 ` John Hubbard
2019-12-05 23:58 ` Qian Cai
2019-12-06 0:04 ` John Hubbard
2019-12-06 0:19 ` Qian Cai
2019-12-06 1:11 ` Yang Shi
2019-12-05 19:45 ` Christopher Lameter
2019-12-05 21:59 ` Yang Shi [this message]
2019-12-06 7:35 ` Michal Hocko
2019-12-05 21:27 ` John Hubbard
2019-12-05 22:00 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9731e7ff-6c0c-419f-5237-decf9a54e8f3@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=fabecassis@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox