From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC19C433F5 for ; Wed, 12 Jan 2022 11:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4A046B013E; Wed, 12 Jan 2022 06:04:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFA1A6B013F; Wed, 12 Jan 2022 06:04:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C14B6B0140; Wed, 12 Jan 2022 06:04:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 8BE526B013E for ; Wed, 12 Jan 2022 06:04:38 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3DEEE8249980 for ; Wed, 12 Jan 2022 11:04:38 +0000 (UTC) X-FDA: 79021351836.12.913DF24 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 7169D20013 for ; Wed, 12 Jan 2022 11:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641985475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQRmWQJO7h35wGy22fa7tdbvt7nutmZtPTdgCQaUOQQ=; b=AphSWdX7GcC1bXURnAOj7XvxSZun/6Vj+X8PhiMhvBfzOmUwASI/bHARbJsHpWm1TGoIFf WviuFbaevr/Buon66iVzaazRI5jhPHROSrnXl2zkFtcnkbK1Eh8uf/+EXSmy0Y17riRgsm KY6lbNOm8c5jvC/llviqbs1lYKgbIfE= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-UpMZnG-TMHSQjvtgjWF6fw-1; Wed, 12 Jan 2022 06:04:32 -0500 X-MC-Unique: UpMZnG-TMHSQjvtgjWF6fw-1 Received: by mail-ed1-f71.google.com with SMTP id m8-20020a056402510800b003f9d22c4d48so1908033edd.21 for ; Wed, 12 Jan 2022 03:04:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=eQRmWQJO7h35wGy22fa7tdbvt7nutmZtPTdgCQaUOQQ=; b=JTn7nFgxDVpzVUCWU6mIiI5uVD3zNATJwgqt5kbluvFYvK1NkJ0XapFsTkR1smP1M1 mShnVPywW32PDDErZOiie+088xMqWOvBrhmEXQ3OfDWQGDUBh7oQl2IWlNI7E1yFa6mV uzOTrpbRuQ5Hr7JtJpN8hIrizVdRTjLebn+SJSrB5IUkf4KjBXik+mR0LFtJIF/MyRfL /0OJnqlfqcmMWZRc3+QBXIFUOjV0WSTeVitmntmyexrRzpjCDJdvIWhih3amuIb4YheY 6aB7DJyKGswDlPsJdeNzxtPO3GoO7BD/3898eYEYkeQoj5gK+dGghDBc6Mulmn8/cVi8 irRQ== X-Gm-Message-State: AOAM533T3NMwyrwgsOAcZO+NwpXJxWtti79n+69GpAW8SBjcCEU4oCd7 4CPDfUFNUum+HV7wK8kqwr/5Q8v27bCylM4th9AAiHFdvZMy3zQmOo7cmV+vx506lhTcNQMr6w9 UUsVxHxY+fRc= X-Received: by 2002:a05:6402:486:: with SMTP id k6mr8580286edv.330.1641985471847; Wed, 12 Jan 2022 03:04:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLu6iWsDVwPl07dmV9nmwCMbbplxs+ZFDOgPiX/VhbSWFK2LAa03DeMHirncilimRMIa9S6A== X-Received: by 2002:a05:6402:486:: with SMTP id k6mr8580274edv.330.1641985471689; Wed, 12 Jan 2022 03:04:31 -0800 (PST) Received: from ?IPV6:2003:cb:c702:4700:e25f:39eb:3cb8:1dec? (p200300cbc7024700e25f39eb3cb81dec.dip0.t-ipconnect.de. [2003:cb:c702:4700:e25f:39eb:3cb8:1dec]) by smtp.gmail.com with ESMTPSA id qw4sm4413621ejc.55.2022.01.12.03.04.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 03:04:31 -0800 (PST) Message-ID: <970ca2a4-416d-7e8f-37c7-510c5b050f4b@redhat.com> Date: Wed, 12 Jan 2022 12:04:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 3/8] mm: migrate: allocate the right size of non hugetlb or THP compound pages. To: Zi Yan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Marek Szyprowski , Robin Murphy , linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Vlastimil Babka , Mel Gorman , Eric Ren References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-4-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-4-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7169D20013 X-Stat-Signature: 6ikkmgd7ecx4zkphet9jqzyuemmb4rps Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AphSWdX7; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1641985476-261150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_migration_target() is used by alloc_contig_range() and non-LRU > movable compound pages can be migrated. Current code does not allocate the > right page size for such pages. Check THP precisely using > is_transparent_huge() and add allocation support for non-LRU compound > pages. IIRC, we don't have any non-lru migratable pages that are coumpound pages. Read: not used and not supported :) Why is this required in the context of this series? -- Thanks, David / dhildenb