From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1018DC6FD18 for ; Tue, 28 Mar 2023 16:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F7736B0082; Tue, 28 Mar 2023 12:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A7EE6B0083; Tue, 28 Mar 2023 12:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 649266B0085; Tue, 28 Mar 2023 12:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 572506B0082 for ; Tue, 28 Mar 2023 12:02:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B2A90809BD for ; Tue, 28 Mar 2023 16:02:19 +0000 (UTC) X-FDA: 80618773998.01.EA6D174 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf23.hostedemail.com (Postfix) with ESMTP id 8A68614004F for ; Tue, 28 Mar 2023 16:02:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=RbGlpbJ9; spf=pass (imf23.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680019334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7dPe4cUrgnbdf3HAeVnRIAMKKWilzlUiWCOWvNtQztM=; b=cSv0p3xtWXLOMHnhyPfI0RTGmfsHrCZBWt/CyBWLTx12yMnwm1vlKBWr8HaUNKvy5SE97C CD5ZQXUN7lHXEL+8K6lh5TVZeGCcfX6QhcOaywkgh9Gsav0+0uXhIz5NnaQioTlqi2h24+ ybIFagNV6P+2bYdZOJfofXOD73pntLY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=RbGlpbJ9; spf=pass (imf23.hostedemail.com: domain of p.raghav@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=p.raghav@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680019334; a=rsa-sha256; cv=none; b=iVyJgSy6nhk/yHBslPj7Bh1gR83DKaaMzqrIAktYezobARoqmNvy9fS/AqvXnImrf4zqPH jAriFbXnNGHld9J52JSB3r2Il6WAOhbd2UQkzpfN52i6CU0CcYvOI6mHoHVBNHed/1RZt3 Z/1YWKKqDWeJbwvWwp2pFvAd5kaiMaA= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20230328160211euoutp02a8d2121d8a210f3e96fc6a6ce238709d~QoK5ntNEr1127211272euoutp02s for ; Tue, 28 Mar 2023 16:02:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20230328160211euoutp02a8d2121d8a210f3e96fc6a6ce238709d~QoK5ntNEr1127211272euoutp02s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1680019331; bh=7dPe4cUrgnbdf3HAeVnRIAMKKWilzlUiWCOWvNtQztM=; h=Date:Subject:To:CC:From:In-Reply-To:References:From; b=RbGlpbJ9c4X+KEtQGEcVFsjN9/0wpaprtZ/rdF4opu2aLNpf7rrP90a1PlU3S6H3q K0htQhdBVRx9bF3yyG3bvnCMyrYJIAWlELpt0qciCJ71ZlJVIRCmAn+XnQxNXXxvMJ R+WUuIKWwzbUguaHdMUVK3A8zUzkuZfkw9jRlBYo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20230328160211eucas1p1658d4fb55db67a0b9fb10fe0d25b6003~QoK5aNQ3s0751007510eucas1p1V; Tue, 28 Mar 2023 16:02:11 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 22.48.10014.38F03246; Tue, 28 Mar 2023 17:02:11 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20230328160211eucas1p15999058f9b91a8f58b22e648703641d1~QoK5Brd_u2348323483eucas1p1q; Tue, 28 Mar 2023 16:02:11 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230328160211eusmtrp237848036f912b54a84cd65576e23ed3f~QoK5A_VU60282702827eusmtrp2z; Tue, 28 Mar 2023 16:02:11 +0000 (GMT) X-AuditID: cbfec7f5-b8bff7000000271e-91-64230f83c407 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E4.ED.09583.38F03246; Tue, 28 Mar 2023 17:02:11 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20230328160211eusmtip1270d47cc2f9bd98b238cf47fc5736bb7~QoK42ZgMs0950009500eusmtip1C; Tue, 28 Mar 2023 16:02:11 +0000 (GMT) Received: from [192.168.8.209] (106.210.248.108) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Mar 2023 17:02:09 +0100 Message-ID: <970b8475-a52e-9adc-65cf-5a95220bd35b@samsung.com> Date: Tue, 28 Mar 2023 18:02:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/5] orangefs: use folios in orangefs_readahead To: Matthew Wilcox CC: , , , , , , , , , , , , , , Content-Language: en-US From: Pankaj Raghav In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [106.210.248.108] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLKsWRmVeSWpSXmKPExsWy7djP87rN/MopBnv+q1jMWb+GzWL13X42 i9eHPzFa7N88hcmi/W4fk8XeW9oWe/aeZLG4vGsOm8W9Nf9ZLU6u/89scWPCU0aLZV/fs1vs 3riIzeL83+OsFr9/zGFz4PeY3XCRxWPzCi2Py2dLPTat6mTz2PRpErvHiRm/WTwapt5i8/h1 +w6rx+dNch6bnrxlCuCK4rJJSc3JLEst0rdL4Mr4uryXuWATa8W3yeeYGxjXs3QxcnJICJhI 3Nz4lKmLkYtDSGAFo8T+hW9YIZwvjBKbni6HynxmlFi0ZyFcy5tty5ghEssZJeb+bmGGqzr0 r5MNwtnNKHFk0jYmkBZeATuJ/rUzWEFsFgFViQeHJzJCxAUlTs58AjZWVCBKou/2JrAaYQFn ic7Fk9m7GDk4RAQ0JN5sMQKZySzQwyzxbcpWsJnMAuISt57MZwKpYRPQkmjsZAcJcwJdd79x KxtEiaZE6/bf7BC2vMT2t3OYQcolBJQlfp/3h3imVuLUlltgX0oI3OOUaPzazgaRcJHYe2Ef I4QtLPHq+BZ2CFtG4v/O+UwQdrXE0xu/mSGaWxgl+neuZ4NYYC3RdyYHosZR4nz7Eqi9fBI3 3gpCnMMnMWnbdOYJjKqzkAJiFpLHZiH5YBaSDxYwsqxiFE8tLc5NTy02zkst1ytOzC0uzUvX S87P3cQITIGn/x3/uoNxxauPeocYmTgYDzFKcDArifD+vqaUIsSbklhZlVqUH19UmpNafIhR moNFSZxX2/ZkspBAemJJanZqakFqEUyWiYNTqoFp5RynzmWcXBGHDtxc63kg5swp0UTpvlS/ q+J5O/V/zqj217SScnmUXBXN69RfnvREsvJwVvvH2cJHCluEW6eaXvZYaHRxx9K5NYa3/j35 Jfavn/vvpZbbXCz2b++8+Pnu8NcQtsvuKWzFX9cap+aum+ixbsHLc+YJO48YTfQOWbTH5HT+ x4PRdr1+fpecg4wTGnrK1q06vey3zetDqt5sRnuNf6bNjbG/b3jywc5XUmcDF5tdN0qJsBOq WtsstG5C8ATGnvp909zqt2xi4KqQdPJY27Jxya2ATXaaS6tbDXdG9D9Y8oVV4canXZ4rIkW2 5igenvL6VLvG4pm2W7hPBk+I0An8t+vH27Oa8nF5SizFGYmGWsxFxYkAr25n7/ADAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t/xu7rN/MopBks/8VjMWb+GzWL13X42 i9eHPzFa7N88hcmi/W4fk8XeW9oWe/aeZLG4vGsOm8W9Nf9ZLU6u/89scWPCU0aLZV/fs1vs 3riIzeL83+OsFr9/zGFz4PeY3XCRxWPzCi2Py2dLPTat6mTz2PRpErvHiRm/WTwapt5i8/h1 +w6rx+dNch6bnrxlCuCK0rMpyi8tSVXIyC8usVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJ Sc3JLEst0rdL0Mv4uryXuWATa8W3yeeYGxjXs3QxcnJICJhIvNm2jBnEFhJYyigx6aE5RFxG 4tOVj+wQtrDEn2tdbF2MXEA1Hxkl+hc+Z4JwdjNKdG/+yQhSxStgJ9G/dgYriM0ioCrx4PBE qLigxMmZT8C2iQpESXw+0AI2VVjAWaJz8WQgm4NDREBD4s0WI5CZzAI9zBLfpmyFWvCcUeLw p342kAZmAXGJW0/mM4E0sAloSTR2gs3hBPrgfuNWqBJNidbtv9khbHmJ7W/nMIOUSwgoS/w+ 7w/xTK3E57/PGCcwis5Cct0sJAtmIZk0C8mkBYwsqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3 MQLTxrZjP7fsYFz56qPeIUYmDsZDjBIczEoivL+vKaUI8aYkVlalFuXHF5XmpBYfYjQFBtFE ZinR5Hxg4soriTc0MzA1NDGzNDC1NDNWEuf1LOhIFBJITyxJzU5NLUgtgulj4uCUamBi/Kdy 89c9DllBva1zvSWUpu+cwsnYJ9D8efV/yxgrgQiu5JKVXPOFX4ZOVcnXOBBXdcbwWt2ddZk8 /k+sBJaec9vWnRfxaZ7OnzkCUy9vUZW7bZYjvmudeeeB1Jwbm18qiJ1NNXnW+XTS7IiTbQpH lk/sehKQlrGs0WeV2cPpXiscDvjnqE+5uczkjQg/0+mGx766Cw5Xb/u59fl+vmvec9Q37tu+ dTO/QGF9yrmMN/v2qp730X1p/zDje3Xuws8v/wsYh76Za3N08jrP3X1S5iuvfVjTIMe2KN5U /DuboCHby+qK+taA8CfJYhaSd6xmhl1RWsdrO+P4dsGTWv3eYu+dm6sd1Lcweu6tnqGnxFKc kWioxVxUnAgAIoc0dKQDAAA= X-CMS-MailID: 20230328160211eucas1p15999058f9b91a8f58b22e648703641d1 X-Msg-Generator: CA X-RootMTR: 20230328112718eucas1p263dacecb2a59f5fce510f81685f9d497 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230328112718eucas1p263dacecb2a59f5fce510f81685f9d497 References: <20230328112716.50120-1-p.raghav@samsung.com> <20230328112716.50120-3-p.raghav@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8A68614004F X-Stat-Signature: 8n9whaxbcnrgo9zdwbd3qbcg9mtjp6ft X-HE-Tag: 1680019334-312975 X-HE-Meta: U2FsdGVkX1/3fdbSu6Bbkf80P8k7EqJf5G3d3ZvQyVFcW29XjpCBiZhcVpcVqz75B2M8PT3n5wEiABLhZF4CzSjJMf5N15tvrkei8JVXJF7NrlUSw/kccozidzOHS6cgXSIlnznjDrp0iFAyWNFUGmNvbSgQfWEZA5tqrqt/7ItiGw/qX6ZoZuhIV6k48Kj5Oc+vQT0IHaPnAC+VaxkJoLBjB1pBKLmoN2t+twOM0K0sQUEa0ScOb4fY+mB/iyavhJJwXqt3j0ZJY3sdkL/JPJYQqWkjMCuYDI/UjOQf7WfmhNB3seSxUlD8Uq20DcrS0/UxQyFjzXvdSMeX4sjtctAmqpoh5Lnj2Ufhgmt0v9C0OQ33tV/BNqNPxYh6HNHbRHJwN5rfrwYU0+cXj6c568bolRq83Fae8xIuc+Lsa3QQqfUB+vpuW5CusptyJLlogBQUCyjg0atvRh6yjTxPeo7Zh62avkjvFfPe8ZasTAeExRxcbi9Z/12EE33z0XQ66wEHZDIwED4Z+Yl30/sh+OAAEX7oLKUhWgf/SNWOhgxjqCoWlppVHVyRtnPImwVuvBtPgxJQgJPAFG78BEG8gT8E7v9gjVc/iT1jbmDF3KOp06MsbDb0RPsKt922p2Fny/fj6MeVDrt9fdpSSsgVjw3FEMW6ZAaTEeLeLahCbgS4GobSm5tJT1dUS+kc31aaUiIg1YsQh5mS8dsjZF+sLCdm4oNhxmbC20xyArQ33pjj7+1jIO5QGHDyJEzXQ2A6gNufcL3dOuXc7p+QQtTmPfFxqJXpEYkLS6k4OuUxsI3un/1O/RVObxDZ9IH08CkcDdLh3HT6vNOZlsrA+RM/1lnpiWQcCromUDBLEbwDhaK8/8siNV0FJgttvwVU4Jw0S5RAdTtISeJBOLzBISVgE38DEsXjBqqHOjJmPeKX+5/Q5AaJiaQ031cEBN2oWTxV3PAfc4UJHE+thTyjhQZ C2LMbyXJ CBPEs4McveaeGYLkS5r15VGB4+fKNuwsk7bYjMK3N/X4+1gknsPBg3d5A0l5zXBgemmY5oDwWQvwrKkfi6onMc/QRL4KQOYOHifIak5O+1V0ygw5zPfDN+hf5SI0yyXbNYm42ybkWu18Yao4i1ARtDR5MPLiMpIoxfSlobyAXVTGPtCuJdwMsvBGrzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023-03-28 17:21, Matthew Wilcox wrote: > On Tue, Mar 28, 2023 at 01:27:13PM +0200, Pankaj Raghav wrote: >> Convert orangefs_readahead() from using struct page to struct folio. >> This conversion removes the call to page_endio() which is soon to be >> removed, and simplifies the final page handling. >> >> The page error flags is not required to be set in the error case as >> orangefs doesn't depend on them. >> >> Signed-off-by: Pankaj Raghav > > Reviewed-by: Matthew Wilcox (Oracle) > > Shouldn't Mike's tested-by be in here? I mentioned that he tested in my cover letter as I didn't receive a Tested-by tag from him.