From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38120EB64D9 for ; Fri, 7 Jul 2023 15:10:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 990B98D0001; Fri, 7 Jul 2023 11:10:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4966B0078; Fri, 7 Jul 2023 11:10:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76C5B8D0001; Fri, 7 Jul 2023 11:10:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 65F886B0075 for ; Fri, 7 Jul 2023 11:10:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C0C340DA0 for ; Fri, 7 Jul 2023 15:10:09 +0000 (UTC) X-FDA: 80985151338.30.D3364F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 437A740253 for ; Fri, 7 Jul 2023 15:08:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g4VTNT0m; spf=pass (imf27.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688742514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kcc5BRyjmQB+Tg/fy6raV5yMIqWxapI/R18lSX23EDA=; b=bDHc8vQmI0VUskMyVD8jfCrf/OYdH5ECMJaXLBRBL+ybOb2gornVPBtPiOw0C9RaLoUqgu pLuLaptGItnt4XTcEBnNnBW0YFOU2YbGQGvhZfp9gSlFJ5FQBfES8Wv9kvxIbiFA7ZJsS1 WuG/Be/Ec8wlXHu4uFmPisQVtXnQqHU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=g4VTNT0m; spf=pass (imf27.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688742514; a=rsa-sha256; cv=none; b=gS+C6dpsusRNtlKLnlbMgYV2EEf9e5Q7xBlvKil8gGTYuxYLdPogIMPxk1NtC67XmL4fWI Pf4Av/bf8vQmzwpvNGuMiITxMHyyCfV/ogATg1897mfwgQLH3GT5GncRqVxwRboR3tR5pV PEgPFVCbGH9ZQjpt49f3Gb4/pd2bOEw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 148AE619FE; Fri, 7 Jul 2023 15:08:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D79DC433C8; Fri, 7 Jul 2023 15:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688742512; bh=Kcc5BRyjmQB+Tg/fy6raV5yMIqWxapI/R18lSX23EDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g4VTNT0m6XKStzKZRJRuNZgU0aQ/+ItOHdFDq0ELIJwcJczeuDmNbRcSR4opAmgfj pX93UNqUpq6kuKnn99yhPPOmHKEQqI8F5xtOjanjdWMvq36pbxp0LIhzGEdNi6/v7m FR0dA86d3Te/x61CbmbOKhcS6efgAAQJTrKgg1OuFLMKYWFej2eErlKe7rbZQJglUj No0e5aEexz54+ZZrEhRPso1aTNBkSa2OVu37uoewpGLMEr+tVLUmNN3+1i+dS6huyr UkuJjnl/90uotHktcCGkUsLZju1h3hj2gkykT8mb+fP82EFx+s4pDy7sP0AdWUqNFU ZnD103wnnBfjQ== Date: Fri, 7 Jul 2023 16:08:20 +0100 From: Mark Brown To: Rick Edgecombe Cc: akpm@linux-foundation.org, andrew.cooper3@citrix.com, arnd@arndb.de, bp@alien8.de, bsingharora@gmail.com, christina.schimpe@intel.com, corbet@lwn.net, dave.hansen@linux.intel.com, david@redhat.com, debug@rivosinc.com, dethoma@microsoft.com, eranian@google.com, esyr@redhat.com, fweimer@redhat.com, gorcunov@gmail.com, hjl.tools@gmail.com, hpa@zytor.com, jamorris@linux.microsoft.com, jannh@google.com, john.allen@amd.com, kcc@google.com, keescook@chromium.org, kirill.shutemov@linux.intel.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mike.kravetz@oracle.com, mingo@redhat.com, nadav.amit@gmail.com, oleg@redhat.com, pavel@ucw.cz, pengfei.xu@intel.com, peterz@infradead.org, rdunlap@infradead.org, rppt@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, torvalds@linux-foundation.org, weijiang.yang@intel.com, willy@infradead.org, x86@kernel.org, yu-cheng.yu@intel.com Subject: Re: [PATCH] x86/shstk: Move arch detail comment out of core mm Message-ID: <9704b6a9-e7c5-4d50-9567-9e23906aafdf@sirena.org.uk> References: <20230706233248.445713-1-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6nP9Wo8Ehv/TVMQs" Content-Disposition: inline In-Reply-To: <20230706233248.445713-1-rick.p.edgecombe@intel.com> X-Cookie: Victory or defeat! X-Rspamd-Queue-Id: 437A740253 X-Rspam-User: X-Stat-Signature: im887ke9emfnac618td6dcmwxbcp7c7o X-Rspamd-Server: rspam01 X-HE-Tag: 1688742513-573435 X-HE-Meta: U2FsdGVkX1+0Zd/xLYJnH3mCV5gnWBo2I9VoRdHx+Kbp2g8NBWVwhDJtKrVxxOXn2wuXE75HWEt4MWNoclbGKiNalyELDDP6T0dqhRjvkjzDeP+ZXgL8wsI8WQ+Sv09sniZEHeNwQLW+2+MfgVZBdUvs47+ynt2v94qYd53m7GF/0qJBmZ96EyYOOyd5Nkzh1PeLgdfXgUtsto9oyT/OkfAb5TNt1zlvyIcS47JSlXK/7MK0UDh/O+KmOdKa/G59c5WeWYa2wIouW/rOBzXHCdv6sUg6ea0Y3UmCBT1Juonl9HTNcL11ma79F9eP2N/o/0zM9KQEuwxhO4kThX2YxIeTggCP8aK2Omx0LGnYb56eMZ2yjDIf+RNSf75qz5KBqrh2N+WZgI8j8hl6/xAaty+O8X3ls1lNNg0ZC57UFviWSUepo7Ob65xxFXgm+1N+XN/PkhMRxn5Ld8fRIUlbGdLS1ll///O4ObBYoU1kzvXgIi1N1rJktscydgd7sgoxNg4h81QsNQDyPzqb2jae4t7fY+mo+DDxe+iHzH8bBcqpByPbXQgp/b4ZSHEZ6N/89F2q4wjEPpwNHn6N+c1zmCMt0rVooJInz7aq60FPlKk9V4KwKqWYsZbObq6AkSnLkRyFUPl8m1wjZuCCW7r0fy/YnEo1XuryJgvfwVUopJ1zBjgJPEj1PNCsHWIWYwCu09aj+C8StSb4lkWp7vydO1gaoEbNCw6FtEcjd/tSex3rAfsc+03iTqmiEvzX8pnrlVql22+j3qfrxKN9TdPvdur/VuOySpV/qDw2QW+MoCNgz6tNPHV82zIO33h5Uqd+hk1VE4iwopry6lHbrHwRSSxBMQVSxTTqNQqmfBIxtjU7he1wtYX+KXkQNAw5FT27luUTALzrY1xZajGWRRV665Pf9ZiSJtGk9bHlWeiPHTo2ygjG5Olo/cSu2uZV7nVxobiReflK1WobPgGjsMc oQZgsJlm 4Rvz7AQi11R+z79epEtdHX6/Ut+18LZ48gjlm/Kqp0LWPe/X18N3RDT8EJO0nMtLr2IM2LxO3YegNVzmptawlszTOr740mQdBtWMOyOMvcurha6Mh8pBWFWotAMs9hSg+3C06zqGirQZ4rBl3rFmezhO9LL+M/HSTsWvPB9hm8cgZ3wOudbToyskmQb/ECqpIjvcwSk/ENpDriOIeubM+MnMMNIKKQ5Ocf9rlu5iELVoPmQ/90YMGSLffji7ZpalD2FrVv9nZUg4XDrrIbNroloFsuigptQvwxW+ubXTTxlQK5z1bBhhN/AeGH4fyWJcv9gM3Og3qoDHpn1cDssEdaOTe/znp+btgQTBBwuoO9nfhJluo5jFV1zSzbFv7QVXwD5B1Obmr3OxnXC4o0Is0B6ZUok5dVMZW/As5BbbYODhbeNAGZVEUm+i2BsEqWcyjiGwHOdkyKMm0VwmdUl2dnVnrnAPariyo1/a9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --6nP9Wo8Ehv/TVMQs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 06, 2023 at 04:32:48PM -0700, Rick Edgecombe wrote: > The comment around VM_SHADOW_STACK in mm.h refers to a lot of x86 > specific details that don't belong in a cross arch file. Remove these > out of core mm, and just leave the non-arch details. >=20 > Since the comment includes some useful details that would be good to > retain in the source somewhere, put the arch specifics parts in > arch/x86/shstk.c near alloc_shstk(), where memory of this type is > allocated. Include a reference to the existence of the x86 details near > the VM_SHADOW_STACK definition mm.h. Reviewed-by: Mark Brown --6nP9Wo8Ehv/TVMQs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSoKmMACgkQJNaLcl1U h9DOVwf/Y0zWXHXNC1vLAm9sKmANgUpp9G9Tqrm1x5ddbXJHfCpcA5GUW5fG4lXa GYCDJ1gq8Rlt84gcZU+mPC8evLuDsh7gAysYhq0HcNJOqWr7gYi5/5M3JVrdCUfM iMP11cx6d71lxhKkI3V5TYs6D4sX9UJQlD3ytefHHFmZNyouWx3yRRerWukxyNXY oEa+zZP8MxfY1YKd6/C9mWisi5F10DqRsxc71IU7uoovWT37E9Qy1Xsx0+DBqyq3 ceF3B+z+tRbd3CFLJfotCxxiFkhOLq3GJlD/3/aAGS5hJPtrQ7Qy+rwhbQ6nGOfr A5+bDsBsdcVJmhjoXp/75wDbyqj0Jg== =inrT -----END PGP SIGNATURE----- --6nP9Wo8Ehv/TVMQs--