From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2947EB64DC for ; Tue, 11 Jul 2023 07:21:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F2028E0001; Tue, 11 Jul 2023 03:21:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A0A08D0001; Tue, 11 Jul 2023 03:21:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468A08E0001; Tue, 11 Jul 2023 03:21:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 362048D0001 for ; Tue, 11 Jul 2023 03:21:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C251040148 for ; Tue, 11 Jul 2023 07:21:36 +0000 (UTC) X-FDA: 80998485792.01.1B7369B Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf12.hostedemail.com (Postfix) with ESMTP id ED2EC40015 for ; Tue, 11 Jul 2023 07:21:34 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=otST6ei8; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689060095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=qnbr+dmgbeeJCeuJwmdO09zJyFgOVNXALEjnK2gVo8I=; b=304BjRp9nn+4XnPY1uk4FD9hTQ/+sjx5Mwoeguic8DJDNF6loMsO7d6ovP8hprj3Hfd0/E loCU+XnMYY8Ql0WSlO55sKamjJD+O1Avxdalw+NebmdByLB86G4F/LcxrXsx3BV6nv/Bc+ 5DUmGKX7/ThQ/gIQdYKo1LLMFLto9NM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=otST6ei8; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.44 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689060095; a=rsa-sha256; cv=none; b=IsMKf2ihc3yagbjWTl9PLRVJZeZH+iDop4RQsGEurtjDOmW17G/1QKmQ6ZeWJi4cncPHFK nrOzfRB9np6ZlV4rrFMjaDuOfL9QpHhdUT/YrTHPLp5bl3iC+rkKRfii4pDTjv4pUlTjgv dO7fX2QqBkP3+rPf/5XezhwTONIH/Wg= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3fb4146e8deso67059665e9.0 for ; Tue, 11 Jul 2023 00:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689060093; x=1691652093; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=qnbr+dmgbeeJCeuJwmdO09zJyFgOVNXALEjnK2gVo8I=; b=otST6ei8d6maAnt17BwaPV6PL3tIRmEfqjyvgdk4OxpAgUujUn5Cmy8Q/t7QK9Mjyo oXOY3Oh0sNNeyTrayqb38FUzzTS3QiGyizHgsHaiC4lyXWqtEhhUr1HuCe9Q7E5gyL9+ byPUz9H9WappzRA3YlWqfpitNn3t6BStyijMdtr1ZQvMAQ+GnYN/BgxDgbDI6qx+aSpg rUAi7NMEC2cUs5X7VhB+t6dNrKw392GpIOqsbSR9DRPwQmNOyciC8HMKGgkdXx4oQ6Bv f00XFgWiOoiGcH31Illl+WbIQihrkar7JIcWirFU564SKy7ePrzLQA1y7pyFJE8byo+S v35A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689060093; x=1691652093; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qnbr+dmgbeeJCeuJwmdO09zJyFgOVNXALEjnK2gVo8I=; b=V3Uh6H59rkqKLINx5wyM8zUVL+x4v34u2Zx2tGwhLoLT9KF1gRvs1IR1f5KHNJ9S3l CAL4XmerDHa3Zd9r4MRYYXvAxC2E26NajDRC1zWe8+ThYWeESuyizhBW0+Oc5PwAQX/l rNoEx06VWf5LC1vWy9DOa3XroAEpVitVr17LV0vhAmRQz8YqC/n++ykPUdmEiS3NSMrc 84cMT9NS0vCN2afpZ8Kse01odH/bzJk+ZxvVMjU2CvgVCsFjKPbU1me9V3p4EeHpStpp ymtazl7i9y2LiAiVSa4Dp7T4g/cKoBicYLid78rfMg9t04JTbhnoqy8RQ3B+86B1IjTM oODg== X-Gm-Message-State: ABy/qLahjJln69+bl54xKCSnL+e9aXv35VWhw1et/bNIk987uLZhA8Tm IU7rjvKeMKnDX3Aupd6DFv1F0Q== X-Google-Smtp-Source: APBJJlGvCYNQliBDx2iXGxVTO+tIr4EQtf+hTLDZyP7onf/xcKjTLDy29knpyLyqHlWG3SpmE0FI7Q== X-Received: by 2002:adf:f604:0:b0:313:f6fc:1f48 with SMTP id t4-20020adff604000000b00313f6fc1f48mr19408371wrp.14.1689060093220; Tue, 11 Jul 2023 00:21:33 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n12-20020adff08c000000b0030ada01ca78sm1444714wro.10.2023.07.11.00.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 00:21:31 -0700 (PDT) Date: Tue, 11 Jul 2023 10:21:26 +0300 From: Dan Carpenter To: surenb@google.com Cc: linux-mm@kvack.org Subject: [bug report] mm: replace vma->vm_flags direct modifications with modifier calls Message-ID: <9704a138-60e6-4ede-91f0-844e1df2ad84@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: ED2EC40015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wi5a8y5b4kcchcr1orjhg9bzmsw1xo6d X-HE-Tag: 1689060094-57154 X-HE-Meta: U2FsdGVkX19iGHWSrNFCiF8lNKLzF7Qq21D/5Pp8lRzk66LEXBAkLCBbki21ZNoVthhu1+Q9yuzjCNoLLyv6sgxs/IoLJLlt+3MCqHgCDgnr/pfZadid11C9iHjmjcd97NDB83qGd+w6h7LIV0tKff4JzCSOz+dsHsA+biVqSO1Fw8IuGz9/HLd3oDIz+3RBl4ZlDc8EzqB1IjsBQaa5CSuVSfheHY/Iu6dIaccYWKyS9Zg/qPAXLj2LZxkm21uaGRxViuTlCj9yNqX0WUNts4B4o3fzX4uf+7bzWZjaq/BSP+XEQitE6n6xSoVgo96ELzFznAOfM1b2Z0aOlqSAUH4cTH/mfD5EPF6EM7xE0J/1bjKOl45ao2Ri+rbhGFyP7WgPlFW+6/8EH+UzdXCWzldF813jqDl3XKI+27ZR11OClHlYLTKaYQZzc9OQ8t+bUGab9P682BYGMRiiOh8LLnhc7eHLvZ5N2CWNrGJjs6k0uqypgB31vGRox0kDyhVoFREq3ld0JFEIRTL9Hos8WwS0uhmiTisyjVzhXZ/c5EYqFu2x3TCDacTGZPP/FvLGk2pGUCH+2HNc3ybwTa4Fq5TKMfi1QamKad/mIo4sVDv1M7hF/aXwNfBzIBzRIoMLudgFkEEMrXgRO4S7sG70hWBFtLHdpzBA8rvjqAtEVEwil0VuT2/CWfQsoWsksUWih1iCoC5e7cBdMtszlBdpV/aZFaABRkutfGczFqWx5LgRE0jQUnKXqP073FMznzLJpPr2Fl4pdLs5QzdmqJdMguFdqWbR7TebOHTCrVV4IQdnVbscC62mHSo/BG6BrYhDoua+hs1pz4rFiXO53ew4A8ZfHFl8Cq8kGbAlstU9yun7V0Gs9KRasEdq0JULyULVpn5D3R1CIV/2S2CAz4Lw+e6vDKdBNb5HW00kdtNmY/75/1htRSzjXM3q5wtbliDEv9WZ6ry7JsEpwOSI5BH Puk+mILk IsIHFq3N1s5G3q09Ei9soTY8rGU2HfNMXvUP9Z4yhhM3pxso2qilsAHrTOZwP8bEAzyozQwWNLgHIKRIPujY4RWO/5yvy46bIZIAalif0oLREoVv32rXTPJ3ChLr++g3738Gwph0jhPObDp3lpMiCfQDvqIOQvk7DVOv+4sowcTyNxySPYOGx9JR9+sIQdSVqj6qYtXsiwuMUuJK3NV8M60sH1o+YBByeFMFgRY6ooasg2zSXgHmzzFVUNA7ImnFzFQD4Q6XGkCQ1izqR96hHI0OlP/vnAc/ozytZdt8SwS6KqILBAMWX2izHMlAOPFtKljaUoauM6+KV7WgxB6pN5ZtD3JtLPRqid1od X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Suren Baghdasaryan, The patch 1c71222e5f23: "mm: replace vma->vm_flags direct modifications with modifier calls" from Jan 26, 2023, leads to the following Smatch static checker warning: ./include/linux/mm.h:729 vma_start_write() warn: sleeping in atomic context include/linux/mm.h 722 static inline void vma_start_write(struct vm_area_struct *vma) 723 { 724 int mm_lock_seq; 725 726 if (__is_vma_write_locked(vma, &mm_lock_seq)) 727 return; 728 --> 729 down_write(&vma->vm_lock->lock); 730 vma->vm_lock_seq = mm_lock_seq; 731 up_write(&vma->vm_lock->lock); 732 } The call tree is: gru_fault() <- disables preempt -> remap_pfn_range() -> track_pfn_remap() -> remap_pfn_range_notrack() -> vm_flags_set() -> vma_start_write() Before track_pfn_remap() and remap_pfn_range_notrack() would just do |= to set the flags but now they use vm_flags_set() so there is a potential they could sleep. regards, dan carpenter