From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9067CE7CE5 for ; Tue, 1 Oct 2024 07:54:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5C02280055; Tue, 1 Oct 2024 03:54:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0BF8280036; Tue, 1 Oct 2024 03:54:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3881280055; Tue, 1 Oct 2024 03:54:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A51D1280036 for ; Tue, 1 Oct 2024 03:54:56 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1F4BAA0E5F for ; Tue, 1 Oct 2024 07:54:56 +0000 (UTC) X-FDA: 82624272192.25.2AD7240 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id CFF99A0003 for ; Tue, 1 Oct 2024 07:54:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWEnV2lS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727769273; a=rsa-sha256; cv=none; b=rb17vgdrae3HDN40/q+qqLSYrHznYwkyn3rzbmdk/uOaaZR1Px7PAx9KH5NDe16D8RQmuP kxDV7sjSPONRvB1UteZ8WlJ4Ka/XvOU3M2vY8y77xJjbKoR4Q/OwR37Wp0Z2dPQk2Gk11Q idbCP+WCliuzXWnL3iuhoMJAbD3pISA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OWEnV2lS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727769273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZO6QkXYyC82VYzud9nrAxDBpX4Cm8WFePoqgZa4dOOc=; b=ftuivRtqaQDhsBMfFPv3KXWlj8t2c/IIg06xHHR74Oxdr2fVPRSt15YeKHmi+meKyQ0hwD BftGGYq3AUa0rHoTp/Kq4Cl9jYY9j9Jji8fxl3Vpb/mRfI0bfz4+CBPhw6RGThG1KL8DTZ MnX0rZ1diDp5IqD2kqHb5rhUSOq9tDo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727769293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZO6QkXYyC82VYzud9nrAxDBpX4Cm8WFePoqgZa4dOOc=; b=OWEnV2lSIr33hn/908nfMl1N5G6v/REjjzNfmFdROZhLx8Pp94QxqurvcMc1J1TsL4anWu ato7a9/lxHcEwktdm4mbiP0jLKKEWBc3K7dLQ40mPfPhBlILfP62OkDpIil6FkubkBvtqN yjoJqhU1ZIudJxlU+fjDxElbt4uqvYY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-n2BlHDBYMtKBUSqmBdDl5Q-1; Tue, 01 Oct 2024 03:54:49 -0400 X-MC-Unique: n2BlHDBYMtKBUSqmBdDl5Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cc4345561so29550605e9.1 for ; Tue, 01 Oct 2024 00:54:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727769289; x=1728374089; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZO6QkXYyC82VYzud9nrAxDBpX4Cm8WFePoqgZa4dOOc=; b=h63N6CcHhsWsywJJD6upZ2As9AyiWa7GalLOeqmriXK/RmZAtGKheigxxRsoC0e/SL t6/qF5i4CcKKAaHU/2TUP41QmqKo7expGZmWPjyo1EyBCwy0vQG7z/4l2wIFiONkRGuA UlJ8AjuYyeKpzUCn1X0478K0G0jpI8F+fMVd79BOrjVvTEUPxGy1qlwyKAELdjkHz43T Hq60bV56D0fMXH5yX8Jrc72lEUDkTu0ropiaUEY/Wz088sdyVhL1ZMwn2RCyqsvJ1PLw u/bdXuG/XhH68igDnpuXqh4eeB9FHmbLVVykKij/tQiEF2XP3crGDwPnJIzdE/VSBLfL 5Xdw== X-Forwarded-Encrypted: i=1; AJvYcCUZMmECm+B4zYRqtmzojq5nOSh0VWljNCpXassds28Cnl6vN6f8mk5SJAXXB1p4PrSWjfFMSq6Dgw==@kvack.org X-Gm-Message-State: AOJu0YxK907rxm5/NVQXrLLwsU7aimmXa3p2jk6Haaedwn7Zem+3UQYO VbznKqkzqTiV8DbAbpFJ3K3n/3fmFxGA7T5q5Zox5qmEwzrUPHaRX+RyXNTqy0jepV8VNjk5KJ+ wjVx2meqJwvddo7XVV2JoyQU/4sQMxDwNYeSxY90FCrNWd7vi X-Received: by 2002:a05:600c:458b:b0:42f:520b:1591 with SMTP id 5b1f17b1804b1-42f584870b0mr106325515e9.24.1727769288704; Tue, 01 Oct 2024 00:54:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGR3ptuIF03QZKWCzgBMu033TB24qXL5bgVyxor4vvRrqvhv947rEVkFXvq82emjXfQlHNu+w== X-Received: by 2002:a05:600c:458b:b0:42f:520b:1591 with SMTP id 5b1f17b1804b1-42f584870b0mr106325305e9.24.1727769288250; Tue, 01 Oct 2024 00:54:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:a800:ea78:e754:1995:5390? (p200300cbc733a800ea78e75419955390.dip0.t-ipconnect.de. [2003:cb:c733:a800:ea78:e754:1995:5390]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57dec110sm126585615e9.25.2024.10.01.00.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 00:54:47 -0700 (PDT) Message-ID: <96fd7bd9-3525-44e0-b797-55d4e82f9c37@redhat.com> Date: Tue, 1 Oct 2024 09:54:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tdx, memory hotplug: Check whole hot-adding memory range for TDX To: "Huang, Ying" Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" , x86@kernel.org, Andrew Morton , Oscar Salvador , linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Kai Huang , "H. Peter Anvin" , Andy Lutomirski References: <20240930055112.344206-1-ying.huang@intel.com> <8734lgpuoi.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8734lgpuoi.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: kmneph7dom7dhxm97zmoky5uo4jg1eyb X-Rspamd-Queue-Id: CFF99A0003 X-Rspamd-Server: rspam02 X-HE-Tag: 1727769293-53917 X-HE-Meta: U2FsdGVkX1+JlQfsBa5SMGxrMsXYmtjoM1UFFhG7vuzYNq6PTgkwOhJ9rqAKxpyQmo4gJ4QJzWDAyUhiEyZjgWfxBrhXPhBRI6GrpThNcajfVSdfRoseeBh9zthpSAvnY6UV/vpOxJdbT63SdHwiiMFxtdiPJbYZaAoJNan4HX/F79gAIufw+fD+a4Ipovf902GmXK/mUtAER9e4FWHEYPyCLoglKOQy1lnb5c9qHmxYK1i569HwGMLh4dyTFMxDdgfi4usWIe43ZazQUdC4vhiXVsQ83z+qKhH+xEPG69F+1N//6L7PjrgjbFwg3CDPXGF88Qj8FtLYLz1XWnbvgFL3GCepXciqj+wQ+WE9eRfVMuqSSwjdiopZdH5nC5Mbp/Uwf/8oDJ5vGuuDlpJW8ixURZwx3kAHZeh/DRvgjhG8hKnXb6voqmErMdWPB7wcQPx8+tN+RZ7LtAupENNC5zYCYihEj2mSI5CbNGtC3vrVPPtZ/772AXTRrxn1suS0a2t6gRAddwauFMaMDJK27OQgkGevcLqubx0EzToZ88rviDqOa9GNB4yKayIU7hGEipc4RSD7+UgLw3MWgA9HwnAFWaMTHIbPbcFh/WSek67C0X6lGvUbg1GlXcFdxhl4iEAxnoY830mu4Q3uTkv9PZ+kyLYbvJzVHeguZ06348CqJZWfbaqs/ctjTpNCjdstvGdo4Zgz4uVKagX/DsfWtkSO6uYvod3Qmu8OCwlbJVpiXfrjScSyqL0ss3sA4vvCejSgZkXGWey3pACN17KPzCBESSl+UsirAb2MlqKFZuTAPsK8/lO5AbuFL48fa7ODnlzqUwGMG7o2G0pqjjuLsgskmJzUnuuK2YhqlmAbTMbINa91mL9rl9Ckp6WzdHBfcOwPIffrs3p5cZqIGLpmcS94SEX+2mwc4p1kWHdnodqkbe42KoXV6jKkcVw3PoyM12dlPfjtkmc/wowarbd soVeQpA5 YdA+Lu23cAlOH0tkFdVH08pW6q32zksvYJ9u+6byUa2TSWdXKqOEGIxU4iVU7GPXzqXL+BaET5EHY5Opz33DcyiNjz6iCrLoOoe+gguME2jxXZJrN10a1NTklyQ2IJbO8AoGDBXf55o3Ur1ZogSoc2GZZFn7qIH7lEYAW1CyqK1zj5wldLcjnT9BQcYCHemK4VQzf4coRoJxBjUgTV94zBXxYZlEglGtn70I73I1PcomBpKi6Fw1M0c7GSYxDxtZnMN1IY2GshDuJXdc4HNcmr618TCy7xX/8/cnzIe88IRK3v+D8E/WOvWpGvKQONhIMpoJS77eGa3jCX12X7xxP76M9ZOJrUJT1Ro/As6tqPuIhKOoP5J354TJKT9WUscnMUrs+wRjJR+ywUys= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Because only TDX compatible memory can be used for TDX guest. The buddy > is used to allocate memory for TDX guest. While devdax will not be used > for that. > >>> This also makes the original TDX memory hotplug notifier useless, so >>> delete it. >> >> The online-notifier would even be too late when used with the >> memmap-on-memory feature I assume, as we might be touching that memory >> even before being able to call memory online notifiers. > > This should be OK. Because we will not use the memory for TDX guest in > this way. Thanks for the reminder, I keep assuming that we are hotplugging memory into the guest, not the hypervisor. Having that as a comment in tdx_check_hotplug_memory_range() would be helpful: we don't allow mixture of TDX and !TDX memory in the buddy so we won't run into trouble when launching encrypted VMs that really need TDX-capable memory. -- Cheers, David / dhildenb