From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27775C5B552 for ; Wed, 4 Jun 2025 09:38:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9A918D000A; Wed, 4 Jun 2025 05:38:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A72B08D0007; Wed, 4 Jun 2025 05:38:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9615D8D000A; Wed, 4 Jun 2025 05:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78A758D0007 for ; Wed, 4 Jun 2025 05:38:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2B59B1A0D99 for ; Wed, 4 Jun 2025 09:38:42 +0000 (UTC) X-FDA: 83517218484.11.5C58D9E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id BE13612000A for ; Wed, 4 Jun 2025 09:38:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eUasG4cH; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749029919; a=rsa-sha256; cv=none; b=RxFxxRb6NrAcSDyumsC0LMPC6373Ng3e6+dB5BjBY6Kcm74mXlP2be8XDiD/LNLo0RDYJj NFX47MaCJ63IgIkP6NKjlcxxZIRS5A4WNdmRYsvqGJ/JgW6+Z+h7oIbhOzjwbfaZzJ2Hyf kUJGJkx5cRI06Pljt+M8PSJ4hzJuLYw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eUasG4cH; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749029919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gpx6tDJBl4ZRNXlwEZ3goLD9Mt+7BJdqf7MbNFs2CXM=; b=JqscFReQXAi+GLVi8aMAMnKrK17co+PzCpQteYwXz6KLR7HnpTUaZz4dNdtmFz7wlPRb90 PjfBC6Wocq1869/728l3UG+sxS3HF+j9m4rjQVSWH1XemzXZZAZqyhsMWTds0l5WjgVf4G cFgyLCUzFfv9l90qzO30bfleBdM+nc0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749029919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gpx6tDJBl4ZRNXlwEZ3goLD9Mt+7BJdqf7MbNFs2CXM=; b=eUasG4cHpU/hJC6BukWLzg/YzIMwF/teLRcjLvl2ia8Wv2bnzpn7/N2fdMcT+ZFUBBYTkM NfGkV68r9DedKKnQrWp6vXAhxIMr8Zq8vba3s3ykUaqszpEVqQ9/C3wLjeg6izRgbw5R03 g5IISD2d41AeARL8pgsnmrQAezEL4hc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-Yl1x7gPdNj6O-r_8MoQcxw-1; Wed, 04 Jun 2025 05:38:37 -0400 X-MC-Unique: Yl1x7gPdNj6O-r_8MoQcxw-1 X-Mimecast-MFC-AGG-ID: Yl1x7gPdNj6O-r_8MoQcxw_1749029917 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450cf229025so18710735e9.1 for ; Wed, 04 Jun 2025 02:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749029916; x=1749634716; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gpx6tDJBl4ZRNXlwEZ3goLD9Mt+7BJdqf7MbNFs2CXM=; b=kUpcJIvpd5WcrUPYr8kXwndhDWc6X9R+RhiE92TasyQ5Np75RFHuUbzfPM6GL1odrr uJlr+sxFj14MNWxs6u0q8eWGeC6w36hRUi8V2gTt9npoTyqWe9qv+ex/aYFzMYjkIBKp JSc9/mAkH48K12ZACP1fNYiPwUoDPrpAtMPu7h90Weh/XtRIfPF+d4/7pPvE1SizzLPV 3SRGSc7499DZWLORmJenqdnNEKOm97pP2i3un+TM7Rk3Kg/0FHIFncAULUSET3YkiiXR B3BNZQQgMK6FVl15mjJh2nx4ZCbNnXBjGux42sVu3Z4Cr8DVCRLzpSL0pJ434Qtmu1AC cV+w== X-Forwarded-Encrypted: i=1; AJvYcCXnEM3DdHem1fNEg+8vllEOOMqHLyPnVfp0bVQPUzff59vJ2ypn8k1pzKocKQW9RVPXuL+TgG8R/g==@kvack.org X-Gm-Message-State: AOJu0Yy4mAy7772u7/CQ9pQnZZsFD/i3tX+ybZVmnGpRyXGo8zRJFTPI sKMp/2NPgN0loOJtYIhExrnrkItTTzNDeBwyW3oZ/m7Cmkwct9iXMgSeH01Yjm2evDtx3z8woNE aTRMtU3YnrKf/japQV9j+y8B4keLRgQ6GI0XrrFmBhCd1ifaL//Tr X-Gm-Gg: ASbGncv4HIUtbaVUwdAtnpzQop9z3CU/8eGRAJs6tgGPEQd9KKea/uyv9hEKZmKE/8Q w0flCMQMzOTNA4vVM4MIuWNlQp06KTN/2eBB6F3oe0n6nDbU/O0zrTRf3vyt+5kCAIHiS2hlUEw JCLsLTE9jYhNnjnNSzOplkktbirg0xENgnSFrRBUYhXk1bIr5JuOfNU9XOAuvlkRt5bjzZ80yiy wInVl4ajivBqhI3pWQHHsTyzfcnnYhruYIfc2hXw87CrTYfQLagcRIM3j9qcjYDXzxb8rt8wF3C +I1tJuPobeJy/kpNnwR5cTlrBhI2aa3wZ1OrluUeceJw9MSEF4Vb9Z2jab165AlenBtck0v8Hys NVP/d8LM7QZorN9Tl9ggs+Wk0Ea3S4tJwV16jac36WFc+ilGH1w== X-Received: by 2002:a05:600c:4f50:b0:43d:fa59:a685 with SMTP id 5b1f17b1804b1-451f0b3d1fcmr15529355e9.33.1749029916566; Wed, 04 Jun 2025 02:38:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhDvqnvGf6Bfa5YlLoHbj4qrKSXz6KWAdlhxSHlVgnJQCckFPOWc4xRbzkQI0ut0NbKaKj9A== X-Received: by 2002:a05:600c:4f50:b0:43d:fa59:a685 with SMTP id 5b1f17b1804b1-451f0b3d1fcmr15529125e9.33.1749029916092; Wed, 04 Jun 2025 02:38:36 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fa23f4sm200336965e9.14.2025.06.04.02.38.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 02:38:35 -0700 (PDT) Message-ID: <96f7d3a2-2d85-442c-a9f7-e558d4a2ba06@redhat.com> Date: Wed, 4 Jun 2025 11:38:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/5] drivers/base/node: Optimize memory block registration to reduce boot time To: Donet Tom , Andrew Morton , Mike Rapoport , Oscar Salvador , Zi Yan , Greg Kroah-Hartman Cc: Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , Madhavan Srinivasan , Nilay Shroff , linuxppc-dev@lists.ozlabs.org References: <2a0a05c2dffc62a742bf1dd030098be4ce99be28.1748452241.git.donettom@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2a0a05c2dffc62a742bf1dd030098be4ce99be28.1748452241.git.donettom@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GOa0OdwoRjGtrImzzghL0b4jLbRTnU96YAONgZLnPfs_1749029917 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BE13612000A X-Stat-Signature: b1qujt7j9e5cjgata66mdkn8njrk1eo7 X-Rspam-User: X-HE-Tag: 1749029919-322068 X-HE-Meta: U2FsdGVkX19UtoXS21A4n8MvI0iJyf6sU0rqQshhkLY+RNWbt16N3YsjMCc6swTj4Mk6SK1W/jcVlplyKfFR9iizmuTDlhBcwcoWHw0u4snVlY1IO+zSGs/vYsv1m4sIndZnip23YNyXwxtRmva0aWqXjVeBXwpNiuMYC3HMK80Xys4ZLB0zduPI02Nba1qsXdOa1xxbygTqgx64ErIUv0zxYFzgkt7aBDjiUYtpyeB7TBTG3QYtDABBkh8dzqVeeZMqcT74f5+640xZj+dr+fLBSr9nu9q/8x2spaJXxzzqpTnf+3/yfPFOKe9fCEARmQA0x9SOP8FpN9Yr/F1toyR1/YF7rSM/37ccVGCCOlVG5O+5vy0RX++3+GgdY4Ltild+3At0SrTUfflnA8XKYm59k81PCgrqJ8eA6YGItC7MvVrabYxrGqBy70nTwH5FQAtk0R+/Jvo+J7cDf62cBJGqSztPVrL4xzprc9vaEgU7Z6LA6IOZtvuRgrqCw/yx7j5IwUOwkmUpiIh1YLd7KdekiTXBcKcFLKUaH9Xvqyfz8BLNK/3ZmGfnGu+WZ9hxBP++NZqanUead1FoJoRSoS6pnWOivRixWmn0QgqF6Iu3poMrFXtpQJnyaiAz4dXukyTPylZzU4FahxCECBilxXysUnKRN35dmVQmkzCXhRO2EVC6Da8Iyc55cqMTbnZFA6WXRpOGWsvrDcfQQ3pj0AdeiznsY4oypNgCnNQDulB/lrdQBjNvmRpjne5Jj7gUg2WkwVLn18pmBQaJUZYbespq+r2f3DZS/eKAppBt0IFOYo/PiPp1vY1F/K31uKj4b3K4WZN65KjafUdGQM9q6fJd5SVWeLZW4KOEALErmZoHB8B184Js/PpgYUT9Uzsub4T0KeAH9sa4kOoJvfnsDWn0Cho7KdHugrU8EGHJ4/N0BXlY81snHKa/86LxxtyigkBtCbRMT0hpPtcVznR eZTWGnhW ZcCBdXeZxLnOWEPWvy5MPBciO00YWl+dF6t9uD1jbhE8el+mLVXPsEx3awhAvmSuxCyX2COOA8gnyFk8gJvFZtUbO5d9Gk0/HhJKenkFlpOy0R7UOXBurFKpx7x0Mh8p9n/qveCCcTT94iCfSA3+HP8whEHoZKywfsvMCOXZwhVF/mKjzPcxWF9fIoVvU6UIXwkpnlToLc+hs6+mbWmom5G1pfMdUT8vEMiClqRTlo3A9kCku3heFsRvcYsXridsvmp5CJzxoExCwhnEujfW8hYGga4MxEvPQwk68gKBvbAvpxulAlgLa5HVF8AhUYYZktXGnAVa64IIRoGUzls0YYssqv2d2MV5oXEuozRnjarrgcgGnBe/sFThdZAKUc7MQgH7cFxvRk/OV6K9OuXzGKD04i3kD58Bi68d62cxnD9AI3lJAxJSp88J5QKzk215ipDt1D7NMjgCWmFICldeLEFgAm7HDS3F1YiRocuEux2eHU23Bl+KKKEG+Qbb15IA37uTeFmRuNctJDJk+bHGbsv9FJZKqtKk2ZsUVDmTmrdOZH63P+HjZzY36EZ9fvpBRQWubVm51Jz/XLaOJcMY69evaaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 19:18, Donet Tom wrote: > During node device initialization, `memory blocks` are registered under > each NUMA node. The `memory blocks` to be registered are identified using > the node’s start and end PFNs, which are obtained from the node's pg_data > > However, not all PFNs within this range necessarily belong to the same > node—some may belong to other nodes. Additionally, due to the > discontiguous nature of physical memory, certain sections within a > `memory block` may be absent. > > As a result, `memory blocks` that fall between a node’s start and end > PFNs may span across multiple nodes, and some sections within those blocks > may be missing. `Memory blocks` have a fixed size, which is architecture > dependent. > > Due to these considerations, the memory block registration is currently > performed as follows: > > for_each_online_node(nid): > start_pfn = pgdat->node_start_pfn; > end_pfn = pgdat->node_start_pfn + node_spanned_pages; > for_each_memory_block_between(PFN_PHYS(start_pfn), PFN_PHYS(end_pfn)) > mem_blk = memory_block_id(pfn_to_section_nr(pfn)); > pfn_mb_start=section_nr_to_pfn(mem_blk->start_section_nr) > pfn_mb_end = pfn_start + memory_block_pfns - 1 > for (pfn = pfn_mb_start; pfn < pfn_mb_end; pfn++): > if (get_nid_for_pfn(pfn) != nid): > continue; > else > do_register_memory_block_under_node(nid, mem_blk, > MEMINIT_EARLY); > > Here, we derive the start and end PFNs from the node's pg_data, then > determine the memory blocks that may belong to the node. For each > `memory block` in this range, we inspect all PFNs it contains and check > their associated NUMA node ID. If a PFN within the block matches the > current node, the memory block is registered under that node. > > If CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, get_nid_for_pfn() performs > a binary search in the `memblock regions` to determine the NUMA node ID > for a given PFN. If it is not enabled, the node ID is retrieved directly > from the struct page. > > On large systems, this process can become time-consuming, especially since > we iterate over each `memory block` and all PFNs within it until a match is > found. When CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled, the additional > overhead of the binary search increases the execution time significantly, > potentially leading to soft lockups during boot. > > In this patch, we iterate over `memblock region` to identify the > `memory blocks` that belong to the current NUMA node. `memblock regions` > are contiguous memory ranges, each associated with a single NUMA node, and > they do not span across multiple nodes. > > for_each_memory_region(r): // r => region > if (!node_online(r->nid)): > continue; > else > for_each_memory_block_between(r->base, r->base + r->size - 1): > do_register_memory_block_under_node(r->nid, mem_blk, MEMINIT_EARLY); > > We iterate over all memblock regions, and if the node associated with the > region is online, we calculate the start and end memory blocks based on the > region's start and end PFNs. We then register all the memory blocks within > that range under the region node. > > Test Results on My system with 32TB RAM > ======================================= > 1. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT enabled. > > Without this patch > ------------------ > Startup finished in 1min 16.528s (kernel) > > With this patch > --------------- > Startup finished in 17.236s (kernel) - 78% Improvement > > 2. Boot time with CONFIG_DEFERRED_STRUCT_PAGE_INIT disabled. > > Without this patch > ------------------ > Startup finished in 28.320s (kernel) > > With this patch > --------------- > Startup finished in 15.621s (kernel) - 46% Improvement > > Acked-by: David Hildenbrand > Acked-by: Oscar Salvador > Acked-by: Mike Rapoport (Microsoft) > Acked-by: Zi Yan > Signed-off-by: Donet Tom > > --- [...] > #ifdef CONFIG_NUMA > void memory_block_add_nid(struct memory_block *mem, int nid, > enum meminit_context context); > @@ -188,5 +206,4 @@ void memory_block_add_nid(struct memory_block *mem, int nid, > * can sleep. > */ > extern struct mutex text_mutex; > - ^ Nit: unrelated change? -- Cheers, David / dhildenb