From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E01D6C64EC4 for ; Thu, 9 Mar 2023 09:39:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6813F280001; Thu, 9 Mar 2023 04:39:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 631516B0078; Thu, 9 Mar 2023 04:39:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F8CA280001; Thu, 9 Mar 2023 04:39:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D3396B0075 for ; Thu, 9 Mar 2023 04:39:15 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0C6201C642B for ; Thu, 9 Mar 2023 09:39:15 +0000 (UTC) X-FDA: 80548861470.07.DB3A93D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 1C7FD14000B for ; Thu, 9 Mar 2023 09:39:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hwrl+ZFQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=p0CnFn+p; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678354753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FhkFbSmezdqWEcTL9jACXm7CTqLZyDyZfUS3Z5QYFY0=; b=C9H137StOlZDR7PliXp7dq6UGAKYZn3/6x5dbULr56tRFB3KoAkLBFGPCsfZkhIsuqMNGl FZMsRMVRmeNYMRNwXNsbYqqC5joitw9zgBC6TItWX4Gl6y+oEo8UOnv3590Dj1ck2UFNUd rfk5UFrG/oDZh/3t0yR1qFPag2+agbc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hwrl+ZFQ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=p0CnFn+p; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678354753; a=rsa-sha256; cv=none; b=5Jcz9Ep7ESynuhGWT1dt9zZWk0FT7JyaKDa1J4BFDlWOQAa4zqdPfx6lkuC1RvgA5F9aRL WcddURMOC83P8mUYhfdDYp4vjeqwq/v5QCLjRyPnFksfcwzihUW3h5+Y1HXbrnLrEi43RC /FPwHFsSfPV8VfC0/Hc0z8iUhhrdcRw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E8DC81FFC1; Thu, 9 Mar 2023 09:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678354751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FhkFbSmezdqWEcTL9jACXm7CTqLZyDyZfUS3Z5QYFY0=; b=hwrl+ZFQZdrKjKDDAQpjRZQPf9ixGcePjrieFI1meXAiSAfFCOfcbiBb+3G+XX1HcT8HMi pUipGkoDCDhPwjqJ9NtUHtfjKgmAixETVblo7+ujl8+jJEFCBR6K2NXxqhXnlomZQ5cMBv kO9thRwUrNg3TgRjIVHkBP+EIPmp1kY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678354751; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FhkFbSmezdqWEcTL9jACXm7CTqLZyDyZfUS3Z5QYFY0=; b=p0CnFn+p2i/5YENiNXeZsqkhzYHmTsnbCZslASyEsRa0lC/lS8y4iml7uAwcL0UIWy/xwa d9dSnyIdETM+XhAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1BEA1391B; Thu, 9 Mar 2023 09:39:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AOuuKj+pCWRZFAAAMHmgww (envelope-from ); Thu, 09 Mar 2023 09:39:11 +0000 Message-ID: <96f34c88-ca9a-1c3c-e02a-7c5cd1a269e4@suse.cz> Date: Thu, 9 Mar 2023 10:39:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 5/8] mm: shrinkers: make count and scan in shrinker debugfs lockless Content-Language: en-US To: Qi Zheng , akpm@linux-foundation.org, tkhai@ya.ru, hannes@cmpxchg.org, shakeelb@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, david@redhat.com, shy828301@gmail.com, rppt@kernel.org Cc: sultan@kerneltoast.com, dave@stgolabs.net, penguin-kernel@I-love.SAKURA.ne.jp, paulmck@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230307065605.58209-1-zhengqi.arch@bytedance.com> <20230307065605.58209-6-zhengqi.arch@bytedance.com> From: Vlastimil Babka In-Reply-To: <20230307065605.58209-6-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1C7FD14000B X-Stat-Signature: p118ngqaoprrmu3p8545wbum8wit7gia X-Rspam-User: X-HE-Tag: 1678354752-168332 X-HE-Meta: U2FsdGVkX1/QjflsM3C+COj2WCx2NIyWleFVSPp+rVGID4AKHjd6BSkjbYRBFnRdO0vUZXPG1SXT8b3+h1dgktMlQhvTE3yeJTnNl3UMQ2MJETFoid47Va3DAF8t2dEgD+JlRbm6smzBUrtyLhJB09+Ox3SOLVVMN7oucgio5PPV7Ho9g8eZ4KjZAn/ZBpQmbQjh/cpfpq9xe5AFhusJP4/jOWhQHDlWqEFWuTLGyEhSukZmFx1+ou+gBIEw5gGUY0ANPVL7waYGaUv8OlDu/ssGQZswnUmPFe+74X8bTEMQF3GBYe2hNcW7j+ORj6e3alfQm/Lba9+3WmflENJ4miSJ1risyT07rdxCsb/LjW5M3bufpx8dyQMIxv8jw1r3MPDn0IDRFy3ZWIYi1yf+kd7uSCXMZDbbAeZOvLxgpeQjSx9tJXIvJOCRiUEPdXoY12u9zigmezg2g5wkUNMogOIEDWeW1wLzeusefm76q59KKDV5gOc5l4oy7o6u/rXMoWdSPFNZQrDWBbsLYOQq53tKr7DCPKxUybqdZneqI0JADSS5uy08VoLnaA+kwMTZn2okWxJ8DT12NZ7xa08G+LYfk7qGpjnyPIoFRUGffs53xi0FPGkFp80TOVYbqLDR0g1+cKsQ170Eon7pXRZQ2d2qnOtYVyJY+t7rgpN+FDbzZgA6dqmfnfhGNwauLhwBwHJQDfy8rGTw26C8yRkc13hn/3K8VDozQl1UUp4wmv5KkwN253LAR7TO3QQ6MkC5TRGb9fAwlk3g8MLiIuOR3sPA+BvgEYVe7ZmjMY9J35sDjz1JcVxH5tFzZMAktZKkcfHlfgD+wbx3iWlAuFRJEzuq+hCQoiaxMCmcki/cOdYVK1cx+2BGuQnqWJNfkKAyHCN9vgaqnvevSF4XADwo/MC/VRQF0j+NPO0sK2gECNQXM4hzU1RZcYZh1CFKbJKcOzBJxqKciD+yjveFLMB lJZEwFDs 2aX4x4woveDmXHIl6kLKa7IEoBND6uR+th52kjOOTDZ/Eu73h0E95AhBkCOh2M03g+xIw8i9hkVqblUOZfSYMJi776hiw1ElfFQi9Wbh4ATNYkuQxl7XlKLYBLm6p1iEPF6qdYTd35n5ftCC9GufyxS2l3IOZrMt9xUdWasPeqBjQ5sqb26v46Sp5rFyA+iLNpT6FoCbMe6HNeYe+/z7Vl61TLLAbOzyAM8c2hJoxWZwcAb9JStWvOSXJbZu0lt7IEGfJkThMUwNI0it5uHk/Ifx+Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/7/23 07:56, Qi Zheng wrote: > Like global and memcg slab shrink, also use SRCU to > make count and scan operations in memory shrinker > debugfs lockless. > > Signed-off-by: Qi Zheng > --- > mm/shrinker_debug.c | 24 +++++++----------------- > 1 file changed, 7 insertions(+), 17 deletions(-) > > diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c > index 39c3491e28a3..6aa7a7ec69da 100644 > --- a/mm/shrinker_debug.c > +++ b/mm/shrinker_debug.c Forgot to mention that this file should now likely also #include > @@ -9,6 +9,7 @@ > /* defined in vmscan.c */ > extern struct rw_semaphore shrinker_rwsem; > extern struct list_head shrinker_list; > +extern struct srcu_struct shrinker_srcu;