From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D975C433B4 for ; Thu, 20 May 2021 10:42:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1AF7260FF3 for ; Thu, 20 May 2021 10:42:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF7260FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B3C0A6B00B0; Thu, 20 May 2021 06:42:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B125B6B00B1; Thu, 20 May 2021 06:42:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C046B00B2; Thu, 20 May 2021 06:42:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 6B21A6B00B0 for ; Thu, 20 May 2021 06:42:48 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 02927180AFE45 for ; Thu, 20 May 2021 10:42:48 +0000 (UTC) X-FDA: 78161271216.32.014B71E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 5C0448019101 for ; Thu, 20 May 2021 10:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621507367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nr9+DlfBg48tYmT45uZZLEvFJ1KtfJY23S6lwgRrWao=; b=QxQlGxuF9jzalYyepz+YccsESZCv/H8XeWl93nCvv3IAXFh3Q7knk69Vsql4gXW6Fx1+2W AbzCCZz1moPPOKHickGBx26WEC5DT2pgK5cC7+fZPEYuKPwLKE4aDv5tguvsK/ae2Dy/Y5 EpTRzK+1OF574lCtI7ixDMlG0vyWfDg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-eYI0p4zzM0yFgDnDYE4n2Q-1; Thu, 20 May 2021 06:42:43 -0400 X-MC-Unique: eYI0p4zzM0yFgDnDYE4n2Q-1 Received: by mail-wm1-f69.google.com with SMTP id n127-20020a1c27850000b02901717a27c785so2160369wmn.9 for ; Thu, 20 May 2021 03:42:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Nr9+DlfBg48tYmT45uZZLEvFJ1KtfJY23S6lwgRrWao=; b=uT0ceCp6JHSUPaomkdQra09FIN+r0R8F1S3mafAwFxV+XeOx+OpkoZzZ3/cEQS/X37 m+u9EMfliNVGBVrDFk5AqrymJFwQm5IVuiGlhC3WkUsSx1SJSP3jKie6oOpyrzFjvs93 PVtlCDLAn6UuMiwfH4RK8SSLGJNFhhsRqJReqZMxnC6N66Kw/KdPTeaz8UVVlUPSolRv haC0by/rie7NYpGwsSfcEOGmH0mQRsg2E5Ml3uzIa7arpMxxTxUdU9F15iDq7AUlJ6J8 hPZi1ESUFeQYfTi4D5qZn0cz1y4NKWExuXfR/YWKjPm5XhfHi7QKjSFOpdU/JU7jbx1e 8iZQ== X-Gm-Message-State: AOAM53280o/tAqfhR4Wyrtck2gxyxUBOXKhShm/A6UTo5c76JGLcxtA8 Iquf23nlV05wvubX4AslIOKsxW+sQhjJL7Z9rm/HDhjszN59cssU/splRpKRUfAiZvwNSa+hQEC oWwfmhg7vHR0= X-Received: by 2002:adf:e4c8:: with SMTP id v8mr3589448wrm.345.1621507362465; Thu, 20 May 2021 03:42:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFqUkFevK/7EEQMp2LynkF0uJ/mORJiN1O6rHeSUplUHDQXCsm2NGQAZS/cMUvEBdsDMpkLw== X-Received: by 2002:adf:e4c8:: with SMTP id v8mr3589420wrm.345.1621507362177; Thu, 20 May 2021 03:42:42 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6315.dip0.t-ipconnect.de. [91.12.99.21]) by smtp.gmail.com with ESMTPSA id x2sm2256899wmj.3.2021.05.20.03.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 May 2021 03:42:41 -0700 (PDT) Subject: Re: [PATCH 08/14] mm/memory_hotplug: Fix kerneldoc comment for __remove_memory To: Mel Gorman , Andrew Morton Cc: Michal Hocko , Vlastimil Babka , Dan Streetman , Yang Shi , Linux-MM , LKML References: <20210520084809.8576-1-mgorman@techsingularity.net> <20210520084809.8576-9-mgorman@techsingularity.net> From: David Hildenbrand Organization: Red Hat Message-ID: <96f1cf9c-3516-30d5-201a-9212cdd79ac2@redhat.com> Date: Thu, 20 May 2021 12:42:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210520084809.8576-9-mgorman@techsingularity.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5C0448019101 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QxQlGxuF; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: ib5an1aq3xuk8tiaicjex3gkkkhbfkxg X-HE-Tag: 1621507366-471643 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.05.21 10:48, Mel Gorman wrote: > make W=1 generates the following warning for __remove_memory > > mm/memory_hotplug.c:2044: warning: expecting prototype for remove_memory(). Prototype was for __remove_memory() instead > > Commit eca499ab3749 ("mm/hotplug: make remove_memory() interface usable") > introduced the kerneldoc comment and function but the kerneldoc name and > function name did not match. > > Fixes: eca499ab3749 ("mm/hotplug: make remove_memory() interface usable") > Signed-off-by: Mel Gorman > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index e3266be1d020..4ea1b19e8c7a 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2031,7 +2031,7 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size) > } > > /** > - * remove_memory > + * __remove_memory - Remove memory if every memory block is offline > * @nid: the node ID > * @start: physical address of the region to remove > * @size: size of the region to remove > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb