From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C0FC27C55 for ; Fri, 7 Jun 2024 07:27:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 851256B0085; Fri, 7 Jun 2024 03:27:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 802796B009B; Fri, 7 Jun 2024 03:27:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 716C96B009F; Fri, 7 Jun 2024 03:27:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 537726B0085 for ; Fri, 7 Jun 2024 03:27:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ECC93814B7 for ; Fri, 7 Jun 2024 07:27:43 +0000 (UTC) X-FDA: 82203262806.23.BB39DCE Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf28.hostedemail.com (Postfix) with ESMTP id 3B0F9C0010 for ; Fri, 7 Jun 2024 07:27:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UOM50Iwh; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717745261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SmIHSLn/WvaJPUCX1Y8vqiV6qDdzhglScQrwFE+kVPs=; b=m5iHuHwmz7ik/eJQhPRIdyVOom8yCQ13Qx2V7wosrm/ELKtzjTKC3WABxK/3VPDY2F8n8b rTprowM5W2SRxczdNxZrsGBtjXWx7DYt4HmynpqsjKCfu4FdyBD9vERciTb9y88JP86bvy HzZVcnDtyT7oVTKm3cfvXYCIkQ9SWuk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717745261; a=rsa-sha256; cv=none; b=r3ghMG41ITVM/tz5T5tgyrj1mvfK8fs6o0ChMmXLe+z63HGWcxSdp8FBpWS1f3VnYgwT0d hBNqn3Ad4gSuvO8zbFU+54G+pyV72utwwKnlifA7xWJrTYNdI2V9Aw2/BjRN2JlR4beaAi SxwuLzA1Sg8Pg/te44SnmUjQhAlArPQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UOM50Iwh; spf=pass (imf28.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: vbabka@suse.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717745259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SmIHSLn/WvaJPUCX1Y8vqiV6qDdzhglScQrwFE+kVPs=; b=UOM50Iwh2l1RuKUYUI3XZ8BTN4lzNFetHtCLig3C2tmvfdz/GJoBR+YE+bt1ThDI/irx2P 9sMcu9AaZA4y5SP7GoBS//xnF5LpiiESOog8FLdGWoa1RCqQ4BXI0gTdn21oxq4293Rel/ ty9UTtboEF7wLJDFHmzhMIei3FlPvmo= X-Envelope-To: cl@linux.com X-Envelope-To: penberg@kernel.org X-Envelope-To: rientjes@google.com X-Envelope-To: iamjoonsoo.kim@lge.com X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: 42.hyeyoo@gmail.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: zhouchengming@bytedance.com Message-ID: <96f13b3c-ec74-4f87-be37-fbf796fe51eb@linux.dev> Date: Fri, 7 Jun 2024 15:26:46 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/3] slab: make check_object() more consistent Content-Language: en-US To: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240605-b4-slab-debug-v2-0-c535b9cd361c@linux.dev> <20240605-b4-slab-debug-v2-1-c535b9cd361c@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3B0F9C0010 X-Rspam-User: X-Stat-Signature: siecobj3jdg66np4zzxsu8ii6336ac9n X-HE-Tag: 1717745260-767361 X-HE-Meta: U2FsdGVkX1/74CmdWrz7tVnzBXMh+mCQDNB/qN0URBp7NJQC34J09miRa4NEOWdga+SXQW+Em9rFH1hoEzBGYOqTdcT1kF4STzMNOG+brtcZChf/Hu0lHMzG7YgSglGjVgvI0rJd2Rt4rHkoAkL+rmi9wgmKDvumLXejWxj2U7BPyI/YDKDn+fGY/UZl80rpxeR8i5dK/MeR8fxJWwIOZApJk0Tp0DoQDmxo/dCYL/5AvvClDY33fhWARR0wwBYAEBM2CMhyEDjN7Hs5+lnnPaYK8eSAI66CC4Slwf6VzDbpoLFF/w2vTODcEJOil+GVasGKrTJpz8Wya/gBtjpkyxuBF98unf4IPl1QABjHqw5GIL7l66OVM1pwTrGtIhgYYPHZcRX1vxXBMUMePC0BdNVj3sZ4yMkX6aDdMSN19IlZGlCnMnS/3Jbk2PRr1CXgInXEscTjr9Kkynf1MjjIKNDGaAau7JShtXK5002fKWsS1ScLC8tyOYaZPD9pl/OaEGA+EsELL10T4YJmyd53GIupi8Q1WMm8L02MCv+/wCT0qJ6RLp2kxAj/FiVxYVqobf70CBOR45/QTv70z5/Vk7gkXcx5VYA9nufPZcMVP6ROxcVQIN2LGkFeqrmN/kuObf4vO1Zr+yL2QInJUmSqjE2HGfpbUJuVWRT5yaf4MRPNl58xISxW61tnWVBrACxPO+gHpt8RqmXh2fylxUt5WmTqp9nf+5nPtQz3imjfxAZjdUAq8gcmOR+Jr7aA8zQz01TCgasTSq2tV2HIXfBACbnZWUzcYMIk0z8YRhagZnmYRQslCG8/vLxYAVAWCY4E1S3eIzOgcJPf6EYOdLCYIirB97qEfznS3eFMvw0MOlrTVSDQqdiGT3ljiQ9yN6ISE4bGtEEMIzEq9SccflU6pNSE168AXL+nO4JOxZ0BM0z4dgCoqDhDMr0dSS4CqaI6qwgQaNZJXq57LSqyLxI DHDrObZQ Tj0F6rSjnTcfHenI7jX5XDu5YogRDg9F8nJlJetwShOyEPEpCFaYpjpHWfSp5GQ592duGinXK3BeHqQwvVh2NNu32fej3vJeFGbGbkViqthPEDR2kEgh89x00c6+PE0Sf7MOEBG5t1fq13Vc7LqOKiBJwMBIkzUrQ6kXD5kI1R/3YRZSe6cliYMJzECdq6/l93P+Xr19JCAh9QJo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/6 16:28, Vlastimil Babka wrote: > On 6/5/24 9:13 AM, Chengming Zhou wrote: >> Now check_object() calls check_bytes_and_report() multiple times to >> check every section of the object it cares about, like left and right >> redzones, object poison, paddings poison and freepointer. It will >> abort the checking process and return 0 once it finds an error. >> [...] >> - /* Check free pointer validity */ >> - if (!check_valid_pointer(s, slab, get_freepointer(s, p))) { >> + /* >> + * Cannot check freepointer while object is allocated if >> + * object and freepointer overlap. >> + */ >> + if (!freeptr_outside_object(s) && val == SLUB_RED_ACTIVE && > > Seems this condition should have been logically flipped? Ah, right, will fix. > >> + !check_valid_pointer(s, slab, get_freepointer(s, p))) { >> object_err(s, slab, p, "Freepointer corrupt"); >> /* >> * No choice but to zap it and thus lose the remainder >> @@ -1370,9 +1368,14 @@ static int check_object(struct kmem_cache *s, struct slab *slab, >> * another error because the object count is now wrong. >> */ >> set_freepointer(s, p, NULL); >> - return 0; > > Should set ret = 0 here? Yes. > >> } >> - return 1; >> + >> + if (!ret && !slab_add_kunit_errors()) { > > Also 5/6 of slub_kunit tests now fail as we increased the number of recorded My bad, I didn't test with slub_kunit, will test later. > errors vs expected. Either the slab_add_kunit_errors() test above should > have a variant (parameter?) so it will only detect we are in slab-kunit test > (to suppress the printing and taint) but doesn't increase slab_errors (we I think this way is simpler for me, only suppress the printing but doesn't increase slab_errors, will take this way and test again. Thanks! > increased them for the individual issues already), or simply raise the > expectations of the tests so it matches the new implementation. >