From: Hyeonggon Yoo <hyeonggon.yoo@sk.com>
To: kernel test robot <lkp@intel.com>, Alex Shi <alexs@kernel.org>
Cc: kernel_team@skhynix.com, 42.hyeyoo@gmail.com,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 8826/10150] mm/zsmalloc.c:431:20: warning: function 'is_first_zpdesc' is not needed and will not be emitted
Date: Fri, 24 Jan 2025 10:45:45 +0900 [thread overview]
Message-ID: <96ec41ca-16d8-4960-8d4f-cedf5aca386c@sk.com> (raw)
In-Reply-To: <202501240958.4ILzuBrH-lkp@intel.com>
On 1/24/2025 10:30 AM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 853d1f41ba73e78d22e7075d9a95670aab187eba
> commit: 1c6c153b503f90d1099ae606198e080a452687f6 [8826/10150] mm/zsmalloc: use zpdesc in trylock_zspage()/lock_zspage()
> config: i386-randconfig-005-20250124 (https://download.01.org/0day-ci/archive/20250124/202501240958.4ILzuBrH-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250124/202501240958.4ILzuBrH-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202501240958.4ILzuBrH-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> mm/zsmalloc.c:431:20: warning: function 'is_first_zpdesc' is not needed and will not be emitted [-Wunneeded-internal-declaration]
> 431 | static inline bool is_first_zpdesc(struct zpdesc *zpdesc)
Ok. for now is_first_zpdesc() is only used to check erroneous conditions
on CONFIG_DEBUG_VM=y. Simply adding __maybe_unused will be enough to
suppress this warning.
However I'm afraid that it's too late to update the patch now.
Andrew, if you're ok I'll send a patch after the merge window's closed.
How does that sound?
--
Hyeonggon
> | ^~~~~~~~~~~~~~~
> 1 warning generated.
>
>
> vim +/is_first_zpdesc +431 mm/zsmalloc.c
>
> 430
> > 431 static inline bool is_first_zpdesc(struct zpdesc *zpdesc)
> 432 {
> 433 return PagePrivate(zpdesc_page(zpdesc));
> 434 }
> 435
>
next prev parent reply other threads:[~2025-01-24 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 1:30 kernel test robot
2025-01-24 1:45 ` Hyeonggon Yoo [this message]
2025-01-24 2:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96ec41ca-16d8-4960-8d4f-cedf5aca386c@sk.com \
--to=hyeonggon.yoo@sk.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=kernel_team@skhynix.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox