From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C86C3064D for ; Wed, 26 Jun 2024 05:08:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D0426B00A1; Wed, 26 Jun 2024 01:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 058CC6B00A2; Wed, 26 Jun 2024 01:08:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEDEC6B00A3; Wed, 26 Jun 2024 01:08:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BC5E56B00A1 for ; Wed, 26 Jun 2024 01:08:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7B9FE40985 for ; Wed, 26 Jun 2024 05:08:55 +0000 (UTC) X-FDA: 82271860230.04.466EDCF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 4DD7CC0005 for ; Wed, 26 Jun 2024 05:08:53 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KGMSZHRo; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719378524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lKdnQfLmgCvfg1/bGVpHdQOE7llBxQ0KTseDI0hZ8WQ=; b=P2dwwmz14CIuP2nHhnRy6HsQAaeSAc75K+FmXxgcZojtWXo531aaoamClZICsdpiZNmdNN c2mWYGcgT4dwvkoCY6yul+Mqt7lgsWaDLdI2rB4uLQLPWvXTmEBuL0Q1W+ejaWpU4vgHHl eIdhkRQvAbrV0fz2QAXT27Qv32dsmlI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KGMSZHRo; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719378524; a=rsa-sha256; cv=none; b=T13wS7k/9e8DvZE7YB3hCfAGiGiNJFlDpXLiS5OmRdI+6TRp0j/wn9A5Opu4K9Jb2XuEWo aRZ3cr8c+0X6oPCrCLQWYDf1QULeusOGfru0x/ExW62rKTs783vMOxOwjVmWTyFVRvbaHD 3vp+icooLRmFaXXLZFvG7nc3P2Cl68Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719378532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lKdnQfLmgCvfg1/bGVpHdQOE7llBxQ0KTseDI0hZ8WQ=; b=KGMSZHRoMOXv4G1yMJkYX7Ag9+MTJUz5M3rWxupvjUg9ry9KsQBgCL5eBt3p8u0ayhmAgG chV378T434cqKHSd0Sia32eiv4zCGBYl2XAK7rKKmv5C58GeRZYukAh3aVeS1+jIZEcoEa aJTId+Fkxv8avJIfdTYC71t1AN/nRmY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-ZS0dxQ7hOAyLs5i-gfqW5A-1; Wed, 26 Jun 2024 01:08:50 -0400 X-MC-Unique: ZS0dxQ7hOAyLs5i-gfqW5A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3621a7854b0so3086004f8f.3 for ; Tue, 25 Jun 2024 22:08:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719378530; x=1719983330; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lKdnQfLmgCvfg1/bGVpHdQOE7llBxQ0KTseDI0hZ8WQ=; b=pdmHW4iEP/0muX4qUvRkJwb47TLfSlQl7dca+EsIu2aTuf+fkzi7gSnu1w6g7t/QSG ACWYlIi+Zou1l9mR2DLvDC8Gzla289lR45bnSWlXKlFParouJ9RJUTkCcuWtDdiu0nn1 QFv2dkL1/OXtzL3jfmdw/K0ia4QyjIBF+2i8KZdHF1ocukTgOPbH4dvvrD3LLeBQ2/fr ExGY/Iw4SKx4G64ZMaxy6uRF6Icz2grmm6PlG7fqc6Wu4/tcnkMGj9Nvt1wj1+DlA0rI AAru1qZ2F7WZGzy0W/pqQ7dwYjxfYd7hHgUA9JLNgSZufvUwnnIB4lz91zV4Q7ksEtwQ aJ6w== X-Forwarded-Encrypted: i=1; AJvYcCVnD4pPcI9Ubar9eah0bh6n0+mwMmB1IFu1+gpx4iscUdRdNq75/+48/laUhX6Vp9XjGBHTKFufadJwTHT1sZ41i2c= X-Gm-Message-State: AOJu0YwZTo4mn4d2YXKjDdolHP7dPVGxG5dsZI5Ym+pbmRSfCmi6psKp +bMdiwo7zK8Vbgro8mtoyj7cb+SnmaGfZiodoK+gTCIygj78hPeyLsYqCRUkSFqAVcmkDazM8ZG l/wAtP6d7b///dHVcB77f6mIhTFuD8WkmMGxPKtWzjz25fwaR X-Received: by 2002:a5d:64cc:0:b0:35f:2fa7:ef14 with SMTP id ffacd0b85a97d-366e96beaa2mr7213538f8f.60.1719378529863; Tue, 25 Jun 2024 22:08:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGOW9U3sHUzQRtqv84MAnok/aGQBUtS6qQp4TKNFq5tQVam0t32z8wr6Hl57XUuE+zp1eibA== X-Received: by 2002:a5d:64cc:0:b0:35f:2fa7:ef14 with SMTP id ffacd0b85a97d-366e96beaa2mr7213525f8f.60.1719378529433; Tue, 25 Jun 2024 22:08:49 -0700 (PDT) Received: from [192.168.1.34] (p548825e3.dip0.t-ipconnect.de. [84.136.37.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-366389b8597sm14592184f8f.36.2024.06.25.22.08.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 22:08:48 -0700 (PDT) Message-ID: <96e0915c-e836-4413-81ea-37bbb6abba6b@redhat.com> Date: Wed, 26 Jun 2024 07:08:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] mm/zsmalloc: use a proper page type To: Sergey Senozhatsky , Andrew Morton Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Rapoport , Minchan Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20240529111904.2069608-1-david@redhat.com> <20240529111904.2069608-4-david@redhat.com> <20240530050123.GA8400@google.com> <345161ac-3b42-48aa-ab3d-3b183316479a@redhat.com> <20240625153338.8a4d049857d59e692a0d31e6@linux-foundation.org> <20240626044122.GA15925@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240626044122.GA15925@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4DD7CC0005 X-Stat-Signature: 6bmyezzmp19trcbt1ahc4mzbpdytags3 X-Rspam-User: X-HE-Tag: 1719378533-160616 X-HE-Meta: U2FsdGVkX1/UXTtLt6tg5fI84+9OtaJhe6FuIow71HkbIiAVCD5gk2fVEJr2k0b1M8YsMPfrKsYzGmgQMtLIZO0CrI6eeIoYNU5Z8HeMQlViSP7UF1NW8C9qEeYVd4FBOAWfkFmMI3vqcFUEH2XzXq+9qmSzJ1kWEi8r6KBzLbT0Eymyvy4jTjU3XGIkPxFoSTJc8G3eT1xTSXZ3foGktGy3EXE0LUr4akYnQBlWsUxRtmcMXvqMXV9c5xdpthBRHMZddRpZ+3OY3Npyvv+wNcNwQRE1EzEe0p+qkuDETmn1fLEV55RPAOUJlRZ0/lXvWPs3mNYE9/DENCttlWfbiqUImZF7Zv4ReVpUh+LztFvnFm2d5YeUbo6RFt3O7NL/RQVWAEq41AjGbP5cGVWY+cdf4BMCj/NuqCg+IcyViYSLsTf9TIfkGkAo3hYrv9kNKfbBmgs2p0ioV2KG/kWkwROD47Puj34KhYIQESRWgKbc4jahz9UBU3XUT1lvNwyQ6j860rQUlgXkJyfwwm88hDLTGAInL41V++geFHIOinavJDMFTVhvd7YyqsHmi5YPhNcx1IuLHIpm4k17cL9wz/dk+qPIlU1H6GJYMIZzP9CqyUELH8UcQtgi+IEgK+M2D9QrOveAPVk1PsDrqfVOw39HYTiS2T7CTU5+12uqReM+Tq1ih88eXRJU1zVm8Q6Ggdw28ttAKfYxOIpXRkyOhtWO5pIKClkyauk50kl0LBa3QxfbtwLUsNFsgCVhkZ4Y19OoLAPW8WPmRbCmXACfMSCoN6Da5i1/pTGbtGAsJoznFhDccId/SqUGujx9SY1BFWYP7yVzSJABYMTWqkB+9rf+z6wTjU0WvSsmKZcMIBMaXnvnsBXdcjKbbnQb18XHPXT5Tj6XMbrxOBBLGM44f3zFJEy37L8OoDMZiwSvRhfJxegY2wN7++JzFYrYmveDJmtlKSIDCXKZGNsNryj QMn2K6Jp utVOklQVUFsa5A3zFtfJDhKf/1pTQEC/nRogfeTImWobk3VAgXmfXOS8wckm2fWJU63CNLiuZU9uJS/rIcoalpA1aSl07c75e+Nt3Vd6WEsPuKLOQrC59J2lxE+R5lB2WqEGnbb5BAkDrLYzzWeW6AA4l1PoC1OuEcOF8AQHl0l6p0jPT+zo87qZH5Ui2f3YnkcIZCPdwWyDqv3JvsqnknoIww0uLQ38PYsRxsUq3zAcuHXi2CTvsg/PjDNmg/xL4eqc1o3NaIuhwvmFg7h+H87CeNZmusK5jIVsHLahB9UrhZ0gw0l4+eO2OseJMdl+AgKXL6klBnUMJ1rMjm6otAdgC/KgtW5OAMzIJqj3NycZlU1sHOwgIHVB/KnTNWZ1ymhKGssvJOuRv5DAQwocC0P2R1wxhW9pv7OhfQ2ZsvA73nDZCxzHem/mDKCZAjtdSEMgsM1eO2S3BBNfgtWfudBBanou+L/FP7fZchXK2IImX/EZJhXYLIPdTfDzAJaMS2zYedr6DrYyeoERp2QHuGmJjeGWiHbKheGZa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.06.24 06:41, Sergey Senozhatsky wrote: > On (24/06/25 15:33), Andrew Morton wrote: >> On Fri, 31 May 2024 16:32:04 +0200 David Hildenbrand wrote: >> >>> On 31.05.24 16:27, Matthew Wilcox wrote: >>>> On Thu, May 30, 2024 at 02:01:23PM +0900, Sergey Senozhatsky wrote: >>>> 1409: 83 c0 01 add $0x1,%eax >>>> if (mapcount < PAGE_MAPCOUNT_RESERVE + 1) >>>> 140c: 83 f8 81 cmp $0xffffff81,%eax >>>> 140f: 7d 63 jge 1474 >>> 4> >>>> if (folio_test_hugetlb(folio)) >>>> 1411: 80 7b 33 84 cmpb $0x84,0x33(%rbx) >>>> 1415: 74 4e je 1465 >>>> >>>> so we go from "mov, and, cmp, je" to just "cmpb, je", which must surely >>>> be faster to execute as well as being more compact in the I$ (6 bytes vs 15). >>>> >>>> Anyway, not tested but this is the patch I used to generate the above. >>>> More for comment than application. >>> >>> Right, it's likely very similar to my previous proposal to use 8 bit >>> (uint8_t) for the type. >>> >>> https://lore.kernel.org/all/00ba1dff-7c05-46e8-b0d9-a78ac1cfc198@redhat.com/ >>> >>> I would prefer if we would do that separately; unless someone is able to >>> raise why we care about zram + 256KiB that much right now. (claim: we don't) >>> >> >> iow, "this is ok for now", yes? > > Perhaps. I'm not in position to claim that zram + 256KiB PAGE_SIZE is > irrelevant, but I'm also not in position to claim the opposite. > > Matthew and David have ideas/proposals/patches to fix it should 256KiB > PAGE_SIZE become an issue. Yes, let's keep it simple for now. There are various ways to handle that if there is really the need to. 256KiB is not particularly common (quite the opposite I would claim), and a simple fix would be dedicating 18 instead of 16 bit. Long-term, we should handle it more cleanly though, and there are also various ways forward (store offset in page, separate allocation like memdesc for metadata, etc.). Mess with turning page types from flags into values should be a separate effort, because requires more care (e.g., PAGE_SLAB_MAPCOUNT_VALUE). -- Cheers, David / dhildenb