From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3879FC2BA1A for ; Fri, 21 Jun 2024 07:43:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72A796B007B; Fri, 21 Jun 2024 03:43:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68C146B0083; Fri, 21 Jun 2024 03:43:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E05F6B0082; Fri, 21 Jun 2024 03:43:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 27E136B02A8 for ; Fri, 21 Jun 2024 03:43:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CF984A21DA for ; Fri, 21 Jun 2024 07:43:56 +0000 (UTC) X-FDA: 82254106872.23.8A28E44 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id A0F4540017 for ; Fri, 21 Jun 2024 07:43:53 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iheIrgXr; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718955823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXQ4efuXmJaBuTYOu/+WHETOQnkAh+ulGBOP07t9dcc=; b=vVWYH+Bmn+e6BPZKyuXke3U1jAYQg00haOCFiDjjHbHwS7ElbNM74FCCixBMj5ZmeCj0vu cgDyB+k7SuV0Q2GQBXDsoc9+vvAJcfpJqjfVYdE9NGKffNWQcdyvMq29HBr3aa0gM9ardG 30uzXkdx/j++dIthG2u/ZK2dz8NS1Po= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718955823; a=rsa-sha256; cv=none; b=6hTdn5/PTqjxvOo29WviTTQMC3zO3VQxEBETPDqJgKjoE1QbsChGH0/gKLPHHMPL6j+Mal iGbzTks/H4ajXppqRuw6pZRP5Kcy/v+DYOT2WRrdVKr6VYJKk/IfWgRk9EfVRmnC5gQRk7 MBm+BAmY6kXNlVstKD7WB6K4rH1xBMA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iheIrgXr; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718955833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PXQ4efuXmJaBuTYOu/+WHETOQnkAh+ulGBOP07t9dcc=; b=iheIrgXrXHKgsZdHEzowClQQ+9H9QyBB/+LqeKDsMVhS7me1dfgFpu/fD1PSt1QKTG1GO2 WphLRQGQj2tCZ+ri94A4vlwJAVwsC85zAmOkjDinBAygFtTUvisspGNa6FgdhPPu/cCasH Kf79dACwiLsCtmnJkRXA7cxDEZrk9uw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-x9uRvVaBN72xHK7ukmp2Bg-1; Fri, 21 Jun 2024 03:43:51 -0400 X-MC-Unique: x9uRvVaBN72xHK7ukmp2Bg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4246ed3f877so12631005e9.3 for ; Fri, 21 Jun 2024 00:43:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718955830; x=1719560630; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PXQ4efuXmJaBuTYOu/+WHETOQnkAh+ulGBOP07t9dcc=; b=EcocH+jZTX7uttYJbFa91IgLEwE7U4KSwp91QL1bdclt5f5IXS6Bw151TFb8Q9equr oR6jbLDFvbMT+YQBvM2Di/W5vUr57iahECjs0CV1wDXL2GH2RgMhvdcrR7tY94zoAmxv rRzSuA6lxw1Q4MEZ0WWcp40PNiSwhQcE4Q9UptmfmePByktOgC9ePaXIu5MHrQVA5ySl cwR89SLHszcKfc0+JoHJfW6/9Q3o7ToiTpi8RKkTFZpas6YlAL6IBzoTdpDfOda3Fqs6 P5LreNx/33lJ/wRiTVuxDg85/Ljzstjupj5YVrveB5WNFAXcylrAvyP/fkWY69JMvNAe Iy5g== X-Forwarded-Encrypted: i=1; AJvYcCXIh5vJQDZbN7t/BMKEXe/XHd+CY0/T+/HDf8+rESZsa15sF+sqUtKzrYSMNQfXz5Wvr8aFjjQOXI6tZBuOwnAOj0U= X-Gm-Message-State: AOJu0YyqtzTOli/4WCChTCBzt44DlyQq+mwAiXeVV968H7FUfL0emejX kk2wastv10GTTQBn/QtwN947oIlrUTCh531sGkmoCKEC4Siuv6RJ9Pbcsm2j2d6luitn163DYmy nQmovkD1bSB3ueVzwYmRfv/5+FssKUiY2ldpzS2Ymdn0bkHHj X-Received: by 2002:a05:600c:12d1:b0:420:173f:e1e9 with SMTP id 5b1f17b1804b1-42475183abcmr50829115e9.21.1718955829951; Fri, 21 Jun 2024 00:43:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGFhPCh+f56fSUHi3uGdtrIekqv4PyB9COw2ZzQozbPAmaFpHnj4r7upN+wLk//8erbglA0Q== X-Received: by 2002:a05:600c:12d1:b0:420:173f:e1e9 with SMTP id 5b1f17b1804b1-42475183abcmr50828995e9.21.1718955829516; Fri, 21 Jun 2024 00:43:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c725:e600:4063:2059:fd18:9d65? (p200300cbc725e60040632059fd189d65.dip0.t-ipconnect.de. [2003:cb:c725:e600:4063:2059:fd18:9d65]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0b63d4sm52393385e9.3.2024.06.21.00.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 00:43:49 -0700 (PDT) Message-ID: <96df0073-6fde-4252-a9cb-22eeb0a876bb@redhat.com> Date: Fri, 21 Jun 2024 09:43:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/5] mm/gup: Introduce exclusive GUP pinning To: Sean Christopherson , Jason Gunthorpe Cc: Fuad Tabba , Christoph Hellwig , John Hubbard , Elliot Berman , Andrew Morton , Shuah Khan , Matthew Wilcox , maz@kernel.org, kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pbonzini@redhat.com References: <20240620135540.GG2494510@nvidia.com> <6d7b180a-9f80-43a4-a4cc-fd79a45d7571@redhat.com> <20240620142956.GI2494510@nvidia.com> <385a5692-ffc8-455e-b371-0449b828b637@redhat.com> <20240620163626.GK2494510@nvidia.com> <66a285fc-e54e-4247-8801-e7e17ad795a6@redhat.com> <20240620231133.GN2494510@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A0F4540017 X-Stat-Signature: 9exbdbwtqfi3bafbrjtsq81iwybrfxh9 X-HE-Tag: 1718955833-843578 X-HE-Meta: U2FsdGVkX1+EiIj7CBdOTcybHqwDlIIaY6ZfMvhJNqpDPueFwrSYDAKAPHfmGV+x89HNuhv6SIrcWjFYabFbK6LyWpMsnXcKslynPCTwNEk/HFndRzygeCCUbIFjAuE0tfrRSiuqu91mANnu5p1FqPEsKEu1BZNKeESWfSxNpPqf8lzs6aaZoplyPY8zE0oQWO61+thBnay+y6VLr/H9SS9Z7BhpG5JaKe7/ecKykXqNK6lrYOahv/IXIDq0JdKofmkl7IxaGhWGSnJDcLowkFQT1FxFsCrBU9+rZIf/t8ffkoHf/s3jtbFcCBAeZG1+Vta5uZHgBWdViFkico7fYkjxPLI/0NfKcZe0hMeZE3xkmW5u0eZHK4/Z3n95EG+ofR6zT2mQ9cZtDbct6YTfAG7efSitb2LH0/ggi4LXidL3ALoUBLtsYYBm6zuyymLwxTMQ+SN9TM+ob0Y7kq+QCLn2XlMHsFkN4yFY7UKnZef7LPha5YrAvxi75VJLRVkhbXMozWfF1hRCRUuXiLhjivq1qIYenWo9NOV91Wq5sJfhxj++MZaaugoXQPBcKQwRd1rVMXZUdw8cNoIKdWRG4ca0uH2tCwBRdJ1kjNRhKjJKyaR7oCQG/N8LUU+gkOxAs347/Hcc9caEj4SfMbMqYdc8C5B8eottI0fS+udYNQMKRwimP+zuGT+Kz5O+Ir37zFpeAwfp5Qy4Ido7CmHp6XdG7zxrx+N3tjtZ5khY1336cGQ3NnaRHcQRo+M13oWE9wEnMTOcSl3bmWLo3jlVpZ7tz9ApRfTfR/uacm9+vnP5hsx/CPVaG1I91Ujhv3FLxBoUOXyO2PRhkjz7Bz4IpEB3lXuoLsCeLvREuE6tHvK7wycZtMwdC6bBzklgglqaD1QHNKKB9GiXe3q71437+jk5XVSLGerSIbfPi4V1Tdeq+/O7OsQl9tpZiIgGuPyldjFK8D0h8FSVKHmr/Eb jF9Q8+MV sT5bM1w8umOn5AwUoN5+IJS02X0Q7JWujRI8Vl4lIN6a1mUjIIn4lPfKpQ6j50atBuZ+rH8RmlbSPIJQ1SRGY/Hx8jjFLrV4FZdRf2J9sMsCTLlTDtXkz2pn6aLaavc75+ajnNIgbrnhm0tT52uUpBbMzM7hk+uDu7fv7RQ3KXfychMQkkObyNj6ejSOdvefl8u82q7oO5010aoPiWJhX5m2kyyMhTFInKWH36O1Zxi+aJplJAp/nzB+HXzjqFqI98xjqu/Nl9t4zJ06DNW3Ep43De2khz14joVs6p0XViZIV8RLCawgs+xsgH2PbimdcMCxDLReC6va/Muv7xju22o0kN6eN+lzLuByoIngo15oSDYFTiDe1KIFhCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.06.24 01:54, Sean Christopherson wrote: > On Thu, Jun 20, 2024, Jason Gunthorpe wrote: >> On Thu, Jun 20, 2024 at 01:30:29PM -0700, Sean Christopherson wrote: >>> I.e. except for blatant bugs, e.g. use-after-free, we need to be able to guarantee >>> with 100% accuracy that there are no outstanding mappings when converting a page >>> from shared=>private. Crossing our fingers and hoping that short-term GUP will >>> have gone away isn't enough. >> >> To be clear it is not crossing fingers. If the page refcount is 0 then >> there are no references to that memory anywhere at all. It is 100% >> certain. >> >> It may take time to reach zero, but when it does it is safe. > > Yeah, we're on the same page, I just didn't catch the implicit (or maybe it was > explicitly stated earlier) "wait for the refcount to hit zero" part that David > already clarified. > >> Many things rely on this property, including FSDAX. >> >>> For non-CoCo VMs, I expect we'll want to be much more permissive, but I think >>> they'll be a complete non-issue because there is no shared vs. private to worry >>> about. We can simply allow any and all userspace mappings for guest_memfd that is >>> attached to a "regular" VM, because a misbehaving userspace only loses whatever >>> hardening (or other benefits) was being provided by using guest_memfd. I.e. the >>> kernel and system at-large isn't at risk. >> >> It does seem to me like guest_memfd should really focus on the private >> aspect. We'll likely have to enter that domain for clean huge page support and/or pKVM here either way. Likely the future will see a mixture of things: some will use guest_memfd only for the "private" parts and anon/shmem for the "shared" parts, others will use guest_memfd for both. >> >> If we need normal memfd enhancements of some kind to work better with >> KVM then that may be a better option than turning guest_memfd into >> memfd. > > Heh, and then we'd end up turning memfd into guest_memfd. As I see it, being > able to safely map TDX/SNP/pKVM private memory is a happy side effect that is > possible because guest_memfd isn't subordinate to the primary MMU, but private > memory isn't the core idenity of guest_memfd. Right. > > The thing that makes guest_memfd tick is that it's guest-first, i.e. allows mapping > memory into the guest with more permissions/capabilities than the host. E.g. access > to private memory, hugepage mappings when the host is forced to use small pages, > RWX mappings when the host is limited to RO, etc. > > We could do a subset of those for memfd, but I don't see the point, assuming we > allow mmap() on shared guest_memfd memory. Solving mmap() for VMs that do > private<=>shared conversions is the hard problem to solve. Once that's done, > we'll get support for regular VMs along with the other benefits of guest_memfd > for free (or very close to free). I suspect there would be pushback from Hugh trying to teach memfd things it really shouldn't be doing. I once shared the idea of having a guest_memfd+memfd pair (managed by KVM or whatever more genric virt infrastructure), whereby we could move folios back and forth and only the memfd pages can be mapped and consequently pinned. Of course, we could only move full folios, which implies some kind of option b) for handling larger memory chunks (gigantic pages). But I'm not sure if that is really required and it wouldn't be just easier to let the guest_memfd be mapped but only shared pages are handed out. -- Cheers, David / dhildenb