From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D45C433E9 for ; Thu, 11 Mar 2021 16:52:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 474AF64FE9 for ; Thu, 11 Mar 2021 16:52:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 474AF64FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A15EA8D02CF; Thu, 11 Mar 2021 11:51:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C5F98D02B2; Thu, 11 Mar 2021 11:51:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88CC58D02CF; Thu, 11 Mar 2021 11:51:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 6D6838D02B2 for ; Thu, 11 Mar 2021 11:51:59 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 313EF1DEF for ; Thu, 11 Mar 2021 16:51:59 +0000 (UTC) X-FDA: 77908185558.25.267315E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf11.hostedemail.com (Postfix) with ESMTP id D31E52000390 for ; Thu, 11 Mar 2021 16:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615481518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2oUQOTqIayM7rAUTJf2DiLhfIeUSxHLTZHaHhcXdXXQ=; b=g6C1xG6ssOdu43RQFSWWzv+6mho64H6u9eGwX6H+UrwCdYuwg0go6um4IZZDkjq8TZESZy z3TnaT2JlYgk2oDVwhmnv5fiWAZHr/2flikzAvqML8tYHXnTzq5yWzzkSk235LYvSm0yDv BlM4cJLBtu+sK9xBxDcq14rdkvK/cYo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-ZN6jh1fsMMyibfMV9z6d5A-1; Thu, 11 Mar 2021 11:51:56 -0500 X-MC-Unique: ZN6jh1fsMMyibfMV9z6d5A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5306E83DEA6; Thu, 11 Mar 2021 16:51:55 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4289560BE5; Thu, 11 Mar 2021 16:51:54 +0000 (UTC) Subject: Re: [PATCH] mm/highmem.c: fix coding style issue To: songqiang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210311095015.14277-1-songqiang@uniontech.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <96db7761-b332-a1c2-f13c-a09ecd46705e@redhat.com> Date: Thu, 11 Mar 2021 17:51:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210311095015.14277-1-songqiang@uniontech.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Stat-Signature: k5gt4h7ropiudzund7mbzw9eoqmq4trm X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D31E52000390 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615481512-205608 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.03.21 10:50, songqiang wrote: > Delete/add some blank lines and some blank spaces > > Signed-off-by: songqiang > --- > mm/highmem.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/mm/highmem.c b/mm/highmem.c > index 1352a27951e3..902154b76030 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -110,7 +110,7 @@ EXPORT_SYMBOL(_totalhigh_pages); > > EXPORT_PER_CPU_SYMBOL(__kmap_atomic_idx); > > -unsigned int nr_free_highpages (void) > +unsigned int nr_free_highpages(void) > { > struct zone *zone; > unsigned int pages = 0; > @@ -126,7 +126,7 @@ unsigned int nr_free_highpages (void) > static int pkmap_count[LAST_PKMAP]; > static __cacheline_aligned_in_smp DEFINE_SPINLOCK(kmap_lock); > > -pte_t * pkmap_page_table; > +pte_t *pkmap_page_table; > > /* > * Most architectures have no use for kmap_high_get(), so let's abstract > @@ -153,6 +153,7 @@ struct page *kmap_to_page(void *vaddr) > > if (addr >= PKMAP_ADDR(0) && addr < PKMAP_ADDR(LAST_PKMAP)) { > int i = PKMAP_NR(addr); > + > return pte_page(pkmap_page_table[i]); > } > > @@ -287,9 +288,8 @@ void *kmap_high(struct page *page) > pkmap_count[PKMAP_NR(vaddr)]++; > BUG_ON(pkmap_count[PKMAP_NR(vaddr)] < 2); > unlock_kmap(); > - return (void*) vaddr; > + return (void *) vaddr; > } > - > EXPORT_SYMBOL(kmap_high); > > #ifdef ARCH_NEEDS_KMAP_HIGH_GET > @@ -314,7 +314,7 @@ void *kmap_high_get(struct page *page) > pkmap_count[PKMAP_NR(vaddr)]++; > } > unlock_kmap_any(flags); > - return (void*) vaddr; > + return (void *) vaddr; > } > #endif > > @@ -367,7 +367,6 @@ void kunmap_high(struct page *page) > if (need_wakeup) > wake_up(pkmap_map_wait); > } > - > EXPORT_SYMBOL(kunmap_high); > #endif /* CONFIG_HIGHMEM */ > > @@ -431,7 +430,6 @@ void *page_address(const struct page *page) > spin_unlock_irqrestore(&pas->lock, flags); > return ret; > } > - > EXPORT_SYMBOL(page_address); > > /** > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb