From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8BCC5AE59 for ; Thu, 5 Jun 2025 10:32:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A45D6B0580; Thu, 5 Jun 2025 06:32:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77C736B0581; Thu, 5 Jun 2025 06:32:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 693056B0583; Thu, 5 Jun 2025 06:32:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 48EC66B0580 for ; Thu, 5 Jun 2025 06:32:20 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 093CC80373 for ; Thu, 5 Jun 2025 10:32:20 +0000 (UTC) X-FDA: 83520982440.22.6F0DC69 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf25.hostedemail.com (Postfix) with ESMTP id 2F4DAA0008 for ; Thu, 5 Jun 2025 10:32:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mTO2KFvA; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749119538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RcMUQCfxa0uC8pzdzvPwMQlIQ3/k2Rjbm8T9aOOzae0=; b=PNLPvYiEk8bqSCF1543aiWCiTlu4w8XjFEFlUeOwtGYkOrSgoROVIZDYqxJll5AaLhdTsJ YSd73g5Ol9BeVEUyV3wzjd3d89kBCjS0sJCb24VSKEE7/kYOqwMe2Y3lZ+DWm6Jg2zpmRE McKEFa+oF/iNy/rmVvk8WQqGbOiH8fk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mTO2KFvA; spf=pass (imf25.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=asml.silence@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749119538; a=rsa-sha256; cv=none; b=sZU4QdsO3nVuUBbtTxrdFpTpmKRDfwYPpFP5bff1Ya3TUWpI5T3CMP+OZpiNA8I5AMw3kJ sP+mJ3UcHakOWTV6ZsxNQfBmrtCUlm156IpVmjYc2mPzpb1qin+toyn7DGXukl5bVvCQW+ H3HIQQel4itQj5Ws2RQsAxBS1i5G6EU= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-60410a9c6dcso1716166a12.1 for ; Thu, 05 Jun 2025 03:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749119536; x=1749724336; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RcMUQCfxa0uC8pzdzvPwMQlIQ3/k2Rjbm8T9aOOzae0=; b=mTO2KFvApQJzSkQN3xsujyJKLSnI+3xAgwhn7AykMwd/EzkwwKviuH4MPsa5hQ85p0 EHr8T8vKWEhuKghil5y9o4OOFSy/Ih6GJ7xoNPKOjEm2vgwOMXqSQZNdHzXVn5du+J61 s91vww+rrns40sisswfvBXDp7qbKDX4UelLCGSdRyYmAvr/UeE0fNEaTgzXKm1TfeAOq RQ+LTbvQwN6NyDu1xcvKgDhzH5fByT50yr4nBEsW6Q7OIqaI6Fqxckc/YmggczEFu7X8 8r21LqZY+nE+sFXmcqfBowBz09vngOENq7ArlFtychAdlRBlB4JNJbYS/iWhWowg3AKE EexQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749119536; x=1749724336; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RcMUQCfxa0uC8pzdzvPwMQlIQ3/k2Rjbm8T9aOOzae0=; b=rf9giz4hwRgA52ZbmE3a0P6GZYonVNzJv+Vk0wzIQismMBC2hZrdyCNBMjj7lI1pur Y78pGs1hrt0JMUGVhNfzth4oHTOwe742ycI5V0c7m3aDLB6OO6OGwJ0UesZQqMa3wTf1 JNnd3FTfVoWch0b3O2P1+6iUGTYhBvmOyTYrJrKOt/wvo27RaTlueR3unWfVOdHrfJYz iiz0mk8Xfi2/BRyrildeQedcwFP33ApPAqkev5gPhyKmWK12ZLvpXjc8SDMunF6KyH2i ZvBJsTWBLAtqD8334OvyowZ1zFOkIm8lKg44JZpfkb9vPMeJaoeZ9kbaGo2WTp0uNbgY qNVw== X-Forwarded-Encrypted: i=1; AJvYcCXLFpnrYAuCKM1UwsMOmCwP35UqxBvbZzKiZv5EfA3PJVeG0s2Ga3rxQ6kv9D9fUOn4G/5vsxhs4Q==@kvack.org X-Gm-Message-State: AOJu0Yz0Ypf7d5+yXKOQhbHuDzQUIyxR7KvQjEd4hHknw7wpLQDWSe6B /wGyREcEGlHiLKJN10S+RvPhg1BLtxJLwnHhaasWYRUjSBYyQQyT3WAY X-Gm-Gg: ASbGncv8N7Az88/QhK6Mb9l4I1Y96s2zTPAFyxmwo48dBH/a2vuIqnfAvNlFDEpG5uZ y1fTkEQhYlkGxtxsaIqHldbn9sm6AhxNIsxPuHW64esuLE843sux1Wzv/RDaNjaNc7Kkm1Ttsuj ZHIXJSvRYN37OPdDM9Q/8PyEqXQlpWknFpyWHX5qHeVoGd0RHIzEXIwY+JxOvqHfpS0//Z6Deb6 xgzOiB5DgUFuKkPPUt36B4whxtaAsMqo/CXcN5F6DMaQtJ6lycRL+vuV3FUX/1KfuFcrk+MW9se 3oPDyemdB80Zg9bVyWjzOAgv9O5e9LfU41LBbfTTMUxSXVCdPPWIoUopocdqncYv X-Google-Smtp-Source: AGHT+IGJV4w4MyjgzgbWc6ZlWikV0SpiTCf2D3BKmMkklaQZpTnw0Xa1hsU1I+YbdE/tucex19ZGDQ== X-Received: by 2002:a05:6402:1e8f:b0:603:5a23:2997 with SMTP id 4fb4d7f45d1cf-606ea15f285mr6577294a12.17.1749119536398; Thu, 05 Jun 2025 03:32:16 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::22f? ([2620:10d:c092:600::1:d66f]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-606f0d84327sm2114656a12.30.2025.06.05.03.32.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 03:32:15 -0700 (PDT) Message-ID: <96d3ffe0-b743-4596-aaee-87cce1603756@gmail.com> Date: Thu, 5 Jun 2025 11:33:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v4 07/18] page_pool: use netmem put API in page_pool_return_netmem() To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com References: <20250604025246.61616-1-byungchul@sk.com> <20250604025246.61616-8-byungchul@sk.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20250604025246.61616-8-byungchul@sk.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 6um4go1q6qfqhxzgd5z6izz8ncqdbsph X-Rspamd-Queue-Id: 2F4DAA0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749119537-758119 X-HE-Meta: U2FsdGVkX1/6bkdO7NQsvzkcOp/vN+9iwrbxnVomxvbMdRyuxsBTSiMkpi3Zd1VqbRyjfmvqBZebtqU3BsFx85+YchQqQzFclHvPscFdyDwrwQUsP44mMS4diRbc+ok0dA11PcAiNs3LHv+NKraQS6UnpJsKxpI/qzWeyn9jlEtIWWEOLcvz8H6f6gfBOJG/Zl5plIixPlvm0o2QOgAhCbSVMbvcNl1Z+y8nMEOj7lLcLoFVTg6U6piIBYHoOASXiQBZeJ7OJnAq/WJGSzoCkZByNG3NZKD8kbWMBchGZLjP3N6Efg/Hj2mtRiZZYXNrcYcsa9+jPzmGaVMuaT4ZQz/xAgIc0rRR5sL12om+ENefFjsFcLdLWQAeCUD1l+Mthi+KIbRLY9mmHFdG3Ko1iA55IJc3rNS4WJkFsbw+WZzApXG+CfTMifWhKG/j8uRk1UZu/uGmUfYpU3w/YPrz5lX2Z5zzMpqCI2iohBe0415dQfsz0nG0XIrX33a93jS++WfqH4ypl0sIZRTvM1q7TDIJ9/gaAm4Q3Y6xJ74bsko0f0i1S/Gw0gwubm9g+4KIlIiWoIeu8Ptdv4w7rMLjlU6gmbZvB9/NJVklu6NWpt8SqcePgAV2P5+A/1TOF6qv2U/tOqt/d9nK9sutBvJunARK/xwjZROifWZ4pFZiE1BtErmWbn8vt2JBcp8nDQls2y6/+nqf4fw1baYDt5Rtm4jd59drl+EIAwQ/mKEtwRIawJVZfkyVUv7hQCUmbcNLCilEknmoYKhwQwTmazKgrii6mKWsYhSJ7jC2AnxH+t8BKyzj/Vd8Tu56b3LSWoyovtqwg3eFN0P3QG0+681vV3WJvt/TuvcEkgbpJZXjaNeOQx9n/oZi2R7h63F9Kk3O4XkqTUvbo8uFYLZYdBbLvUrwS70H9SwNPs85oUDx51501/XMJ3rxv9Fv7/RWYRri2NyR3uSgAnsbCdGvBYi BgHm7GGX O5kt/vgBkh9ahFWjMI+nvsNogm+geRZecY4kRXLbuTglbCBP4AdMZNSwsx0/Bkmz9tgtmmS60+3mR/mYJiNXiNku9REBdPgixSnEz38w+YqPcJMFjVIvOlw3vio/fnKI29UhmBFgJDGcd+j0T5MGu4JGQJUZAuzuvv3SMidpbC5wySYDF2mMQZYuheg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/4/25 03:52, Byungchul Park wrote: > Use netmem put API, put_netmem(), instead of put_page() in > page_pool_return_netmem(). > > While at it, delete #include since the last put_page() in > page_pool.c has been just removed with this patch. > > Signed-off-by: Byungchul Park > Reviewed-by: Mina Almasry > --- > net/core/page_pool.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index b7680dcb83e4..dab89bc69f10 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -20,7 +20,6 @@ > #include > #include > #include > -#include /* for put_page() */ > #include > #include > #include > @@ -712,7 +711,7 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool, > /* Disconnects a page (from a page_pool). API users can have a need > * to disconnect a page (from a page_pool), to allow it to be used as > * a regular page (that will eventually be returned to the normal > - * page-allocator via put_page). > + * page-allocator via put_netmem()). > */ > static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem) > { > @@ -733,7 +732,7 @@ static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem) > > if (put) { > page_pool_clear_pp_info(netmem); > - put_page(netmem_to_page(netmem)); > + put_netmem(netmem); Same comment as well. I guess we shouldn't even be returning "put" from memory providers. -- Pavel Begunkov