From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE92E64AB1 for ; Tue, 3 Dec 2024 14:12:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A23016B009D; Tue, 3 Dec 2024 09:12:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D2C56B009E; Tue, 3 Dec 2024 09:12:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 873856B009F; Tue, 3 Dec 2024 09:12:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 675B96B009D for ; Tue, 3 Dec 2024 09:12:16 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F34E3809DC for ; Tue, 3 Dec 2024 14:12:15 +0000 (UTC) X-FDA: 82853836842.01.2B3C048 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 5CFEF80020 for ; Tue, 3 Dec 2024 14:11:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XwbdnbGG; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733235120; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DfmOmAYsWzbzU97D/IfZswWynVBYus13MGWPWCnnhmw=; b=p1wGIMI3vJ2K7ef4WHSgs1TGUyMsmJHw/tUBwrDuhFYEmj1ZCDruCdgUNccifk7u6pJjsF yCYfOdZFRNRCJX/PsB+wwMSIp1t+GytRqFskbkaABG6u/kMLhu7voIZ9goj2JVDE/t3DgL fkdHbAe9UKrBLxHsNgGUqPuwkxCZM5U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733235120; a=rsa-sha256; cv=none; b=oo8w1hHu2DvFMpQ7O4iHrHBmGTYsXy5i10LcQJWg7NNYe/7LLXlynPPaaqad4bxShj8hyD HiIGXzXR6C+3nUgLeaU7mAdzebV5i50XOJHvRLgQ/oY/Cv7q8sDqufKN4458SZe7ux7Wyy R+6c849vPc63wHCjGSMjBvKOk8GW7Yg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XwbdnbGG; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733235132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DfmOmAYsWzbzU97D/IfZswWynVBYus13MGWPWCnnhmw=; b=XwbdnbGGY7s6HAV/fnBVl4d0CyrWolCXWeNNJ+jlCF2ylKXpdIYKIZKNUDF/aFSX1E5l5U IDmbriXMF3Vz2GIqSQYimzboNaKrogRcQ8QJvyI0c/Rf90Z6nPiwKUIVPqwZJYY/FXAhFx KG5Qi3olpm4n/Zk6Kz2gbgxevH9KD28= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-PezvAzvPMma91E4dPGVt1A-1; Tue, 03 Dec 2024 09:12:11 -0500 X-MC-Unique: PezvAzvPMma91E4dPGVt1A-1 X-Mimecast-MFC-AGG-ID: PezvAzvPMma91E4dPGVt1A Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385df115288so1951386f8f.2 for ; Tue, 03 Dec 2024 06:12:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733235130; x=1733839930; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DfmOmAYsWzbzU97D/IfZswWynVBYus13MGWPWCnnhmw=; b=O9M+uVehXSJLcBV5fgPSD7vKH0Mp1zPALWH2m/LyvGYJwyGeOGDDd+icqcVDVMJcJG +g/p8GjO5Hi1SqmeINoR9F52EHD6oZo1LdvAP5n4vutRkBrQKmFt1KuI3nMWFw4BFMqD VW71iHHg8iSJvMUq2J63elCEWj0gcAFiqMkNrSAa90U/sIzlk3fMo0yRfTWvKyt2Qyc4 OeJvB/Y7w6KPpMpv9qjepJknYGaYQk+j9mQx4S75uKfOzD5HTquQMogjpz37bhUrG6Q5 Z9wb+ngg8WH9LlWCyJyFA6jSPCOlDhUns//hkhWhYLqs9NzGy1iPEdOhEzBhJxkdRWnu BHTQ== X-Gm-Message-State: AOJu0YyeQPAqgmEEHRJEVQmfQTKBhxBKGv+TqDed+ocEUDrCen7MrcMi 9Uf9o+jAxwjqBT5SguzBmCvi+MG7pAIbAFJrpRgrcLY8sVfiQ7OSqyneOTDbDUWsSmnJnxq8noo 2KXKDaSzWMRw0IDj8OpFxi1uSxZ2tVBH3jFGnrfHBFcyzPyWV X-Gm-Gg: ASbGncuwZDICAjruIeQh8FI5ofL9KJK0XqstXzbXERHBYgWsC3j+vfhpbJ0XgSwUAGs msRCCvIMcOxrovHlNo0z8IN9pN5Dm2anNrRWDyqWZ59MZyA13rkGTr/K23R3at/M+K6j00U/T8C vDfxVJqU9Y3F4erLbudhbm8NF1ECdcEULOOw5/CPaimqUGnn9hKppxP48b+Kh+12zd9urP7vDw+ CC50Ruc/MdskMhzhAHoFsfYO9QzHh+obFYx510JL/MB4Xk7xqEVjHHK5UpyPVBbBi1KptlJAlhB AgO8GLYlTkeO8gFHLl7iy4oGMuBjWEs8HjzsIvhXsDPjwodxlwkmEHeJn2H7aXOpKg4TroLB7Jc Uqg== X-Received: by 2002:a5d:6dae:0:b0:385:e013:73f6 with SMTP id ffacd0b85a97d-385fd4358aemr2081366f8f.50.1733235130377; Tue, 03 Dec 2024 06:12:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcy+idlIWvQSkgkkanBxL+r+HUHonkY6filCiyNJa2RVw7yISuYzu4QI0/PKYJnAmni+KX1w== X-Received: by 2002:a5d:6dae:0:b0:385:e013:73f6 with SMTP id ffacd0b85a97d-385fd4358aemr2081341f8f.50.1733235129950; Tue, 03 Dec 2024 06:12:09 -0800 (PST) Received: from ?IPV6:2003:cb:c746:1b00:fd9e:c26c:c552:1de7? (p200300cbc7461b00fd9ec26cc5521de7.dip0.t-ipconnect.de. [2003:cb:c746:1b00:fd9e:c26c:c552:1de7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ea9c5952sm8447173f8f.67.2024.12.03.06.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 06:12:07 -0800 (PST) Message-ID: <96c92857-4850-4f85-9474-ac193c5ea48c@redhat.com> Date: Tue, 3 Dec 2024 15:12:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess To: Vlastimil Babka , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OqQ03VHljrpFKG1mwMEX_uV70-uvql-aKR4C2IMUQJY_1733235130 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5CFEF80020 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: x8swzucpuox5yw65wjj7a9j94w59qour X-HE-Tag: 1733235108-912597 X-HE-Meta: U2FsdGVkX18CXVUGCzvr0v2AbkQtbAgRBTEeU21hUAiR6H/ksRuh/VEWeTzwZ9UIcRDDhpfQtZ6PidWEVq9gL0RbGp+KkP7GVd+9tlqevXsWAsGoANPUBsJA0Yi1NDRcDyz8RHxpUB+F7JieIyPddSyllZgm7k0Qd7zZULV5f/ckVn0QWsmeNLfjuVFmYitPxbrvBGo+Ar66ZvoJSTKdohYXqqIgrO7ePL2BMYcb1fKu0m373YUNnqR9CW3Fuq3EvsgmzNSU25VvyQ1YXkqv4xXyIKCmViJzU62c5N9asjKdj9zmEuo9jOOH92xzG8oO0eHgdlmSGYHFnUt6KYeoa2jQiA7PGbPsP7oyUk5vChYnkksLUoniIWOhIwpGuWqIPMSt7e8e8oiTofVEg0dOnrWMg5DAlJtwgNAQKzhb1Kv0IFvRdgdAUt+WqZse/Yrbi0UYjDxzaxXzQfZZpULUldtg627wPmJ8mQIY+0Z66DnIsujbMvt47I8mexn1jYeQfkVtGq5wPG1tjuptb/maRKxnyIG6FkIT7gAsWo/RJtBvU/1S1wqc9IMTIj+gQg2cwGi306xzbnpWDyAOdDZB+f+QINfXCzRsiIoFC8hgwOzfOL44Xpf+iTqtv8OYWzivA0H4uP/gYhxKMKGn3AAizaiQ/T4en89GcTHGeei+TwFTiAWuCW28Vfcg2GBZ6ywGNkeGwP/+qBcLcJkBkUAmQB0nBHZ8hIIRmc2z42wIEHVMWM4GYI+mSSHe98HaM/eoHtDiyaIXZL/opThTci1T0Ercg7zbrw05652syECTZ/lV8EF9SoElex1LLcIEZqWpLida2dQEXZFFWKndYhmdxJQCllvcfmb7Vns4OMAWKujX4whY+Sy8lAeSzzH0TziekeBpsjiyHNO3aGsjuF8cqoDOBoDQ6Rh3nCkZr5TTKuKgPg+ajvz2m3gtnf1CvQydpBuV1ssqKtC1RVIkwl2 C2P+2HvF byuBQUAqa+A2WAXp4pXGGGUNL0TXx7Up6oAfyTSV11HO0ga9ZWU2ZNMg1/NI/h1ZgK7cbtbxKrzO4touVG6rX668xChTdcTi77HMTrCmjHorLoSNRyUGb1TCFBT7IwJcrjqnCyHeiYBDb5AH+a2gQpzpHmdnswPDc7Ui5WJj7PuySnKdArA4gC01MF9YyRKs3/gwURAWqnrsPTnUEEc9zQ7X2DM/ajRvSP0v151uO/Pf28JAVjKbOvIHiKuLwtgs9T+Pop6Ac5VtZADH9bPoCqSWTdSlIfGNLDj29N1tF+YvijdwVBE6jNAgd5E44GV04hXlAxwxTAuVIBZzgNxkDr8R9u0CKcKQ/8MkrYLLdADUlJCj3H43RT3ktaf4ucSt63UwTSnD0XT3ST5aPvlXA5x2X6XvQdzzflnRox1YMGOLJDktFwKi1CY3F7ml9HmavXXNg1zdl2dJu5CZjxy5DPzHbGMpKOTl+Q+PDlFjYQar2kiwusxYQEvvzkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.12.24 14:55, Vlastimil Babka wrote: > On 12/3/24 10:47, David Hildenbrand wrote: >> It's all a bit complicated for alloc_contig_range(). For example, we don't >> support many flags, so let's start bailing out on unsupported >> ones -- ignoring the placement hints, as we are already given the range >> to allocate. >> >> While we currently set cc.gfp_mask, in __alloc_contig_migrate_range() we >> simply create yet another GFP mask whereby we ignore the reclaim flags >> specify by the caller. That looks very inconsistent. >> >> Let's clean it up, constructing the gfp flags used for >> compaction/migration exactly once. Update the documentation of the >> gfp_mask parameter for alloc_contig_range() and alloc_contig_pages(). >> >> Acked-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Reviewed-by: Vlastimil Babka > >> + /* >> + * Flags to control page compaction/migration/reclaim, to free up our >> + * page range. Migratable pages are movable, __GFP_MOVABLE is implied >> + * for them. >> + * >> + * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, >> + * keep doing that to not degrade callers. >> + */ > > Wonder if we could revisit that eventually. Why limit migration targets by > cpuset via __GFP_HARDWALL if we were not called with __GFP_HARDWALL? And why > weaken the attempts with __GFP_RETRY_MAYFAIL if we didn't specify it? See below. > > Unless I'm missing something, cc->gfp is only checked for __GFP_FS and > __GFP_NOWARN in few places, so it's mostly migration_target_control the > callers could meaningfully influence. Note the fist change in the file, where we now use the mask instead of coming up with another one out of the blue. :) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ce7589a4ec01..54594cc4f650 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6294,7 +6294,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, int ret = 0; struct migration_target_control mtc = { .nid = zone_to_nid(cc->zone), - .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, + .gfp_mask = cc->gfp_mask, .reason = MR_CONTIG_RANGE, }; GFP_USER contains __GFP_HARDWALL. I am not sure if that matters here, but likely the thing we are assuming here is that we are migrating a page, and usually, these are user allocation (except maybe balloon and some other non-lru movable things). The __GFP_RETRY_MAYFAIL should be moved to relevant callers a some point, __GFP_HARDWALL, I really don't know ... Thanks! -- Cheers, David / dhildenb