From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4623DC07E95 for ; Tue, 13 Jul 2021 09:54:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EEE5E611C0 for ; Tue, 13 Jul 2021 09:54:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEE5E611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6A666B008C; Tue, 13 Jul 2021 05:54:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1AFE6B0095; Tue, 13 Jul 2021 05:54:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92F56B0096; Tue, 13 Jul 2021 05:54:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 7E4126B008C for ; Tue, 13 Jul 2021 05:54:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7BBA8801CFB7 for ; Tue, 13 Jul 2021 09:54:13 +0000 (UTC) X-FDA: 78357103986.26.982C7C2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1CA6F1005F73 for ; Tue, 13 Jul 2021 09:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626170052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UQUA4XjWtFIdSS44lKXsaGZ9gPXuO/+EtKLUDI1CWwM=; b=JYNoa56R5NjCKFWLn0VKeoE/MpcPiZSsZBEid4WtrK0kMwiGAWnPlT4gsHPKtLB2jIoDQy wYDo0BnPNCq3vVCmA/kaZhqj+h1ai2dqcR4Th9/AcwAjUSptem5/DlYAELlmLRX66ITkAy nEGQ86vcnxF6gS16rid7RHOSF4OhD2M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-9TBhGs_POoWx-qceYxY5dQ-1; Tue, 13 Jul 2021 05:54:11 -0400 X-MC-Unique: 9TBhGs_POoWx-qceYxY5dQ-1 Received: by mail-wr1-f69.google.com with SMTP id k3-20020a5d52430000b0290138092aea94so8519558wrc.20 for ; Tue, 13 Jul 2021 02:54:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UQUA4XjWtFIdSS44lKXsaGZ9gPXuO/+EtKLUDI1CWwM=; b=hVLzQoco2Ba/ft3T9J1CAlkxdPozriui637ecgwZL+9dD4z26BIwkA/lXAv5PMFYCn Lj8j8wk0/pHgaLdoFG5BjxJ4Gaed+zrgJKeRN9JKftX3dSOp+oWG49UABBU9bH/pXRiR SO461ZJkMH1YQdzimF/e8iLWYBCLCGd0CuGUC2EuF9zaqr0awMmVFn4ppJ5rqqkfZSza 5Og//bnXUeX6gXcBFZ4AAiREywvo1/K9iwBEj80nQvkHRM8txmIeR1uj2J1T4WNZ2fLW dgy6g1LTGr2pRJXGowMHIhcu0wofwYY6VoGSQvUhTzhv4wC2o1/Hva9cnBqpw1iKNYn2 sYXQ== X-Gm-Message-State: AOAM53298xCJyv76k2GcNr7ov6kjmbyIE4kGkjqWEh807yo+FwXwltQ5 X3SDfy2TxWjJ+oM/KiAIavuHT2DYBXHy4Vu+JMZ2Dyukr/aMpZaCd4ahE7HcwFFy0A/Y/GRgJnh kHZiU8gndT1+Iltxpcdv9CncG1lF8MD/0FjoXHW1iWxdJ34b3TUT2olEJ0Do= X-Received: by 2002:a05:6000:144b:: with SMTP id v11mr4512161wrx.421.1626170049985; Tue, 13 Jul 2021 02:54:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUXJjGiSggIjjcS6mq/dEYjjpH3o8CCaZ3jV8jrdUq7JJeLM6LbE8+nzPbmFjA63jBsHlWVQ== X-Received: by 2002:a05:6000:144b:: with SMTP id v11mr4512130wrx.421.1626170049725; Tue, 13 Jul 2021 02:54:09 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id c2sm896405wrs.60.2021.07.13.02.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jul 2021 02:54:09 -0700 (PDT) Subject: Re: [PATCH 2/2] mm: memory_hotplug: cleanup after removal of pfn_valid_within() To: Mike Rapoport , Andrew Morton Cc: Greg Kroah-Hartman , Mike Rapoport , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210713080035.7464-1-rppt@kernel.org> <20210713080035.7464-3-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <96c061b4-c9cf-f481-5319-f26464435eb6@redhat.com> Date: Tue, 13 Jul 2021 11:54:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713080035.7464-3-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1CA6F1005F73 X-Stat-Signature: nfjnndh9kmnry4ioonng7685pe97kzod Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JYNoa56R; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1626170052-40928 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.21 10:00, Mike Rapoport wrote: > From: Mike Rapoport > > When test_pages_in_a_zone() used pfn_valid_within() is has some logic > surrounding pfn_valid_within() checks. > > Since pfn_valid_within() is gone, this logic can be removed. > > Signed-off-by: Mike Rapoport > --- > mm/memory_hotplug.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1085bd03ecba..ca09045bb587 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1298,7 +1298,7 @@ struct zone *test_pages_in_a_zone(unsigned long start_pfn, > unsigned long pfn, sec_end_pfn; > struct zone *zone = NULL; > struct page *page; > - int i; > + > for (pfn = start_pfn, sec_end_pfn = SECTION_ALIGN_UP(start_pfn + 1); > pfn < end_pfn; > pfn = sec_end_pfn, sec_end_pfn += PAGES_PER_SECTION) { > @@ -1307,13 +1307,10 @@ struct zone *test_pages_in_a_zone(unsigned long start_pfn, > continue; > for (; pfn < sec_end_pfn && pfn < end_pfn; > pfn += MAX_ORDER_NR_PAGES) { > - i = 0; > - if (i == MAX_ORDER_NR_PAGES || pfn + i >= end_pfn) > - continue; > /* Check if we got outside of the zone */ > - if (zone && !zone_spans_pfn(zone, pfn + i)) > + if (zone && !zone_spans_pfn(zone, pfn)) > return NULL; > - page = pfn_to_page(pfn + i); > + page = pfn_to_page(pfn); > if (zone && page_zone(page) != zone) > return NULL; > zone = page_zone(page); > I'd just squash that into the previous commit. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb